Received: by 2002:ab2:784b:0:b0:1fd:adc2:8405 with SMTP id m11csp243602lqp; Mon, 10 Jun 2024 02:40:12 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXyZCQlfqAU1ufvQ5fae5ZBUd7btIDI+da25kERa+sybWoqPuVNTJDxh3ZoQWRxVgHKmm/ko58FzpwqViCGS7VpVzlRclTVEB+Jzudm7Q== X-Google-Smtp-Source: AGHT+IEWKuF9Th9r42PYQVb3Qf/d8zG13B4FGnQzm8vOJkfq6q2GarLjlbrFW9PGEJf9MPcJ78qN X-Received: by 2002:a05:620a:4090:b0:795:1c6a:686 with SMTP id af79cd13be357-7953c5e15f7mr1031225685a.11.1718012412237; Mon, 10 Jun 2024 02:40:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718012412; cv=pass; d=google.com; s=arc-20160816; b=kIdioLvK16/FF7Fv7kFc/Z23YDUiDWMM2LoKuN62SmqwFWzc2ImWtZxdV6euWP1DSP NQBhd0SNYQxHBOVU26t5Iu+sAps0Wx9hhMeC76ghZPAOlLloXhM2gOV1OXuut5KcW4bw O3TZYvzjLKM5VTmPcbD6UNKG+XNqTl/1nrxLZ3gfcEEFDDalJMeaMlYOEZfrYeyvf5XL aaGd3wRHsdNiKPpSq0v4waytF/vGv4yuE3RGGQjJtAHtp+CdpN/6nXMRFMLUWZWRbe9+ niAQgWeHB33WpCrD91osCleeiVUjAiH1iw/1trL1aUD6t9gQbBQV+tzF77wYkt85KM/I 05FQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:subject:cc:to:from :date:dkim-signature; bh=ocMM4wK0KoJUr2SNgjlZ+bFq4hxDtEwVWf5fWyCNQzA=; fh=xe+Gde5zlju50J8VP4u6919HVgnFuD4l3LaR5YOZ9e8=; b=Z0dzlYWp6yuopwcwbwmdogClRtobbt7lT1q1BLp8Q2ga5NoIrUf68sw/XCcXh8J3oO q5w/h/pIxdfhNh2n1xSptmOvKzhiu9GePWA1+JnYUD4fA8o2j1jMphKbPgEyTlpq3N9w pGWOElk05ElXcxnY0lju4cHzmen+mB3mIfdEXtoVrXDsqdh+qD5l8Ygt28KeVScj73lM pPx5uQawStAR8iQZvsmAEh2BQ6Il+NrjnZrHgx38rhHd+UEHTYvyHFpV3MN9vjI1G1Um sqmI2TQIRwc8wxFGU8VF8JYTwwGyRGIQQve3JzeO1nz8qhJ6fx5FKQeq7jXITG+DXHK4 gVbg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GQlh0vnA; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-207957-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207957-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d75a77b69052e-44038b76834si92614431cf.672.2024.06.10.02.40.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 02:40:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-207957-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GQlh0vnA; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-207957-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207957-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E3E621C214A2 for ; Mon, 10 Jun 2024 09:40:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8B43C74C1B; Mon, 10 Jun 2024 09:40:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GQlh0vnA" Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF264CA62 for ; Mon, 10 Jun 2024 09:40:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718012402; cv=none; b=ghT4En6OlWdx6xX/QCViNO7+HNcbJ+CPUWiAW4RdNHb7i/xob8Yj/wxfoTbsy1XET0HebwLLaclRLCksmYZdgVBRMio156UyS8cfNr+IOLr34aiJssq72d302+A1wqsnCJyYQcse94KH9z7aHK+7yki+Cj2Ba308G8ESkQhIbwM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718012402; c=relaxed/simple; bh=Td/N4E9UURCdvg10DSgcFTNUdT3qZG8vl6zhjaJaZbU=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=IfAf5//y9CDmPYigQj8dvjxjnB/3ou0Ux1BS955V3loLGPNDTNl9EG7rPxNJszPOuvAs/R/vSoiNmk5gJFCbp2MMZvT16EyA3xbpThmdc4n3CGQcNcOgWRUcl/yqYJeFuaKx34DMnymBUcJebTZ6rcf0cDmFrHGdW3yc4cJov/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GQlh0vnA; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-35f22d3abf1so798375f8f.1 for ; Mon, 10 Jun 2024 02:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718012399; x=1718617199; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ocMM4wK0KoJUr2SNgjlZ+bFq4hxDtEwVWf5fWyCNQzA=; b=GQlh0vnA/ENo9JZ5o/IbR+H28DbzWybrVyUvMVcnVB30OF/Bh4+Ld+c1Zdpn+8QMx1 ZHHwbcwHUgKOCiNf/Jx+fHc7jQKIwd94Hf//0aJJXDoZf6klysH6i8z0/FLVQo0iDq5G 8AB4qNdUapHrJsaElTk6hDGQKiFZiwsByfRLDJaR8OIjVQcpR7jhwiH70GDEqTAA+Qv+ +zNPnetzCcOzlvTcfYXUPfVhYiR56JbdDhuOVAyfP9p27XEseDIYjziVFHP/jB9C81No DO3gbi+MGXRbOOflXbou4EhRo7Y3etBkAHczGlVNkbzbWkrZ20YOmrvA/MWuMluSjnNE riVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718012399; x=1718617199; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ocMM4wK0KoJUr2SNgjlZ+bFq4hxDtEwVWf5fWyCNQzA=; b=ajMXYtA0pDYGmHRPYHE5Cocm9uPUHh+FMfAHqDNsKoS99udYYSIz9iUmJ0sgIi+xlD 3Jy4nALG/LQhDGLjqmK99xTJ+Iv6uvK/Q/XOE0i38KHzghJiskTFYXWxNJrMNr6F/wRa AgLKterdkxDO065ZffXhiLCgpGf4Nh9LTbmeh3B4WcfHvEVj2gTWjMbtbbNT+sGo7Q2Q NRG4eH7zVCfVop3Fc6bkgyH3kvdAWErKXLgld+4Sh948zZGSHwBXZGGkzL4eUSmcNNVp wC26z8MDxC8zVdynjWw1KPiTwN8vXDJLUaLOFAmGDpLt1ajPnnrGYi7rcXdoOXDQCYgt S+9w== X-Forwarded-Encrypted: i=1; AJvYcCXX/Cp7zVyiaYPV0mwZPzb+Ko6Sni/WJDQyLyQMmpvivVSVhUfQUyuWRwWNgRMH18LxuEB1K6Eci8SW8dpmi7hU+6ZPXEw6k/ASIcqS X-Gm-Message-State: AOJu0YwoGPx2Mr934eCYlatZhn24Eu4355i0Z/rIoVYGfANRBC3UFYWk 3JdbkLMQHP/OyuokxJegKkkk7hLrsVLjdhX9DMKVk6Jk0ELnpPBvVCbn1RPIb/g= X-Received: by 2002:a5d:5987:0:b0:355:4cb:5048 with SMTP id ffacd0b85a97d-35efedd95f9mr7952708f8f.43.1718012398839; Mon, 10 Jun 2024 02:39:58 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4215c19e567sm136806365e9.1.2024.06.10.02.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 02:39:58 -0700 (PDT) Date: Mon, 10 Jun 2024 12:39:54 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Charles Wang , dmitry.torokhov@gmail.com, jikos@kernel.org, bentiss@kernel.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, hbarnor@chromium.org, dianders@chromium.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Charles Wang Subject: Re: [PATCH v3] HID: hid-goodix: Add Goodix HID-over-SPI driver Message-ID: <030b639e-f5d1-40a2-8980-f436ca686e6e@moroto.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240607133709.3518-1-charles.goodix@gmail.com> Hi Charles, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Charles-Wang/HID-hid-goodix-Add-Goodix-HID-over-SPI-driver/20240607-214042 base: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next patch link: https://lore.kernel.org/r/20240607133709.3518-1-charles.goodix%40gmail.com patch subject: [PATCH v3] HID: hid-goodix: Add Goodix HID-over-SPI driver config: sparc64-randconfig-r071-20240609 (https://download.01.org/0day-ci/archive/20240610/202406101633.1RJnij1Y-lkp@intel.com/config) compiler: sparc64-linux-gcc (GCC) 13.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202406101633.1RJnij1Y-lkp@intel.com/ smatch warnings: drivers/hid/hid-goodix-spi.c:217 goodix_hid_parse() error: uninitialized symbol 'rdesc'. vim +/rdesc +217 drivers/hid/hid-goodix-spi.c bb11c3a1740813 Charles Wang 2024-06-07 214 static int goodix_hid_parse(struct hid_device *hid) bb11c3a1740813 Charles Wang 2024-06-07 215 { bb11c3a1740813 Charles Wang 2024-06-07 216 struct goodix_ts_data *ts = hid->driver_data; bb11c3a1740813 Charles Wang 2024-06-07 @217 u8 *rdesc __free(kfree); bb11c3a1740813 Charles Wang 2024-06-07 218 u16 rsize; bb11c3a1740813 Charles Wang 2024-06-07 219 int error; bb11c3a1740813 Charles Wang 2024-06-07 220 bb11c3a1740813 Charles Wang 2024-06-07 221 rsize = le16_to_cpu(ts->hid_desc.report_desc_lenght); bb11c3a1740813 Charles Wang 2024-06-07 222 if (!rsize || rsize > HID_MAX_DESCRIPTOR_SIZE) { bb11c3a1740813 Charles Wang 2024-06-07 223 dev_err(ts->dev, "invalid report desc size %d", rsize); bb11c3a1740813 Charles Wang 2024-06-07 224 return -EINVAL; ^^^^^^^^^^^^^^^ rdesc isn't initialized here. It should be declared as: u8 *rdesc __free(kfree) = NULL; bb11c3a1740813 Charles Wang 2024-06-07 225 } bb11c3a1740813 Charles Wang 2024-06-07 226 bb11c3a1740813 Charles Wang 2024-06-07 227 rdesc = kzalloc(rsize, GFP_KERNEL); Or it could be declared here instead. u8 *rdesc __free(kfree) = kzalloc(rsize, GFP_KERNEL); bb11c3a1740813 Charles Wang 2024-06-07 228 if (!rdesc) bb11c3a1740813 Charles Wang 2024-06-07 229 return -ENOMEM; bb11c3a1740813 Charles Wang 2024-06-07 230 bb11c3a1740813 Charles Wang 2024-06-07 231 error = goodix_spi_read(ts, GOODIX_HID_REPORT_DESC_ADDR, rdesc, rsize); bb11c3a1740813 Charles Wang 2024-06-07 232 if (error) { bb11c3a1740813 Charles Wang 2024-06-07 233 dev_err(ts->dev, "failed get report desc, %d", error); bb11c3a1740813 Charles Wang 2024-06-07 234 return error; bb11c3a1740813 Charles Wang 2024-06-07 235 } bb11c3a1740813 Charles Wang 2024-06-07 236 bb11c3a1740813 Charles Wang 2024-06-07 237 error = hid_parse_report(hid, rdesc, rsize); bb11c3a1740813 Charles Wang 2024-06-07 238 if (error) bb11c3a1740813 Charles Wang 2024-06-07 239 dev_err(ts->dev, "failed parse report, %d", error); bb11c3a1740813 Charles Wang 2024-06-07 240 bb11c3a1740813 Charles Wang 2024-06-07 241 return error; bb11c3a1740813 Charles Wang 2024-06-07 242 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki