Received-SPF: pass (google.com: domain of linux-kernel+bounces-207982-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 10 Jun 2024 13:01:40 +0300
From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
	Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <mazziesaccount@gmail.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] iio: bu27034: Add a read only HWARDWAREGAIN
Message-ID: <5e88c7b7b0389c6c011f15e05e065791f7561cf5.1718013518.git.mazziesaccount@gmail.com>
References: <cover.1718013518.git.mazziesaccount@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="GRDaP5Vh04W+8BOG"
Content-Disposition: inline
In-Reply-To: <cover.1718013518.git.mazziesaccount@gmail.com>


--GRDaP5Vh04W+8BOG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

The ROHM BU27034 light sensor has two data channels for measuring
different frequencies of light. The result from these channels is
combined into Lux value while the raw channel values are reported via
intensity channels.

Both of the intensity channels have adjustable gain setting which
impacts the scale of the raw channels. Eg, doubling the gain will double
the values read from the raw channels, which halves the scale value. The
integration time can also be set for the sensor. This does also have an
impact to the scale of the intensity channels because increasing the
integration time will also increase the values reported via the raw
channels.

Impact of integration time to the scale and the fact that the scale value
does not start from '1', can make it hard for a human reader to compute the
gain values based on the scale.

Add read-only HARDWAREGAIN to help debugging.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
---
 drivers/iio/light/rohm-bu27034.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/light/rohm-bu27034.c b/drivers/iio/light/rohm-bu27=
034.c
index 51acad2cafbd..b299ff2aacce 100644
--- a/drivers/iio/light/rohm-bu27034.c
+++ b/drivers/iio/light/rohm-bu27034.c
@@ -149,7 +149,8 @@ static const struct iio_itime_sel_mul bu27034_itimes[] =
=3D {
 	.channel =3D BU27034_CHAN_##_name,				\
 	.channel2 =3D IIO_MOD_LIGHT_CLEAR,				\
 	.info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW) |			\
-			      BIT(IIO_CHAN_INFO_SCALE),			\
+			      BIT(IIO_CHAN_INFO_SCALE) |		\
+			      BIT(IIO_CHAN_INFO_HARDWAREGAIN),		\
 	.info_mask_separate_available =3D BIT(IIO_CHAN_INFO_SCALE),	\
 	.info_mask_shared_by_all =3D BIT(IIO_CHAN_INFO_INT_TIME),		\
 	.info_mask_shared_by_all_available =3D				\
@@ -992,6 +993,13 @@ static int bu27034_read_raw(struct iio_dev *idev,
=20
 		return IIO_VAL_INT_PLUS_MICRO;
=20
+	case IIO_CHAN_INFO_HARDWAREGAIN:
+		ret =3D bu27034_get_gain(data, chan->channel, val);
+		if (ret)
+			return ret;
+
+		return IIO_VAL_INT;
+
 	case IIO_CHAN_INFO_SCALE:
 		return bu27034_get_scale(data, chan->channel, val, val2);
=20
@@ -1036,12 +1044,16 @@ static int bu27034_write_raw_get_fmt(struct iio_dev=
 *indio_dev,
 				     struct iio_chan_spec const *chan,
 				     long mask)
 {
+	struct bu27034_data *data =3D iio_priv(indio_dev);
=20
 	switch (mask) {
 	case IIO_CHAN_INFO_SCALE:
 		return IIO_VAL_INT_PLUS_NANO;
 	case IIO_CHAN_INFO_INT_TIME:
 		return IIO_VAL_INT_PLUS_MICRO;
+	case IIO_CHAN_INFO_HARDWAREGAIN:
+		dev_dbg(data->dev,
+			"HARDWAREGAIN is read-only, use scale to set\n");
 	default:
 		return -EINVAL;
 	}
--=20
2.45.1


--=20
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =3D]=20

--GRDaP5Vh04W+8BOG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmZmzwMACgkQeFA3/03a
ocWj8Af+P5P4meb5MBnUNFARLI4A0JAwzjcBM6FCEfefSdxqt0D3PuXemQ++vZDM
TwCeYe3Mg3408uZPPowytK0grlrA/F/MRnYZYmNHqaCGBewdRyKdYYbmjdMaZkRW
2llWSBOYBE7vhF0RRQGw8bLzitN3BBPc0fxGxob5gw7k/bZH9zti6MwIZEYC60+K
XNvtGe0Ufs0WEA2/esbcRv6tg9qDZbFNSt5MVTX7PzYo+6kOLEj+Pnevl5ahSxsY
pB246WrAEpYC+OVJuiEOE8N2inUYhdftJfdp6DxEhRz2RWfM0ggVpP0TJh+U1Coh
c851m5OVVaH0WGOhr8t/obAQ7Zzcrw==
=qQHl
-----END PGP SIGNATURE-----

--GRDaP5Vh04W+8BOG--