Received-SPF: pass (google.com: domain of linux-kernel+bounces-207997-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <0b21129a-3cde-4b0f-a588-9069da4c14c6@redhat.com>
Date: Mon, 10 Jun 2024 12:11:52 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RESEND] drm: panel-orientation-quirks: Add quirk for Aya
 Neo KUN
To: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,
 David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20240310220401.895591-1-tjakobi@math.uni-bielefeld.de>
 <a4069a85-b990-42b4-8cde-8906a740ec27@math.uni-bielefeld.de>
Content-Language: en-US
From: Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <a4069a85-b990-42b4-8cde-8906a740ec27@math.uni-bielefeld.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hi Tobias,

On 5/31/24 9:04 PM, Tobias Jakobi wrote:
> On 3/10/24 23:04, tjakobi@math.uni-bielefeld.de wrote:
> 
>> From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>>
>> Similar to the other Aya Neo devices this one features
>> again a portrait screen, here with a native resolution
>> of 1600x2560.
>>
>> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>> ---
>>   drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> index 3d92f66e550c..5d3fb11fd45f 100644
>> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> @@ -196,6 +196,12 @@ static const struct dmi_system_id orientation_data[] = {
>>             DMI_MATCH(DMI_BOARD_NAME, "NEXT"),
>>           },
>>           .driver_data = (void *)&lcd800x1280_rightside_up,
>> +    }, {    /* AYA NEO KUN */
>> +        .matches = {
>> +          DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
>> +          DMI_MATCH(DMI_BOARD_NAME, "KUN"),
>> +        },
>> +        .driver_data = (void *)&lcd1600x2560_rightside_up,
>>       }, {    /* Chuwi HiBook (CWI514) */
>>           .matches = {
>>               DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
> 
> Trying yet another ping! Also adding Hans to the list of recipients, as he committed the last quirk for an Ayaneo device. Someone pick this up, pretty please! :-)

Thank you for Cc-ing me and thank you for your patch.

This looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

I'll go and merge this into drm-misc-fixes now. Note I've not done a build
for drm-misc-fixes in a while and I'm on a laptop atm, so it will be a while
before this shows up as I'll do a (slow) test-build before pusing out the changes.

Regards,

Hans