Received: by 2002:ab2:784b:0:b0:1fd:adc2:8405 with SMTP id m11csp298103lqp; Mon, 10 Jun 2024 04:46:45 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUTqlTwWco3TTzMqUWuzGG+0MXboDXq28C+ysZGWzaBwYcatKUZU6pcORzPPS2hNst54wBOVZrz6OB/g8yyJyO9aOGDhYAu7rhAESfQQQ== X-Google-Smtp-Source: AGHT+IHI2fSB+GkczqFYsQMnSfmsyIWEXnuXGaZgXSfk6yGABTkOEcrDJLZMH0dgmaHPyLYkiZ3b X-Received: by 2002:a05:6a00:2d06:b0:702:6567:ffd with SMTP id d2e1a72fcca58-7040c733fdemr11436577b3a.24.1718020004552; Mon, 10 Jun 2024 04:46:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718020004; cv=pass; d=google.com; s=arc-20160816; b=PqyMcnTa7PMltiayyGSJ8gD5HVdeXOoHtIdt/Dl5mqS2M+aBOg5LOB6OFRh5TgUj/L vb5voZQRTLpWko30Fp6yogHFcGZlMUTAkaEI0fdeH+d/PT/7oSfP925bIYZ5eCcNeWuJ vWLXxXTLs7vLffBq6slZj6DcM4dTi3SZIPwyNT1VIybTaG6Ke2RcSuFQzYNxAip2fwXq h7tgvFo/BIfiSBiO7yBPax2m0iE3VUO4ghGU1gYf2Do3jusovdOTl3b5JqVAe43MCTrw M8qRx1qSbdLajx0RV9jzQ5odcVza46Ip3AKvKhlEpySqsBUGbPnX/ix+HHHE12hd1uWU noZw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=t1RfAV4PLwvTnmu8HHsceEpEdR+TeZfEUh8Xl6gJd1M=; fh=B0M7t5bdf7LBaD2cdIAj2x1GPYz5jkLHhYxgEgTlKfg=; b=zZOr/3F03wmu5kWW5+gfTukztRNAZ28VTj0IzLg140xfg2Kw+iM9ztQqUQ0HXRyTpy FRYrmWUEl7k1v8rhCnQF7ROwguLTsuXOZ9eK+HHdjMLCqiVYYRslbC9XgcfgGvj+sVXp 2wqBG9WsXUjXFIbPjaqlb67qhoKCNZtd6ENqT1NC9rttQh7XO/RUW/Ux7mWDz5AeKoT2 h9CsLQotgBVLqTw7jXzc2JVTd650eR6cGDTPF9ff3k+z46igJSoA+rJhc2NcPI4v5xse RL2boZyNvHoQz0z+C89zI7FP/BUXA1qLJ7h9orpTRK2Zbm72bGn7WwsFon8UHvmkDzeX Bueg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=d7HDjUR2; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-207893-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207893-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 41be03b00d2f7-6de2ac240dasi7706156a12.866.2024.06.10.04.46.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 04:46:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-207893-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=d7HDjUR2; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-207893-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207893-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9F5DE284657 for ; Mon, 10 Jun 2024 09:01:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DEE617EEF5; Mon, 10 Jun 2024 08:58:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="d7HDjUR2" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9B0E762F8 for ; Mon, 10 Jun 2024 08:58:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718009924; cv=none; b=BfUYdj6+1lKogK7/NKW46Pnr07eeV+56q3XafXCh1oAcgROvi8zGf5tq1EXkr68azsolKkrkb68CR6l1Yyt1KtrJGsJXnjKwFBVM9kfM8vQun9SoQCbKlzNU0t0HZRLEaThSuO25nRdE5o+jXX1aWrrzq1KTvqn9/94K042xh3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718009924; c=relaxed/simple; bh=4msQrWBVL2b4JwUEKLRwKbzNTovn+5JwozhskLlkUwI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=W3J/qQ/YHuUUu9k8EEXb6/lJcahScwgGF64Zk8HNs6i4kVizTuv2aH9oC2gPm9NvbWfe96Gj+hJ5q0FPtBqUVG9/atCawhhldJ/2FKY0M9qzLXXCvAmUGPHimuV/xOcN+qqHyh+em58KdZYD2eqKI+lthbfsbDvLUHH3k5sNH0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=d7HDjUR2; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718009922; x=1749545922; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4msQrWBVL2b4JwUEKLRwKbzNTovn+5JwozhskLlkUwI=; b=d7HDjUR2zssFsZv52TcBLbF8eLWtAHq9MIOH7EiqudbkjQrKNPD1sL8N jNCqj+wE43yx8Y+MaEHNnBjfIPpSb19Dv6tfeSvhxfGl7TC89sIoeJPST lH20AcLcmxhXn84b++D3LdaNcZmyAOKqRfaxyKTFJJIcE0Pt5k7/Ns9G/ +dCyUW+GHovKoGeuCnyyjl2ArO/BsYIKHqDmWa9gHMRuqCbmQCdJrCvbW BQMiRNh2TgCX05VIouNa4/VJhcljXdyPRoCuEb6uGh+PzEFtrkc2fUM7A amA0HgHxNGTJe5QYWFuKb3s0dhH1SiFILwvg0wKm4xESXLK3GBkvALETU A==; X-CSE-ConnectionGUID: GjMlcTj/Q0msAFOozJJCvg== X-CSE-MsgGUID: PYlQ9EMNRCmkv6xeNybmGQ== X-IronPort-AV: E=McAfee;i="6600,9927,11098"; a="17581599" X-IronPort-AV: E=Sophos;i="6.08,227,1712646000"; d="scan'208";a="17581599" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2024 01:58:42 -0700 X-CSE-ConnectionGUID: 3haueZ8xSc2KYY4kPv/lrg== X-CSE-MsgGUID: cSDsjgrOSmyakXpWAx+X+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,227,1712646000"; d="scan'208";a="43432474" Received: from unknown (HELO allen-box.sh.intel.com) ([10.239.159.127]) by fmviesa003.fm.intel.com with ESMTP; 10 Jun 2024 01:58:38 -0700 From: Lu Baolu To: Joerg Roedel , Will Deacon , Robin Murphy , Jason Gunthorpe , Kevin Tian Cc: Yi Liu , David Airlie , Daniel Vetter , Kalle Valo , Bjorn Andersson , Mathieu Poirier , Alex Williamson , mst@redhat.com, Jason Wang , Thierry Reding , Jonathan Hunter , Mikko Perttunen , Jeff Johnson , ath10k@lists.infradead.org, ath11k@lists.infradead.org, iommu@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Lu Baolu , Dmitry Baryshkov Subject: [PATCH v3 05/21] drm/msm: Use iommu_paging_domain_alloc() Date: Mon, 10 Jun 2024 16:55:39 +0800 Message-Id: <20240610085555.88197-6-baolu.lu@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240610085555.88197-1-baolu.lu@linux.intel.com> References: <20240610085555.88197-1-baolu.lu@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The domain allocated in msm_iommu_new() is for the @dev. Replace iommu_domain_alloc() with iommu_paging_domain_alloc() to make it explicit. Signed-off-by: Lu Baolu Acked-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_iommu.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_iommu.c b/drivers/gpu/drm/msm/msm_iommu.c index d5512037c38b..2a94e82316f9 100644 --- a/drivers/gpu/drm/msm/msm_iommu.c +++ b/drivers/gpu/drm/msm/msm_iommu.c @@ -407,10 +407,13 @@ struct msm_mmu *msm_iommu_new(struct device *dev, unsigned long quirks) struct msm_iommu *iommu; int ret; - domain = iommu_domain_alloc(dev->bus); - if (!domain) + if (!device_iommu_mapped(dev)) return NULL; + domain = iommu_paging_domain_alloc(dev); + if (IS_ERR(domain)) + return ERR_CAST(domain); + iommu_set_pgtable_quirks(domain, quirks); iommu = kzalloc(sizeof(*iommu), GFP_KERNEL); -- 2.34.1