Received-SPF: pass (google.com: domain of linux-kernel+bounces-208129-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240610114554.82496-2-wsa+renesas@sang-engineering.com>
In-Reply-To: <20240610114554.82496-2-wsa+renesas@sang-engineering.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Mon, 10 Jun 2024 14:03:25 +0200
Message-ID: <CAMuHMdXOHHsyvZKME75qHk0M9sVf6A8EnA0YwJpbDSHt48tTVw@mail.gmail.com>
Subject: Re: [PATCH] checkpatch: really skip LONG_LINE_* when LONG_LINE is ignored
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org, Andy Whitcroft <apw@canonical.com>, 
	Joe Perches <joe@perches.com>, Dwaipayan Ray <dwaipayanray1@gmail.com>, 
	Lukas Bulwahn <lukas.bulwahn@gmail.com>, Andrew Morton <akpm@linux-foundation.org>, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Wolfram,

On Mon, Jun 10, 2024 at 1:46=E2=80=AFPM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> For this to happen, all types must be set to "show". So, AND is needed
> for the flags, not OR.
>
> Fixes: 47e0c88b37a5 ("checkpatch: categorize some long line length checks=
")
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks for your patch!

> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3858,7 +3858,7 @@ sub process {
>                         }
>
>                         if ($msg_type ne "" &&
> -                           (show_type("LONG_LINE") || show_type($msg_typ=
e))) {
> +                           (show_type("LONG_LINE") && show_type($msg_typ=
e))) {

I don't know if the change in logic is correct, but if it is, you
probably want to remove one set of parentheses:
A && (B && C) =3D> A && B && C

>                                 my $msg_level =3D \&WARN;
>                                 $msg_level =3D \&CHK if ($file);
>                                 &{$msg_level}($msg_type,

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
.org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds