Received: by 2002:ab2:784b:0:b0:1fd:adc2:8405 with SMTP id m11csp312428lqp; Mon, 10 Jun 2024 05:13:11 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXZ7aea4e63EQjolU5XMPLuRXg9BWs/hL7akhPPS/0URx1PhFTO8g1OLAZB+RTBqN9HRRDpZYhjGUciky6d2vsM55XcoMlrRUYCelWFwA== X-Google-Smtp-Source: AGHT+IGPQ3nFe6AObehM1boP15++s7wFmMNFMvdnxTdIPhui1B1QbgTFlfUAz6oQ2sW0KgGopDGN X-Received: by 2002:a05:6358:9106:b0:19f:466b:3897 with SMTP id e5c5f4694b2df-19f466b3ddcmr623937655d.5.1718021591313; Mon, 10 Jun 2024 05:13:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718021591; cv=pass; d=google.com; s=arc-20160816; b=RWzxFkteyAvubXjibpgy2ZbuUdUDp/PhlNOHgdyYOd5Oya/X+mm2JjafzCDY7R4mSL 6qXpXfTPe6suPaAaDa6JxdTbq0zzt5aEGSNNybg6BZ+5k7IZ5EDtCi/oPhrFGQcvxPI/ DD+YeCGbf/2jOwXZy4p991W6z5DR7lKuLqijchF5NwlHc8M6yWxZNNHZcK17qj5YsHfW gSamV01gYWH84mpkEmRKxZMymdz16cUSGGodwTL1c48UEDaFr6XKmVQWB6jFxc4TDwqF AaLSnLc3EKh0q4jO57uFTNSxGOFQe2iqyayJ7jQwyPX0SnNTMHLgD50EW2RXeNLgRbAv bb6w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=wAXE+j35rInNLcSW0kzVtiyaeEo+8p0XntE6xZUSEi4=; fh=Lh+JMPZo65h8qJAnE5jHWvKtvWM25xS7kSTjy8t+qRE=; b=TyNnwzh/gwi0mq/+WrqIB9+o4HHvcVLSmbvF8A+G1IkWTvZfYOXnKzyLlwEJAmBkwG 9SVp06ILLPnBgi6CQEEyoVMSf9WEyRxH9QaTpYeFW614187ma2GS1QEfAfKu/o4QNWyO uGOdjhgGPS5VFryMiOCZPy7OjkL5hgjk6xc3Ynty+3j2MF6eFSRMeRcLCkohnGL/7pQM QjASVPbH0lOwGHCjS/NMKFc8YUaVmhm7jMDUrN4RIWEGvKhCM93miwEyn+KRC1DdWuJI AHJaGMhnUTi1qgjomlrIr2r5JmLh4rLfU0wSh/8blaOFvoomQAsk/KD6/+WHLPPCttBv +WhA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-208106-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-208106-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 41be03b00d2f7-6e9645dcd9fsi3413223a12.145.2024.06.10.05.13.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 05:13:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-208106-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-208106-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-208106-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id F0482B23664 for ; Mon, 10 Jun 2024 11:55:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 63BB38172D; Mon, 10 Jun 2024 11:54:54 +0000 (UTC) Received: from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50CFA80C1D; Mon, 10 Jun 2024 11:54:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.37.255.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718020493; cv=none; b=SoYfaLEtMT86XQrT/r+iT5bBFcE6J97lgjMYbWGmfB1dwGibZRIEt9+e+2a7Ad+0tNVHxZpNCjOTlhPtKKo/7YHu9ntGDefyQ7oIAVoODJLPGL4b1WjbjSugrOh0rhjLiFvDoBFAc9Sq4VRZha37x+BywjfjDwxiVULD5iBfYsk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718020493; c=relaxed/simple; bh=6nVh/RFHPpP/ApwFY6kktPoPTdT7kWzFRFeS0hlqlNM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=psTUObMJ4ILCDgQmP+eki8qHT4Ax6Rm+05Dowau22X0tIVJRyP4qwQd7lvfSlApTXKVHQE2o8QBEBAeIhtsNH5762ey89tIrYszzqylnRlzuRmR8vf7EA3kemaWFYt9aYei5w4JHMXjssgwqykRO+NxyJYBLYUnr0nsUdReQ8eA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; arc=none smtp.client-ip=194.37.255.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1sGdbt-00BAYJ-C3; Mon, 10 Jun 2024 13:54:49 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sGdbs-005Yao-RL; Mon, 10 Jun 2024 13:54:48 +0200 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 8D386240053; Mon, 10 Jun 2024 13:54:48 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 2314D240050; Mon, 10 Jun 2024 13:54:48 +0200 (CEST) Received: from mschiller1.dev.tdt.de (unknown [10.2.3.20]) by mail.dev.tdt.de (Postfix) with ESMTPSA id BA73A26128; Mon, 10 Jun 2024 13:54:47 +0200 (CEST) From: Martin Schiller To: martin.blumenstingl@googlemail.com, hauke@hauke-m.de, andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ms@dev.tdt.de Subject: [PATCH net-next v2 03/12] net: dsa: lantiq_gswip: add terminating \n where missing Date: Mon, 10 Jun 2024 13:53:51 +0200 Message-ID: <20240610115400.2759500-4-ms@dev.tdt.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240610115400.2759500-1-ms@dev.tdt.de> References: <20240610115400.2759500-1-ms@dev.tdt.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-purgate: clean X-purgate-ID: 151534::1718020489-7345A34D-AEC2B5FE/0/0 X-purgate-type: clean Some dev_err are missing the terminating \n. Let's add that. Suggested-by: Vladimir Oltean Signed-off-by: Martin Schiller --- drivers/net/dsa/lantiq_gswip.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswi= p.c index b9c7076ce32f..fe64baf0d7f1 100644 --- a/drivers/net/dsa/lantiq_gswip.c +++ b/drivers/net/dsa/lantiq_gswip.c @@ -836,7 +836,7 @@ static int gswip_setup(struct dsa_switch *ds) =20 err =3D gswip_pce_load_microcode(priv); if (err) { - dev_err(priv->dev, "writing PCE microcode failed, %i", err); + dev_err(priv->dev, "writing PCE microcode failed, %i\n", err); return err; } =20 @@ -1792,7 +1792,7 @@ static u32 gswip_bcm_ram_entry_read(struct gswip_pr= iv *priv, u32 table, err =3D gswip_switch_r_timeout(priv, GSWIP_BM_RAM_CTRL, GSWIP_BM_RAM_CTRL_BAS); if (err) { - dev_err(priv->dev, "timeout while reading table: %u, index: %u", + dev_err(priv->dev, "timeout while reading table: %u, index: %u\n", table, index); return 0; } @@ -2021,7 +2021,7 @@ static void gswip_gphy_fw_remove(struct gswip_priv = *priv, =20 ret =3D regmap_write(priv->rcu_regmap, gphy_fw->fw_addr_offset, 0); if (ret) - dev_err(priv->dev, "can not reset GPHY FW pointer"); + dev_err(priv->dev, "can not reset GPHY FW pointer\n"); =20 clk_disable_unprepare(gphy_fw->clk_gate); =20 @@ -2050,7 +2050,7 @@ static int gswip_gphy_fw_list(struct gswip_priv *pr= iv, priv->gphy_fw_name_cfg =3D &xrx200a2x_gphy_data; break; default: - dev_err(dev, "unknown GSWIP version: 0x%x", version); + dev_err(dev, "unknown GSWIP version: 0x%x\n", version); return -ENOENT; } } @@ -2060,7 +2060,7 @@ static int gswip_gphy_fw_list(struct gswip_priv *pr= iv, priv->gphy_fw_name_cfg =3D match->data; =20 if (!priv->gphy_fw_name_cfg) { - dev_err(dev, "GPHY compatible type not supported"); + dev_err(dev, "GPHY compatible type not supported\n"); return -ENOENT; } =20 @@ -2163,7 +2163,7 @@ static int gswip_probe(struct platform_device *pdev= ) return -EINVAL; break; default: - dev_err(dev, "unknown GSWIP version: 0x%x", version); + dev_err(dev, "unknown GSWIP version: 0x%x\n", version); return -ENOENT; } =20 @@ -2191,7 +2191,7 @@ static int gswip_probe(struct platform_device *pdev= ) goto gphy_fw_remove; } if (!dsa_is_cpu_port(priv->ds, priv->hw_info->cpu_port)) { - dev_err(dev, "wrong CPU port defined, HW only supports port: %i", + dev_err(dev, "wrong CPU port defined, HW only supports port: %i\n", priv->hw_info->cpu_port); err =3D -EINVAL; goto disable_switch; --=20 2.39.2