Received: by 2002:ab2:784b:0:b0:1fd:adc2:8405 with SMTP id m11csp319344lqp; Mon, 10 Jun 2024 05:24:49 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWEnB5TWyXD5v3kBNBLgy2JUaa4S2vgTcGi/tBA3k248b2m6hv898UfR3tMKzUnshpbOmNiIgvF3jS7NPYNmKBEdEvp0xqh34mROexGEA== X-Google-Smtp-Source: AGHT+IHGJYoM4Gj6K3LJGM65xpwUQAvGDD6jCrUFQ7D8htz1B3F5T2twsXOBpQmC1fRD9xmtaDZO X-Received: by 2002:a05:6a00:4649:b0:6f6:7a1a:5b8c with SMTP id d2e1a72fcca58-7040c67d9a8mr8587412b3a.18.1718022288768; Mon, 10 Jun 2024 05:24:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718022288; cv=pass; d=google.com; s=arc-20160816; b=UbsUki1uy3iKzp9bly4SamzuLRyWEA9cHICi4g/3Uel1uCdwrf0CMXASRG3M+3xBuE 1/JTygZOkZXTYfrZMO7JHO6MchU6ttSgJ/VEMrCj6khzYRcWoQIkWJNMOoYWf2Aid7Us uPQbncD1haNK24toMsM269XOMjK3RTBD7Y+ZOd67rhafKIamQAny6edvWCoZi3/wApRY mrrHUsznOkaMbSP32hXdOXNtoZK6WoOLSW/tMjK6R/XeDAL6Dvia0xLatM/vKz41rFEt cJb4FIx5aGA/QV30jSzpLLxXzeIPKRlZXlkw0+H8jAgZN59lURlSEVYxi9O5SPavkNWB MUFA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=ANdnNKEXEKMU7+nCdQRC8BKJq392jdqzaIpfScTXSn4=; fh=oMfgzkEw/ooUXqvARCgNaSZrpwGw5y27+DEhhPidNdU=; b=jJYc7RwIIMtpOIlUl/OIdv8tAC7b3fXrtiicTc/dTbXhBBvZDpGGlwG64yH1Ua0EG3 SEIY0HaxBODTmvzTQQRQMGB+SX4fomZXSlrsOIi7EP9NAX4vC4JJmSb1ytIAw+tFQyba Hs/O+1DYDK0fw/H9VC/xVUTeephDtDDPmMTXvRUA1m/8+QGbk/wEqONeX7wP2pCpddug IUrlPm9ORrGlwNMS0+520pp1G02w8BmGUynuC3/Jjjv0F82sIgGBoiEETy+s6C4k0fVr tmUgF24+fcJFMUatxA/U10yA12loScO0CNCSPHmDOB2+CjFT7Jwrr/xZ7g8XlJmxmtZ4 7bHg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cP3vc7YY; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-207888-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207888-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 41be03b00d2f7-6e8a01e3055si3453374a12.756.2024.06.10.05.24.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 05:24:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-207888-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cP3vc7YY; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-207888-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-207888-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 657BCB2142A for ; Mon, 10 Jun 2024 09:00:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3C7FE74057; Mon, 10 Jun 2024 08:58:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cP3vc7YY" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1E9674043 for ; Mon, 10 Jun 2024 08:58:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718009899; cv=none; b=WxQXmtCn4aFLuPJyhDwJoFl6uhWs+N/N8oBpueL7O+hG+wHjWJwuAHpLTMypAQxxLJVpfXBlCKPzCX4DPuyhBl+ysuAbN1Dw3cgJQwqwGpgaO1q8ovgdsb7bhfTOzXcyrTXhIaguf1Jsmj/S+RzgpMA3Og8ctiWTBm6Ka62rWlQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718009899; c=relaxed/simple; bh=0vujK8zNCKvKagqP+H4Q/hFUwMNe4QRoYI5wcH4k1DU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=OeKdJDCHKYx4sJqslENRqovmTxkpvvWWabtKey+GPVjoilSUHvGH4/7yS4brVR2aTOW7Mnz7yUMOR/wUc9XuaYkqglboSwqcE2RcT1xaGvunlRa4LOptJUZJKaMbKILmqcPxC4L/8/Xfdn9s363bX0Bfjdh6lViY1tpkhnEsst8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=cP3vc7YY; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718009897; x=1749545897; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=0vujK8zNCKvKagqP+H4Q/hFUwMNe4QRoYI5wcH4k1DU=; b=cP3vc7YYeR7c4mMzApc6KumDA0O+3ffsf/vze5Fp9yFovbzMelFziqbe QABgx3L6KoU/zRK1BcxQ2bE0f/MaO+oYWInAwAMbpDT5VBvuPob47BLBL 02AT3GMB1B5O5pIJdyERc8kRjSnGhu/F2lMhCj5eVdAnoxhjddjfhe4Ye MjCEvj/CS6BxXero+mFQMmQqvU5D7SIoKAUgNsYrtPcx48YRI84LnsZZc wWmWt8NXQgcAsPt3XeYVHgojDxQ3Y9rNfhw49w8cBjJAqBzp6Dyj1yGVV datSiCfslXIGp2BAs6g6elhSUcACvI3Z3rSnw9GBcOSWxA9ZPWDRvg5A7 g==; X-CSE-ConnectionGUID: fsfebzGDTIGJABTwKC+y3A== X-CSE-MsgGUID: w1JZCXjnTsms8JYqKhBq8A== X-IronPort-AV: E=McAfee;i="6600,9927,11098"; a="17581490" X-IronPort-AV: E=Sophos;i="6.08,227,1712646000"; d="scan'208";a="17581490" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2024 01:58:17 -0700 X-CSE-ConnectionGUID: DFrvvBhUT0CHyUEqQL0Vhg== X-CSE-MsgGUID: ar5nZaOiT0efo7DDRkQyLQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,227,1712646000"; d="scan'208";a="43432400" Received: from unknown (HELO allen-box.sh.intel.com) ([10.239.159.127]) by fmviesa003.fm.intel.com with ESMTP; 10 Jun 2024 01:58:12 -0700 From: Lu Baolu To: Joerg Roedel , Will Deacon , Robin Murphy , Jason Gunthorpe , Kevin Tian Cc: Yi Liu , David Airlie , Daniel Vetter , Kalle Valo , Bjorn Andersson , Mathieu Poirier , Alex Williamson , mst@redhat.com, Jason Wang , Thierry Reding , Jonathan Hunter , Mikko Perttunen , Jeff Johnson , ath10k@lists.infradead.org, ath11k@lists.infradead.org, iommu@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Lu Baolu Subject: [PATCH v3 00/21] iommu: Refactoring domain allocation interface Date: Mon, 10 Jun 2024 16:55:34 +0800 Message-Id: <20240610085555.88197-1-baolu.lu@linux.intel.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The IOMMU subsystem has undergone some changes, including the removal of iommu_ops from the bus structure. Consequently, the existing domain allocation interface, which relies on a bus type argument, is no longer relevant: struct iommu_domain *iommu_domain_alloc(struct bus_type *bus) This series is designed to refactor the use of this interface. It proposes a new interface iommu_paging_domain_alloc() to replace iommu_domain_alloc(). This interface is for allocating iommu paging domains for kernel drivers. It takes a device pointer as a parameter, which better reflects the current design of the IOMMU subsystem. The majority of device drivers currently using iommu_domain_alloc() do so to allocate a domain for a specific device and then attach that domain to the device. These cases can be straightforwardly migrated to the new interface. The drm/tegra driver is a bit different in that the device pointer passed to the helper, which allocates the iommu domain, is not the one that will be used for the kernel DMA API. Move the existing logic in iommu_domain_alloc() into the driver to ensure it works as intended. Now that all consumers of iommu_domain_alloc() have switched to the new interface, we can finally remove iommu_domain_alloc(). This removal paves the way for the IOMMU subsystem to support multiple iommu drivers. Additionally, the individual iommu driver implementation for domain allocation could also be simplified, as there will always be a valid device pointer passed along the path. The whole series is also available on GitHub: https://github.com/LuBaolu/intel-iommu/commits/iommu-domain-allocation-refactor-v3 Change log: v3: - Remove the proposed iommu_user_domain_alloc() interface. v2: https://lore.kernel.org/linux-iommu/20240604015134.164206-1-baolu.lu@linux.intel.com/ - Drop the vt-d patches which implement paging domain support from this series. I will post them in a separate series later. - Convert all drivers that call iommu_domain_alloc() to use the new interface and remove iommu_domain_alloc() from the tree. - For the drm/msm driver, make the code compatible with the no-IOMMU case. - Various cleanups and refinements. v1: https://lore.kernel.org/linux-iommu/20240529053250.91284-1-baolu.lu@linux.intel.com/ Lu Baolu (20): iommu: Add iommu_paging_domain_alloc() interface iommufd: Use iommu_paging_domain_alloc() vfio/type1: Use iommu_paging_domain_alloc() vhost-vdpa: Use iommu_paging_domain_alloc() drm/msm: Use iommu_paging_domain_alloc() drm/nouveau/tegra: Use iommu_paging_domain_alloc() gpu: host1x: Use iommu_paging_domain_alloc() media: nvidia: tegra: Use iommu_paging_domain_alloc() media: venus: firmware: Use iommu_paging_domain_alloc() wifi: ath10k: Use iommu_paging_domain_alloc() wifi: ath11k: Use iommu_paging_domain_alloc() remoteproc: Use iommu_paging_domain_alloc() soc/fsl/qbman: Use iommu_paging_domain_alloc() RDMA/usnic: Use iommu_paging_domain_alloc() iommu/vt-d: Add helper to allocate paging domain ARM: dma-mapping: Use iommu_paging_domain_alloc() drm/rockchip: Use iommu_paging_domain_alloc() drm/tegra: Remove call to iommu_domain_alloc() iommu: Remove iommu_present() iommu: Remove iommu_domain_alloc() Robin Murphy (1): ARM: dma-mapping: Pass device to arm_iommu_create_mapping() include/linux/iommu.h | 12 +-- arch/arm/include/asm/dma-iommu.h | 2 +- arch/arm/mm/dma-mapping.c | 12 +-- drivers/gpu/drm/exynos/exynos_drm_dma.c | 2 +- drivers/gpu/drm/msm/msm_iommu.c | 7 +- .../drm/nouveau/nvkm/engine/device/tegra.c | 4 +- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 10 ++- drivers/gpu/drm/tegra/drm.c | 34 ++++++-- drivers/gpu/host1x/dev.c | 7 +- drivers/infiniband/hw/usnic/usnic_uiom.c | 6 +- drivers/iommu/intel/iommu.c | 87 +++++++++++++++++-- drivers/iommu/iommu.c | 63 +++----------- drivers/iommu/iommufd/hw_pagetable.c | 7 +- drivers/iommu/ipmmu-vmsa.c | 3 +- drivers/iommu/mtk_iommu_v1.c | 3 +- .../media/platform/nvidia/tegra-vde/iommu.c | 7 +- drivers/media/platform/qcom/venus/firmware.c | 6 +- drivers/media/platform/ti/omap3isp/isp.c | 2 +- drivers/net/wireless/ath/ath10k/snoc.c | 6 +- drivers/net/wireless/ath/ath11k/ahb.c | 6 +- drivers/remoteproc/remoteproc_core.c | 6 +- drivers/soc/fsl/qbman/qman_portal.c | 5 +- drivers/vfio/vfio_iommu_type1.c | 7 +- drivers/vhost/vdpa.c | 14 ++- 24 files changed, 183 insertions(+), 135 deletions(-) -- 2.34.1