Received-SPF: pass (google.com: domain of linux-kernel+bounces-208154-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 10 Jun 2024 14:23:54 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Aryan Srivastava <aryan.srivastava@alliedtelesis.co.nz>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v0] net: dsa: mv88e6xxx: Add FID map cache
Message-ID: <e850b74d-fac6-4680-b9d0-fc2c3e1aa848@lunn.ch>
References: <20240610050724.2439780-1-aryan.srivastava@alliedtelesis.co.nz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240610050724.2439780-1-aryan.srivastava@alliedtelesis.co.nz>

On Mon, Jun 10, 2024 at 05:07:23PM +1200, Aryan Srivastava wrote:
> Add a cached FID bitmap. This mitigates the need to
> walk all VTU entries to find the next free FID.
> 
> Walk VTU once, then store read FID map into bitmap. Use
> and manipulate this bitmap from now on, instead of re-reading
> HW for the FID map.
> 
> The repeatedly VTU walks are costly can result in taking ~40 mins
> if ~4000 vlans are added. Caching the FID map reduces this time
> to <2 mins.

How long does the first walk take? Rather than having fid_populated, i
wounder if the walk should just be done in mv88e6xxx_vtu_setup() or
mv88e6xxx_atu_setup().

	Andrew