Received-SPF: pass (google.com: domain of linux-kernel+bounces-208246-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 10 Jun 2024 09:41:19 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: Peter Oberparleiter <oberpar@linux.ibm.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        allison.henderson@oracle.com
Subject: Re: [PATCH] gcov: add support for GCC 14
Message-ID: <ZmcCfzJfsKoVvDpA@tissot.1015granger.net>
References: <20240610092743.1609845-1-oberpar@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240610092743.1609845-1-oberpar@linux.ibm.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?Z0pMvo4TrfJKsAftPGNOhkB8pJSYBkYeiLEQ7/EaS6bsYem6rUEiLKFy7bCq?=
 =?us-ascii?Q?b4Vc+97UQhF5C20nGB2G/AWkSSA5WewTbwJKajlwo7D1qWzrRnIBVOhqoTPx?=
 =?us-ascii?Q?KWvCQoLqr9bc/IPTRyrhhpjKRZaDn4lcEd1oaCLgQPjXRR3fl3SjFfIbG5L6?=
 =?us-ascii?Q?aA/GRSqHczLPZeOKHAymDG766vEmvhqxVxd6wYuwIOPbB0c04cS9mqXga8K4?=
 =?us-ascii?Q?+HmlNAKRvPGjBkIj+faROUHezzahRKeE6QZhoRroMNj3VemE4sFdlm4nPKzr?=
 =?us-ascii?Q?7yT5mPnorutp2NFSHk78CMcEXi9dEosyO3Snq4N8CwOU+a4e+sKjgcvDNaUb?=
 =?us-ascii?Q?ji2S9hu0X6aAr6dA4PNZmj2VnfWLeDadILijCwGimnMzfAHJLLV35rK8Qi68?=
 =?us-ascii?Q?9bk9F2jrj9UNdHkyUY5AbXwXfhShYrBse8rLzv7DqNsDcZBolXAN+o2U8Su7?=
 =?us-ascii?Q?toQf/mY5eEmpXOJuGTX1bGRylF8rt/oSjjsQWQgAmTTX5qfGbYBIZNvl7vLv?=
 =?us-ascii?Q?TD9W9GAvxBv6LJ/ZHZYhrz6/F519mhb/2LVI//I9PteOCLMhULDZ71LeJ1Wq?=
 =?us-ascii?Q?ubOXwFaqItfN2W9q7jE+sO+IkSyBKmaIfpL+LNBorucNVy/lc4/6+L5duXGo?=
 =?us-ascii?Q?nc/RFGp79IgT9XcM8+TePv/WfxcgxUHxynH+yw6akk0Wye1l/EDZRB8b94AM?=
 =?us-ascii?Q?WsjzEiWR1W/L6HhC5ylJajHxzU7mlBlkLRthzTQRJtDf+KfyBjp+AHK5jZ+j?=
 =?us-ascii?Q?srjz1D1JtD6O2MhyJlzoOOZCwDQkZra3+uUzAUmgwMP3bU3XYvSLze1gz/Ph?=
 =?us-ascii?Q?++oZCjk7d6FYuZe81jFWXAg2dSgDSG+vNDal0jnc31CnLA4zCop2tXf5vlRl?=
 =?us-ascii?Q?JYOmgZehZJLVGorHDVZonXemWzqgT2X4gFJpnJecWy80gvbe7+HeAISv023Y?=
 =?us-ascii?Q?Wv3jW67MOplLz3NQrtiDoFcuoF8nN8UDQwaTEGjR3fVdAurfJA3Suw/129lF?=
 =?us-ascii?Q?WDbiE+LBruzQkkZ9uEkVri98E12jNDQw4UVwcMDwEbXb9MgL9pG1N1CJ4ObS?=
 =?us-ascii?Q?dQhJ/A4+4R6twZFbrhexahXUEt6dO01IHeJwBGLEmlxXdAI+FhWJph+JpYXo?=
 =?us-ascii?Q?cwm5L0ghNVqtbYyc6BlrMyiiXcataqQtMxEOiiuSGPgRqNrme4pLADJGZ2ld?=
 =?us-ascii?Q?Ee8WUqPcl3j+GC4VeTFDH57BQCdBXruyNT/bWQ5wyXVeIpow2y14jTRRoSKr?=
 =?us-ascii?Q?gLYBdScYmbHdkslaCADPBkqz+vktpk8ncSn8qkHk2SHWFGuHeJHnZ13lhOpm?=
 =?us-ascii?Q?W1pskyA7J0lAa9U853s5zdLFwKmp9DMOayst/D9/3ovql6taXKAfyyRCQLJS?=
 =?us-ascii?Q?nlfe66mLMU6iVxEjlHaLu0rikaVOehIQKYkiYC5KLLbOcVXO1n6yqC3CDqU+?=
 =?us-ascii?Q?AOzNlNIW7X3W7QR1EgECIDo4Lq2vWauRIYP5Iz0/kG52TYfZ1jcZlAUX8huT?=
 =?us-ascii?Q?DsEuOFdro2wP5F1c1XtlFS+KBzhBp8hhqCDxaHD84aUAjF1GIvfSVy8ABO5Y?=
 =?us-ascii?Q?S8v27movVm8EpXtgyJ9pMrcHACEyGXdFC3lta1at1KSQJwhaoHw6aQn13vGf?=
 =?us-ascii?Q?UQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	s75FEla8gwzpRTB/SLXkfymwwUz6c1woEe4QMcxmek+FG0/pznuhZq1M+0ForJci8Uu9ajhzrQhW+x20G6snQg8z2cDWyccDkLSz+fh2jc0S7PJFMOL1c1XEmFPC72FWTORMjGcf5gb7XTW5gxlXbKXg0E4ulo5deYZYGh2jX+czMGuSwfGk3tn8pXgdoaZh9QZnOIxeHjMiY4viFcHp0cSDTKYiPlEdyk0e3Q2onxkkcEdD6tmbfb5P0+Nq9eCS3n7eHVKCcM9loeiqZUL6s03WwiPGVu8CTvoi1fAWWz6ItX5SIrYMkyLx85+HuigIktP+4P6pMyWfvqhtt15MB/I72bvgvgskKfUVffkmzwMiFpNoLJuA6KFoCKqefBBL6SF+eXPTRIKORX5BRBnvHgfl/hTfSVTln9eCY32S520QhC5IfNVLHPYlXHPYskZEUahgnL3EXPjJvXRuqOvaQ8vQH6k8IWkWVLj6zDd9XyA1f96YdhdU71lWAD0rloMqsLgmHK+Bgioq+j0dA+SFDfqkKYiN/QID9m/3UDz7zJDI+b/0gsbB5Ppc51Z96OhmHqkEc4kfCE2V4YfKnhyyIKce3264zBmXC5kn/JJnP7E=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d3b3388f-989f-4a42-d5b6-08dc895303d2
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2024 13:41:22.0086
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CQoIkqQWfK0oLXl91G9yk8WxGgb1Pfb5xk5Q3EQIbuhEpN2A9lTSI/mAQb5e2Bt8NlSdIrxsoVimklYoafKlWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5803
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-10_02,2024-06-10_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 adultscore=0
 mlxscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406100103
X-Proofpoint-GUID: 6-jOvDPKsFY7uL4wP3DoGvsTDwGz4grI
X-Proofpoint-ORIG-GUID: 6-jOvDPKsFY7uL4wP3DoGvsTDwGz4grI

On Mon, Jun 10, 2024 at 11:27:43AM +0200, Peter Oberparleiter wrote:
> Using gcov on kernels compiled with GCC 14 results in truncated 16-byte
> long .gcda files with no usable data. To fix this, update GCOV_COUNTERS
> to match the value defined by GCC 14.
> 
> Tested with GCC versions 14.1.0 and 13.2.0.
> 
> Reported-by: Allison Henderson <allison.henderson@oracle.com>
> Reported-by: Chuck Lever III <chuck.lever@oracle.com>
> Signed-off-by: Peter Oberparleiter <oberpar@linux.ibm.com>
> ---
>  kernel/gcov/gcc_4_7.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
> index 74a4ef1da9ad..fd75b4a484d7 100644
> --- a/kernel/gcov/gcc_4_7.c
> +++ b/kernel/gcov/gcc_4_7.c
> @@ -18,7 +18,9 @@
>  #include <linux/mm.h>
>  #include "gcov.h"
>  
> -#if (__GNUC__ >= 10)
> +#if (__GNUC__ >= 14)
> +#define GCOV_COUNTERS			9
> +#elif (__GNUC__ >= 10)
>  #define GCOV_COUNTERS			8
>  #elif (__GNUC__ >= 7)
>  #define GCOV_COUNTERS			9
> -- 
> 2.40.1
> 

With "gcc (GCC) 14.1.1 20240522 (Red Hat 14.1.1-4)" on Fedora 40:

lines: 58.2% (2350 out of 4036)
functions: 72.2% (197 out of 273)
branches: 35.5% (1037 out of 2923)
calls: 0.0% (0 out of 0)

All were 0% previously.

Tested-by: Chuck Lever <chuck.lever@oracle.com>


-- 
Chuck Lever