Received-SPF: pass (google.com: domain of linux-kernel+bounces-208308-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 10 Jun 2024 08:58:22 -0500
From: Ira Weiny <ira.weiny@intel.com>
To: Jeff Johnson <quic_jjohnson@quicinc.com>, Vishal Verma
	<vishal.l.verma@intel.com>, Dan Williams <dan.j.williams@intel.com>, "Dave
 Jiang" <dave.jiang@intel.com>, Ira Weiny <ira.weiny@intel.com>, Pankaj Gupta
	<pankaj.gupta.linux@gmail.com>, Oliver O'Halloran <oohall@gmail.com>
CC: <nvdimm@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
	<virtualization@lists.linux.dev>, <kernel-janitors@vger.kernel.org>, "Jeff
 Johnson" <quic_jjohnson@quicinc.com>
Subject: Re: [PATCH RESEND] nvdimm: add missing MODULE_DESCRIPTION() macros
Message-ID: <6667067e7e152_1700b5294ed@iweiny-mobl.notmuch>
References: <20240526-md-drivers-nvdimm-v1-1-9e583677e80f@quicinc.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240526-md-drivers-nvdimm-v1-1-9e583677e80f@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YqrKJHkqwBtDPWD6XQCiCJ/LLgFRMLwF99sR3a7NftZCYh6etLBMz+8PaxM4?=
 =?us-ascii?Q?NWsMFyLP2VTSleotDMZ9TSy0Y4o80vaJa+8eXXx8+1mIrA23qH0qM4dJ65Sq?=
 =?us-ascii?Q?rjq680VE+MFu1CPQS89g2+Bjp+CemZeBFdw1PtKIEih7pLaO4JdKhPGUmdtw?=
 =?us-ascii?Q?OW/xlFlE/CukRiXvdraZJqWQhNTT7zZrTGuIBBoYCiuV62sUWwHsHDLR++rl?=
 =?us-ascii?Q?8UK69I2wOXhwCYZ6Zp6lVnl2PdNJXtC5JDbwWqdwlAdxVA3l8+Te/FoYkUUz?=
 =?us-ascii?Q?bqP6/peO1of5ya6YPq9b5XLfhA+JPobHmbmcevUOsMCQgZVLDW5ZdFHqGRKQ?=
 =?us-ascii?Q?yW1tBNYkFbajJ7mvyoXGL/fIyMRVCtbYH/3YSnGlE8lgHllUfKNU1syYbmXw?=
 =?us-ascii?Q?hS/6YKdukX3/+cyIEU/Fq5vpPRQV4SrpH+46FtKGT2y+dWoruuGULzhTRF94?=
 =?us-ascii?Q?UfMSMH9HgZbWGol1ElKdq91+gbKURkbuBs9Yp7d9EbgIYKdyxQjT3vmF+89E?=
 =?us-ascii?Q?PDjcC3ceKuNHF3rffDqgXNuRoC5+RraxC5fkxEeiDu0XtHngXH6HjxEQIYXh?=
 =?us-ascii?Q?AJVOV46N8QZxNK8AikDTJRxh/XtTBcgN2JsDJIwUtcEFNstJj7LF48vtbEjA?=
 =?us-ascii?Q?GaKAYuRfMGjhOuyTUn+9qDvUC+sBL2U22G+9sE1JAQWHXeCclHkFp+9LeKXF?=
 =?us-ascii?Q?ngDd8cjiHPGx/s5uBUmRLZx6bip3thmQ20kHFnR145qIoNfZByj1gi+a1dDK?=
 =?us-ascii?Q?3zHAno+aN88f/11L9eExP9D6lCccH1IKXxys3Sv7do9VPcLvblpQllvKnD7Y?=
 =?us-ascii?Q?6/ex0Ka7FIwxIM/xJ8KV3ZyFZMGzhsATwR0UXuQAT4ls1BZV/fBjDF/KWJvT?=
 =?us-ascii?Q?r1jzbX41jQAS5VNcSq7bT+P6brPmTypnxE2SC4tZjWRHbxPcVOw0RGZc2B5d?=
 =?us-ascii?Q?5XP14PsmOiT6x8YIpMj9+Tl0CeNm4GlGBH3Ovqur7yB1fv6aliV+jqLxOHl5?=
 =?us-ascii?Q?fQStx8UEnko7+yIxqWSWsh6qAzilYctvMS4KC5Z83YogUq+dBo2sDwRZXy7E?=
 =?us-ascii?Q?dGipujlzIaZV4JG1H2gjQdJcwrXFI0whp718CuriC1/hmy8N/Cc8vsEjSzcY?=
 =?us-ascii?Q?T0JePqDhgSNgg4aSMqrie5mfCJT0GGsOuhlBjPQqaX7lzD8vsqtjCXbRc1DY?=
 =?us-ascii?Q?zmmt7/1sH4kafzEUHC79awmRpMIJueM99Dn0VfvAma/IpqTF13XOpwkvxuXc?=
 =?us-ascii?Q?3lWx+zg6UasRsc09QRCLWDbd7hKEY1CA5NrNCIDYIknu5R6s8IcMDkutFOFT?=
 =?us-ascii?Q?v31REHB/mRx2xT1inAsBu0xsaR1h61Fkr69lR06f02gMQ185igPdOpsel970?=
 =?us-ascii?Q?MWPPBOHhZq4tfjjR6HARckEoGmwYCtwQ9KV26b6RqCvIfyJNjpAFI4UuqWqs?=
 =?us-ascii?Q?ETLOmEajjPKWmBPgV/QmssxV0dYtK+VEWpA9c5R+0y6JagUvdPfI+kZnBLxo?=
 =?us-ascii?Q?9JsAWvPwpf/R7sRdNMk894iqBTltUdx/IDpZXo+AUwUP8SKzGNBOj94HlHLc?=
 =?us-ascii?Q?QokmJUYrZEeRPMAPm9LT//uma+W8Xs7CSEJG/4AP?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e3680fdd-4b62-49e4-b046-08dc8955678d
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2024 13:58:28.5414
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LMYBGgJcXAWosHLe0fDUUxi2jy2Kn1bwG4vN8U+tXfzivzOlC64zFdfNoo8hPEw1vuHXG3VjXhD1D8Thzo9TkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4793
X-OriginatorOrg: intel.com

Jeff Johnson wrote:
> Fix the 'make W=1' warnings:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/libnvdimm.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_pmem.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_btt.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_e820.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/of_pmem.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_virtio.o

Just to double check.  This is a resend of this patch?

https://lore.kernel.org/all/20240526-md-drivers-nvdimm-v1-1-172e682e76bd@quicinc.com/

Dave Jiang, I'm picking up all these for the nvdimm tree and I think there
were a couple I was not CC'ed on.  I'll coordinate with you because I'm
still seeing a couple of these warnings on other modules in the test
build.

Also I want to double check all the descriptions before I send for 6.11.

Jeff is it ok if I alter the text?  I know you mentioned to Jonathan you
really just wanted to see the errors go away.

Ira

> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
>  drivers/nvdimm/btt.c       | 1 +
>  drivers/nvdimm/core.c      | 1 +
>  drivers/nvdimm/e820.c      | 1 +
>  drivers/nvdimm/nd_virtio.c | 1 +
>  drivers/nvdimm/of_pmem.c   | 1 +
>  drivers/nvdimm/pmem.c      | 1 +
>  6 files changed, 6 insertions(+)
> 
> diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
> index 1e5aedaf8c7b..a47acc5d05df 100644
> --- a/drivers/nvdimm/btt.c
> +++ b/drivers/nvdimm/btt.c
> @@ -1721,6 +1721,7 @@ static void __exit nd_btt_exit(void)
>  
>  MODULE_ALIAS_ND_DEVICE(ND_DEVICE_BTT);
>  MODULE_AUTHOR("Vishal Verma <vishal.l.verma@linux.intel.com>");
> +MODULE_DESCRIPTION("NVDIMM Block Translation Table");
>  MODULE_LICENSE("GPL v2");
>  module_init(nd_btt_init);
>  module_exit(nd_btt_exit);
> diff --git a/drivers/nvdimm/core.c b/drivers/nvdimm/core.c
> index 2023a661bbb0..f4b6fb4b9828 100644
> --- a/drivers/nvdimm/core.c
> +++ b/drivers/nvdimm/core.c
> @@ -540,6 +540,7 @@ static __exit void libnvdimm_exit(void)
>  	nvdimm_devs_exit();
>  }
>  
> +MODULE_DESCRIPTION("NVDIMM (Non-Volatile Memory Device) core module");
>  MODULE_LICENSE("GPL v2");
>  MODULE_AUTHOR("Intel Corporation");
>  subsys_initcall(libnvdimm_init);
> diff --git a/drivers/nvdimm/e820.c b/drivers/nvdimm/e820.c
> index 4cd18be9d0e9..008b9aae74ff 100644
> --- a/drivers/nvdimm/e820.c
> +++ b/drivers/nvdimm/e820.c
> @@ -69,5 +69,6 @@ static struct platform_driver e820_pmem_driver = {
>  module_platform_driver(e820_pmem_driver);
>  
>  MODULE_ALIAS("platform:e820_pmem*");
> +MODULE_DESCRIPTION("NVDIMM support for e820 type-12 memory");
>  MODULE_LICENSE("GPL v2");
>  MODULE_AUTHOR("Intel Corporation");
> diff --git a/drivers/nvdimm/nd_virtio.c b/drivers/nvdimm/nd_virtio.c
> index 1f8c667c6f1e..35c8fbbba10e 100644
> --- a/drivers/nvdimm/nd_virtio.c
> +++ b/drivers/nvdimm/nd_virtio.c
> @@ -123,4 +123,5 @@ int async_pmem_flush(struct nd_region *nd_region, struct bio *bio)
>  	return 0;
>  };
>  EXPORT_SYMBOL_GPL(async_pmem_flush);
> +MODULE_DESCRIPTION("Virtio Persistent Memory Driver");
>  MODULE_LICENSE("GPL");
> diff --git a/drivers/nvdimm/of_pmem.c b/drivers/nvdimm/of_pmem.c
> index d3fca0ab6290..5134a8d08bf9 100644
> --- a/drivers/nvdimm/of_pmem.c
> +++ b/drivers/nvdimm/of_pmem.c
> @@ -111,5 +111,6 @@ static struct platform_driver of_pmem_region_driver = {
>  
>  module_platform_driver(of_pmem_region_driver);
>  MODULE_DEVICE_TABLE(of, of_pmem_region_match);
> +MODULE_DESCRIPTION("NVDIMM Device Tree support");
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("IBM Corporation");
> diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
> index 598fe2e89bda..57cb30f8a3b8 100644
> --- a/drivers/nvdimm/pmem.c
> +++ b/drivers/nvdimm/pmem.c
> @@ -768,4 +768,5 @@ static struct nd_device_driver nd_pmem_driver = {
>  module_nd_driver(nd_pmem_driver);
>  
>  MODULE_AUTHOR("Ross Zwisler <ross.zwisler@linux.intel.com>");
> +MODULE_DESCRIPTION("NVDIMM Persistent Memory Driver");
>  MODULE_LICENSE("GPL v2");
> 
> ---
> base-commit: 416ff45264d50a983c3c0b99f0da6ee59f9acd68
> change-id: 20240526-md-drivers-nvdimm-121215a4b93f
> -- 
> Jeff Johnson <quic_jjohnson@quicinc.com>
>