Received: by 2002:ab2:784b:0:b0:1fd:adc2:8405 with SMTP id m11csp382160lqp; Mon, 10 Jun 2024 07:04:43 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWUN0LO7lW5QMyKVdpkVDtIHe8L8QDlNe9FZ5LUxhFYGnABLF+WyVrHDPVHyx+5tbzPWXO5iBNPz4RZVfbaDcoEUjUzZCNahF3WUYWsxw== X-Google-Smtp-Source: AGHT+IE4aiN/K2XPbmyF2zAbfJWcw1ATWr0xZ6xVQ5skJMnGVQp9rH0YgDFoPLcroKcR2YKVEKam X-Received: by 2002:a05:620a:4041:b0:795:21fc:13ab with SMTP id af79cd13be357-7953c31be06mr1141025785a.27.1718028282901; Mon, 10 Jun 2024 07:04:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718028282; cv=pass; d=google.com; s=arc-20160816; b=TyuWlAauwW0+FBRheCu4gOLOYkMM2zf158prIPqtr3J9qzSpwkiNSY4NQNjqDAiets akRM/wySIwn5CaSi76d499LYkytBXmGP2B+zBhKh/rRIMUTeOpPQPdfyvHSuJDI/996u XVRVpJsrhumlRWn7O/Pe0rz3kJDdyad6G3v1O8ACaDb1uAb+9aWTqY+NKAOLC6bxSAWz tB83Aqb8DalAeEt0aRwuGPv+u0cnLSJFDLezypHsXvW2L5oP9qF67fIxBpAoOxwNyHJp SvE0E5buUq0sS95dvOw1mJzywPNG6nEOCaCh5m/l47s2yIfOyJPdJsUpMd/3ax89mKY1 7imQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=wAXE+j35rInNLcSW0kzVtiyaeEo+8p0XntE6xZUSEi4=; fh=Lh+JMPZo65h8qJAnE5jHWvKtvWM25xS7kSTjy8t+qRE=; b=hHw0sdeoPXRMIRx82A8rCSZRmxUEyVS42Dz5vs95QrsUaAHstuUEENrL/Sc5sjogb+ +LF0KlRGhRBtiXJCbdMkA8yMPQdoc8okl+AlxJx4XWNQyjAATFW4fzz5beu22BZBbOY3 s3bd0oRDx0sz3CekyOWXSIfkcoxGucslHLAP38OvjtNhBS2eHAgwBYazJ5oLxfClJ/qr Dx3vxltTm0XYKPZabNF5DRSE2WE/ZDNQ/p0M8wRnWlBkLOUrbpyVwpO/qMqzeJmScZHy LNHddMvEuVZ49WtN5guT9B/SJRbXUarE274rEPBT8A7MiZOnzaHGeQaSB9rLQ8xOaqd/ f0xQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-208317-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-208317-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id af79cd13be357-7954d0b1959si676769085a.481.2024.06.10.07.04.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 07:04:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-208317-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-208317-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-208317-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9CF021C21F7C for ; Mon, 10 Jun 2024 14:04:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0E706142E7B; Mon, 10 Jun 2024 14:02:53 +0000 (UTC) Received: from mxout70.expurgate.net (mxout70.expurgate.net [91.198.224.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0886071B45; Mon, 10 Jun 2024 14:02:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.198.224.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718028172; cv=none; b=pKrspBwKgD8ZZEmM//15V7TEZvuDC94W9DBbEBWwhDR2IdYnaFEI0HYHrrJdS9MlH540+wGZAUh44/Hu2GG2TYKwy8KoFWijTiHQtv11uNbFLwEXNrjlVmPQqPsab7YOGx8QvbDxog6wfW2+AtHpOFmMmbnmjBSoFkbCzI0e1ik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718028172; c=relaxed/simple; bh=6nVh/RFHPpP/ApwFY6kktPoPTdT7kWzFRFeS0hlqlNM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UJy7X4dWqVpix1pUEmvsmcm26xUloBZ6Ei+YaXA/UxGhNpQdg0GHiUHkKP+BIxY7Fb+KTjw6+in6fgR+dQvoLgcW1PFBCjUxf0P2MF0mHxdYaAHvfayU9mM5zwhCY6Icl3iXHzdbcO+sOKIGTQnBMCpoXOfywjAHSxrHpnfjVFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; arc=none smtp.client-ip=91.198.224.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1sGfbk-00Cb9s-P6; Mon, 10 Jun 2024 16:02:48 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sGfbk-00Cb9f-6p; Mon, 10 Jun 2024 16:02:48 +0200 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id E64EC240053; Mon, 10 Jun 2024 16:02:47 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 7B77B240050; Mon, 10 Jun 2024 16:02:47 +0200 (CEST) Received: from mschiller1.dev.tdt.de (unknown [10.2.3.20]) by mail.dev.tdt.de (Postfix) with ESMTPSA id 1545936F2E; Mon, 10 Jun 2024 16:02:47 +0200 (CEST) From: Martin Schiller To: martin.blumenstingl@googlemail.com, hauke@hauke-m.de, andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ms@dev.tdt.de Subject: [PATCH net-next v3 03/12] net: dsa: lantiq_gswip: add terminating \n where missing Date: Mon, 10 Jun 2024 16:02:10 +0200 Message-ID: <20240610140219.2795167-4-ms@dev.tdt.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240610140219.2795167-1-ms@dev.tdt.de> References: <20240610140219.2795167-1-ms@dev.tdt.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-purgate: clean X-purgate-ID: 151534::1718028168-1EC4CD11-8D8FE224/0/0 X-purgate-type: clean Some dev_err are missing the terminating \n. Let's add that. Suggested-by: Vladimir Oltean Signed-off-by: Martin Schiller --- drivers/net/dsa/lantiq_gswip.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswi= p.c index b9c7076ce32f..fe64baf0d7f1 100644 --- a/drivers/net/dsa/lantiq_gswip.c +++ b/drivers/net/dsa/lantiq_gswip.c @@ -836,7 +836,7 @@ static int gswip_setup(struct dsa_switch *ds) =20 err =3D gswip_pce_load_microcode(priv); if (err) { - dev_err(priv->dev, "writing PCE microcode failed, %i", err); + dev_err(priv->dev, "writing PCE microcode failed, %i\n", err); return err; } =20 @@ -1792,7 +1792,7 @@ static u32 gswip_bcm_ram_entry_read(struct gswip_pr= iv *priv, u32 table, err =3D gswip_switch_r_timeout(priv, GSWIP_BM_RAM_CTRL, GSWIP_BM_RAM_CTRL_BAS); if (err) { - dev_err(priv->dev, "timeout while reading table: %u, index: %u", + dev_err(priv->dev, "timeout while reading table: %u, index: %u\n", table, index); return 0; } @@ -2021,7 +2021,7 @@ static void gswip_gphy_fw_remove(struct gswip_priv = *priv, =20 ret =3D regmap_write(priv->rcu_regmap, gphy_fw->fw_addr_offset, 0); if (ret) - dev_err(priv->dev, "can not reset GPHY FW pointer"); + dev_err(priv->dev, "can not reset GPHY FW pointer\n"); =20 clk_disable_unprepare(gphy_fw->clk_gate); =20 @@ -2050,7 +2050,7 @@ static int gswip_gphy_fw_list(struct gswip_priv *pr= iv, priv->gphy_fw_name_cfg =3D &xrx200a2x_gphy_data; break; default: - dev_err(dev, "unknown GSWIP version: 0x%x", version); + dev_err(dev, "unknown GSWIP version: 0x%x\n", version); return -ENOENT; } } @@ -2060,7 +2060,7 @@ static int gswip_gphy_fw_list(struct gswip_priv *pr= iv, priv->gphy_fw_name_cfg =3D match->data; =20 if (!priv->gphy_fw_name_cfg) { - dev_err(dev, "GPHY compatible type not supported"); + dev_err(dev, "GPHY compatible type not supported\n"); return -ENOENT; } =20 @@ -2163,7 +2163,7 @@ static int gswip_probe(struct platform_device *pdev= ) return -EINVAL; break; default: - dev_err(dev, "unknown GSWIP version: 0x%x", version); + dev_err(dev, "unknown GSWIP version: 0x%x\n", version); return -ENOENT; } =20 @@ -2191,7 +2191,7 @@ static int gswip_probe(struct platform_device *pdev= ) goto gphy_fw_remove; } if (!dsa_is_cpu_port(priv->ds, priv->hw_info->cpu_port)) { - dev_err(dev, "wrong CPU port defined, HW only supports port: %i", + dev_err(dev, "wrong CPU port defined, HW only supports port: %i\n", priv->hw_info->cpu_port); err =3D -EINVAL; goto disable_switch; --=20 2.39.2