Received-SPF: pass (google.com: domain of linux-kernel+bounces-208327-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <0dcef87c-e5e0-4298-bf83-1794bbbc60ed@quicinc.com>
Date: Mon, 10 Jun 2024 07:03:36 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RESEND] nvdimm: add missing MODULE_DESCRIPTION() macros
Content-Language: en-US
To: Ira Weiny <ira.weiny@intel.com>, Vishal Verma <vishal.l.verma@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
        Oliver O'Halloran
	<oohall@gmail.com>
CC: <nvdimm@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        <virtualization@lists.linux.dev>, <kernel-janitors@vger.kernel.org>
References: <20240526-md-drivers-nvdimm-v1-1-9e583677e80f@quicinc.com>
 <6667067e7e152_1700b5294ed@iweiny-mobl.notmuch>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <6667067e7e152_1700b5294ed@iweiny-mobl.notmuch>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 6/10/2024 6:58 AM, Ira Weiny wrote:
> Jeff Johnson wrote:
>> Fix the 'make W=1' warnings:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/libnvdimm.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_pmem.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_btt.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_e820.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/of_pmem.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/nvdimm/nd_virtio.o
> 
> Just to double check.  This is a resend of this patch?
> 
> https://lore.kernel.org/all/20240526-md-drivers-nvdimm-v1-1-172e682e76bd@quicinc.com/
> 
> Dave Jiang, I'm picking up all these for the nvdimm tree and I think there
> were a couple I was not CC'ed on.  I'll coordinate with you because I'm
> still seeing a couple of these warnings on other modules in the test
> build.
> 
> Also I want to double check all the descriptions before I send for 6.11.
> 
> Jeff is it ok if I alter the text?  I know you mentioned to Jonathan you
> really just wanted to see the errors go away.

Yes, please make the text whatever makes the most sense. In most of these
cases I'm not a domain expert so I construct these descriptions based upon
code comments, Kconfig descriptions, and git descriptions, and in some cases
these are originally wrong due to cut-n-paste or the drivers have evolved so
that information is no longer accurate.

I need to add a version of that to my b4 cover letter!

/jeff