Received: by 2002:ab2:784b:0:b0:1fd:adc2:8405 with SMTP id m11csp387984lqp; Mon, 10 Jun 2024 07:12:12 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV2gplHwORPJjmZ16Qkx/02UHRi5yp2b0SPa1LxZdgRtfQCjHV+bfwKpEv2F4SK7UiVatLL0gd3y5yO7SMzGqG+RPUEznGk+5aIxCsmxw== X-Google-Smtp-Source: AGHT+IGYdx9RqGRXzEI6h0k/vCr+Bswsik+lJ5/Ul6oU0TW2zbbA8Xvt07I6Or7O7ewUbsWzWS3v X-Received: by 2002:a05:6830:719c:b0:6f9:6c16:c0df with SMTP id 46e09a7af769-6f96c16c159mr9273206a34.0.1718028729236; Mon, 10 Jun 2024 07:12:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718028729; cv=pass; d=google.com; s=arc-20160816; b=EM20VnwH34j3xQQuf8lL2obxVR6uewCyUIOmO4rs28F3wOwLK5Vi5kqQLX1RZsfCLn DLIyBgMbnRWneikNe5gf1vCgJjn/tPGprt7Efqk0ZPdtwOFkfVqW5oMTS3J+8rHkmYoo MldpoER6V7kh46pXObFTEObHiWxD+hobdHdJlai0KBHE9KUBIN8OlvIor1bOzW0fqzzf C4mjyHA6M87qMiy/NaBL257kpU1dM7GgP508LJDvvYXZ8GW8zyy7OJnXYgdzlZiLM1iH M8oPNDZbCgd4MDs91PEoK9/F1YwKjBd+FFLHg6dq5EIeRrHSnHzpT4hr/FzSh8zihgw7 PESQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=/lhiuItvkVHmMoJg2I8J70vZt9P6vOE8r7ApFzJQBRs=; fh=m0ILw+PHQG+xTvZiVX1uC91CgOqFMkrUT11RCrTuGQo=; b=I9MhBtrBRYCKp4W8FsprVGP7wzBWs8X2+G44rz1lQoVFaEvoa6kgumaPA3lNwUOii0 PiHXdEy0jgD/0vtKyxgyCoP/OHq7iZwlbm0cy7jY1iL2glXcK4iSk55h4r29VB9BlxLN WbNYTPQyxLwSTs/R/MmQtg5oZrl0ILGu0A4W2phYdQk2psGASkKo61TSxOsBvGg7TVEC f0hj8aUabH1tdV/wjQ+D1RoNZml7GlHH0A8W2QIcV09jPzR8NSIqzLeVi9rfOm3LDcJ7 0vy+s3MFzGgFQjiC/AmEtDsBupPEz7vpnsrOqsc9kd7QnaMJRsWAJaDM8zZioemg3XqU SWDw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b="E/inZr5i"; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-208342-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-208342-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id ada2fe7eead31-48c54e25fc3si514108137.587.2024.06.10.07.12.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 07:12:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-208342-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b="E/inZr5i"; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-208342-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-208342-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E32CA1C21BB4 for ; Mon, 10 Jun 2024 14:12:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8DA158286B; Mon, 10 Jun 2024 14:11:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="E/inZr5i" Received: from mout.web.de (mout.web.de [212.227.15.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16CAA56452; Mon, 10 Jun 2024 14:11:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.3 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718028715; cv=none; b=b9epVbvS8WGcZth9qzEO/MhON0jmDqCOG1eLKQmIOMp4ms/3dyME4J+bthK888WJIyCEcE2gdtslAo7s/oZmwJvH0BN49+rIeaaImuMhbo35euIvWciuYxV1X2baZWJRwX7+OE3++w+c9dVOsQse2TDrp2ZuFHLo5vPATmgnjK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718028715; c=relaxed/simple; bh=/lhiuItvkVHmMoJg2I8J70vZt9P6vOE8r7ApFzJQBRs=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=Dvz78yXsRTd7z1qB8557kcou6YfpynRcQevj38qwr0TSZjEO++M6oWxVsV/qUZYR4zqNGBlL2/IHQHnEKEuv0fAP0/QZEFIIzH6EcYLLo2y+PPnSTlr336L7KOmINdfHcmiJyCMLB8reZ6CuHnxCwN83QpLGkrbQm8HAuDJGrdE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=E/inZr5i; arc=none smtp.client-ip=212.227.15.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1718028707; x=1718633507; i=markus.elfring@web.de; bh=/lhiuItvkVHmMoJg2I8J70vZt9P6vOE8r7ApFzJQBRs=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=E/inZr5iQTRHk0PCU5TRQG1G/R8kPnniB+vo02wc9iREd4k1AcTbz5kGVAck66J6 D6130Rra7EHXrUjBT73yUsyTcK67m+ilFfhFFrsT3h80iu6ToJ7N24c+W7qbs2HZE v8iiJNS6+DRbEETXdjoJlR10oxqsdMBLIUpz9BRkXpJ73LbbI7cQWccov0F0nukDy CQi/I3cb2SQKwgLXUxt4tS5S4tZA7y7ZPNw9B2wd/ZTrEYRu4oM+lRheGCnn6zFtW 3OBkPIVo8blmJzpAQeR9kKMhjy9phVvG8c0Q5grzjDT2jRDJ+0vehC55MrJug2x8R 7+CuzNKTI1ldiaYcAA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.83.95]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1N7gXO-1sTa5p1sfq-00xsJ0; Mon, 10 Jun 2024 16:11:47 +0200 Message-ID: Date: Mon, 10 Jun 2024 16:11:46 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Dmitry Torokhov , linux-input@vger.kernel.org Cc: LKML , John Keeping , Marek Vasut References: <20240609234757.610273-3-dmitry.torokhov@gmail.com> Subject: Re: [PATCH 3/3] Input: ili210x - use guard notation when disabling and reenabling IRQ Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240609234757.610273-3-dmitry.torokhov@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:W9Au6bb2Nb9f3GU2rnfg+mjE9ytJH+R5EvXKap+iOfQuGxRXmyf VTUsjc7axRqM38fgI0+e7V7KkpK/Nr8WAomzRxQI0MR3o0Q4pv/lXWcHOWPqEiT4uUJbVLh RSvTUiR9U0HKsH6gpnIH89sXR0kWT9j31W5pul+fhlEduKVTDf4roWQadGSIqf1wFJ0pmk6 b6DJaIRRKV67PihQ9pBzw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:lgfsa2PdNcA=;X/fgV8okucco5n8lsnjPQz6b5jH /XIcQwTwp2pdEs+WbQrHM6Ms1K07HZn0ubQad3pBNYiOC/LxofCGn9EsYnRXcUmr7XG1rFUrh 4UU9VaC7tCjNEk/V0wn+Tbq5v6OK2TBTD8ZjEZQTuW2+gKwoOlz/l2DA0vWvoJV5FhSZgDwYV 4uJWf6Fd22gj6LVHzIljmZjll9km2DqJlgk8+eTQhHwYnupYgN7Ien8G5yY3S5ec38lNsrJAv ppGI6Ezm4RgrBCRCKjhf7Pfh64x743g/oCMXC6GjKzPSWRfOXBPBdm48hJvs4YqLVkYb/JdLF 9t/4ETe0rGKimCg2KxmrlpXLii3nS3MdNbVWO0B/3tI/2iVASWC35oyDALNAJS+UtuRKe0jv6 X8NikMIyHJdZrqCkkWP5un1MkRWbW4RCjBVbcKvfupzUjTOsh500sTNm4Uqoi09r7HD+WFpm2 TLOIEA9ihgL3HF+5GPSna6u2B7SVhAF879MA6mbOkMaXVxGLFWoaFKBPXOi2Tk1l0UNXOGMyI DNKAovdIy6qQ5ISmcCgasvcSwLP0Z5/0H8SFAAlmDLqdaR+1D0dQ5t6tvuDnWbnVsHOAi3mdw oEow4RHewSE4pjiq9zP6xSaR6+gRWv+8CWA/5maDb7EgTO42yhxejrSsQBB295kMdDR/euzev 6EZ1Mb5El4MOGD5Itc54lb2FPr2Nbi/WLB+v5NClE4UG+XfIOmohBjIrFc2HZcsq8Yu4Y5LwF iboeWxquI6HVEoXGIyTLlc9bN//5Xn+y6od/pZ/lGMs+TnJy10acB4apYcjJYTxMu+l/C9vDj nUCaqHM2Kb6uI6oYhIqMcd3MC4mYp7503Lk8yPPIq2Q6c= > This makes the code more compact and error handling more robust. Please improve the change description with an imperative wording. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc2#n94 Regards, Markus