Received-SPF: pass (google.com: domain of linux-kernel+bounces-208348-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <2d52b1a5-4c44-4cea-bccf-57972ca79f04@gmail.com>
Date: Mon, 10 Jun 2024 15:14:34 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 1/2] mm: store zero pages to be swapped out in a bitmap
To: Matthew Wilcox <willy@infradead.org>, hannes@cmpxchg.org,
 yosryahmed@google.com, nphamcs@gmail.com
Cc: akpm@linux-foundation.org, david@redhat.com, ying.huang@intel.com,
 hughd@google.com, chengming.zhou@linux.dev, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, kernel-team@meta.com
References: <20240610121820.328876-1-usamaarif642@gmail.com>
 <20240610121820.328876-2-usamaarif642@gmail.com>
 <Zmb6r6vrP2UTDQrK@casper.infradead.org>
 <acb76cdb-a54e-48e0-ba18-a2272d84f0ab@gmail.com>
 <ZmcITDhdBzUGEHuY@casper.infradead.org>
Content-Language: en-US
From: Usama Arif <usamaarif642@gmail.com>
In-Reply-To: <ZmcITDhdBzUGEHuY@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 10/06/2024 15:06, Matthew Wilcox wrote:
> On Mon, Jun 10, 2024 at 02:56:09PM +0100, Usama Arif wrote:
>> I am guessing what you are suggesting is just do this?
>>
>>      if (is_folio_zero_filled(folio)) {
>>          swap_zeromap_folio_set(folio);
>>          folio_unlock(folio);
>>          return 0;
>>      }
> Right.

Thanks! Will change to this in the next revision.

>> If we have zswap enabled, the zero filled pages (infact any page that is
>> compressed), will be saved in zswap_entry and NR_WRITTEN will be wrongly
>> incremented. So the behaviour for NR_WRITTEN does not change in this patch
>> when encountering zero pages with zswap enabled (even if its wrong).
> We should fiz zswap too.
>
Will send the below diff as a separate patch for zswap:

diff --git a/mm/page_io.c b/mm/page_io.c index 
2cac1e11fb85..82796b9f08c7 100644 --- a/mm/page_io.c +++ b/mm/page_io.c 
@@ -281,9 +281,7 @@ int swap_writepage(struct page *page, struct 
writeback_control *wbc) } swap_zeromap_folio_clear(folio); if 
(zswap_store(folio)) { - folio_start_writeback(folio); 
folio_unlock(folio); - folio_end_writeback(folio); return 0; }