Received-SPF: pass (google.com: domain of linux-kernel+bounces-208359-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 10 Jun 2024 17:20:44 +0300
From: Vitaly Chikunov <vt@altlinux.org>
To: stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dan Gora <dan.gora@gmail.com>, Marcel Holtmann <marcel@holtmann.org>, 
	Johan Hedberg <johan.hedberg@gmail.com>, Luiz Augusto von Dentz <luiz.dentz@gmail.com>, 
	linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Leonid Krivoshein <klark.devel@gmail.com>
Subject: Re: [PATCH v2 1/1] Bluetooth: btrtl: Add missing MODULE_FIRMWARE
 declarations
Message-ID: <lpcccmoa34ifxregretv3cim3cfajonkcwbm3d6j5d4ekyweya@k2cswpafqdw7>
References: <20230504212843.18519-1-dan.gora@gmail.com>
 <20230509195119.9655-1-dan.gora@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230509195119.9655-1-dan.gora@gmail.com>

Greg, Sasha,

Please add this patch to 6.1.x branch. Mainline commit
bb23f07cb63975968bbabe314486e2b087234fc5

This will fix Bluetooth support (visibility of devices) and manifested
errors during boot:

  bluetooth hci0: Direct firmware load for rtl_bt/rtl8822cu_fw.bin failed with error -2
  Bluetooth: hci0: RTL: firmware file rtl_bt/rtl8822cu_fw.bin not found

Downstream bug report: https://bugzilla.altlinux.org/50471

Thanks,

On Tue, May 09, 2023 at 12:51:19PM -0700, Dan Gora wrote:
> Add missing MODULE_FIRMWARE declarations for firmware referenced in
> btrtl.c.
> 
> Signed-off-by: Dan Gora <dan.gora@gmail.com>
> ---
>  drivers/bluetooth/btrtl.c | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
> index 2915c82d719d..d978e7cea873 100644
> --- a/drivers/bluetooth/btrtl.c
> +++ b/drivers/bluetooth/btrtl.c
> @@ -1367,14 +1367,30 @@ MODULE_FIRMWARE("rtl_bt/rtl8723cs_vf_fw.bin");
>  MODULE_FIRMWARE("rtl_bt/rtl8723cs_vf_config.bin");
>  MODULE_FIRMWARE("rtl_bt/rtl8723cs_xx_fw.bin");
>  MODULE_FIRMWARE("rtl_bt/rtl8723cs_xx_config.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8723d_fw.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8723d_config.bin");
>  MODULE_FIRMWARE("rtl_bt/rtl8723ds_fw.bin");
>  MODULE_FIRMWARE("rtl_bt/rtl8723ds_config.bin");
>  MODULE_FIRMWARE("rtl_bt/rtl8761a_fw.bin");
>  MODULE_FIRMWARE("rtl_bt/rtl8761a_config.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8761b_fw.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8761b_config.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8761bu_fw.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8761bu_config.bin");
>  MODULE_FIRMWARE("rtl_bt/rtl8821a_fw.bin");
>  MODULE_FIRMWARE("rtl_bt/rtl8821a_config.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8821c_fw.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8821c_config.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8821cs_fw.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8821cs_config.bin");
>  MODULE_FIRMWARE("rtl_bt/rtl8822b_fw.bin");
>  MODULE_FIRMWARE("rtl_bt/rtl8822b_config.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8822cs_fw.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8822cs_config.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8822cu_fw.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8822cu_config.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8851bu_fw.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8851bu_config.bin");
>  MODULE_FIRMWARE("rtl_bt/rtl8852au_fw.bin");
>  MODULE_FIRMWARE("rtl_bt/rtl8852au_config.bin");
>  MODULE_FIRMWARE("rtl_bt/rtl8852bs_fw.bin");
> @@ -1383,5 +1399,3 @@ MODULE_FIRMWARE("rtl_bt/rtl8852bu_fw.bin");
>  MODULE_FIRMWARE("rtl_bt/rtl8852bu_config.bin");
>  MODULE_FIRMWARE("rtl_bt/rtl8852cu_fw.bin");
>  MODULE_FIRMWARE("rtl_bt/rtl8852cu_config.bin");
> -MODULE_FIRMWARE("rtl_bt/rtl8851bu_fw.bin");
> -MODULE_FIRMWARE("rtl_bt/rtl8851bu_config.bin");
> -- 
> 2.35.1.102.g2b9c120970
>