Received-SPF: pass (google.com: domain of linux-kernel+bounces-208371-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <231a8ee8-b66d-4d40-a9ff-9fdf4918944b@suse.com>
Date: Mon, 10 Jun 2024 17:31:58 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86/cpu: Move identify_cpu_without_cpuid() into main
 branch
To: Thomas Gleixner <tglx@linutronix.de>, x86@kernel.org
Cc: linux-kernel@vger.kernel.org
References: <20240521124823.486372-1-nik.borisov@suse.com>
 <87wmmwx5bk.ffs@tglx>
From: Nikolay Borisov <nik.borisov@suse.com>
Content-Language: en-US
In-Reply-To: <87wmmwx5bk.ffs@tglx>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 10.06.24 г. 17:03 ч., Thomas Gleixner wrote:
> On Tue, May 21 2024 at 15:48, Nikolay Borisov wrote:
>> No point in duplicating if (!have_cpuid_p()) check. Simply move
>> identify_cpu_without_cpuid() into the else branch. No functional
>> changes.
> 
> You wish :)
> 
>> Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>
>> ---
>>   arch/x86/kernel/cpu/common.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
>> index 2b170da84f97..69265c0acaea 100644
>> --- a/arch/x86/kernel/cpu/common.c
>> +++ b/arch/x86/kernel/cpu/common.c
>> @@ -1578,9 +1578,6 @@ static void __init early_identify_cpu(struct cpuinfo_x86 *c)
>>   	memset(&c->x86_capability, 0, sizeof(c->x86_capability));
>>   	c->extended_cpuid_level = 0;
>>   
>> -	if (!have_cpuid_p())
>> -		identify_cpu_without_cpuid(c);
>> -
> 
> You might look what identify_cpu_without_cpuid() does and how the
> comment right here might be related:

Doh, fair enough. OTOH is Cyrix still relevant? Google says Defunct: 
November 11, 1997; 26 years ago


> 
>>   	/* cyrix could have cpuid enabled via c_identify()*/
>>   	if (have_cpuid_p()) {
> 
> Thanks,
> 
>          tglx