Received-SPF: pass (google.com: domain of linux-kernel+bounces-208408-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Daniel Gomez <da.gomez@samsung.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
CC: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"hughd@google.com" <hughd@google.com>, "willy@infradead.org"
	<willy@infradead.org>, "david@redhat.com" <david@redhat.com>,
	"wangkefeng.wang@huawei.com" <wangkefeng.wang@huawei.com>,
	"chrisl@kernel.org" <chrisl@kernel.org>, "ying.huang@intel.com"
	<ying.huang@intel.com>, "21cnbao@gmail.com" <21cnbao@gmail.com>,
	"ryan.roberts@arm.com" <ryan.roberts@arm.com>, "shy828301@gmail.com"
	<shy828301@gmail.com>, "ziy@nvidia.com" <ziy@nvidia.com>,
	"ioworker0@gmail.com" <ioworker0@gmail.com>, Pankaj Raghav
	<p.raghav@samsung.com>, "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/7] mm: shmem: extend shmem_partial_swap_usage() to
 support large folio swap
Thread-Topic: [PATCH 4/7] mm: shmem: extend shmem_partial_swap_usage() to
	support large folio swap
Thread-Index: AQHauAk6tPOy90LG0EqwmRY04o2YSLHBCwmA
Date: Mon, 10 Jun 2024 14:53:22 +0000
Message-ID: <qlk2dpg2fmro5vzjks45ciwt3qk6nzlurfmlqnjr4ecskgg7ln@w5ba55tgtcsb>
In-Reply-To: <358924679107339e6b17a5d8b1b2e10ae6306227.1717673614.git.baolin.wang@linux.alibaba.com>
Accept-Language: en-US, en-GB
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9FF719F11960B546A2F926BF1CD6BC46@scsc.local>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGKsWRmVeSWpSXmKPExsWy7djPc7rpwulpBo3LDCw+3xWymLN+DZvF
	/73HGC2aHjxisvi6/hezxdNPfSwWi34bW1zeNYfN4t6a/6wWPbunMlosOLGY0aLx831Gi98/
	gBInZ01msZh99B67A7/HmnlrGD12zrrL7rFgU6lHy5G3rB6bV2h5LN7zkslj06pONo9Nnyax
	e5yY8ZvFY+dDS4/e5ndsHu/3XWXz+LxJLoA3issmJTUnsyy1SN8ugSuj++BC1oKNnBVTr8g2
	MC5g72Lk5JAQMJGY+fwLI4gtJLCCUeL055ouRi4g+wujxM0lT9khnM+MEq9mnWKF6Xj64ABU
	YjmjxMftJ5jhqnZvbWCEcM4wSvR+/cwK4axklHj65ApYP5uApsS+k5uA+jk4RAT0JXrn+oLU
	MAscYpVoPHsO7BJhgWSJ/5NmgtWLCKRITP8+mQnCNpKYfGwiG4jNIqAqsf3lPWaQObwCvhLn
	/kaChDmByht6ZoG1MgrISjxa+QvsUWYBcYlbT+YzQbwgKLFo9h5mCFtM4t+uh2wQto7E2etP
	GCFsA4mtS/exQNiKEh3HbrJBzNGRWLD7E5RtKbFl50oWCFtbYtnC12AzeYHmn5z5BKp3L5fE
	nuMlELaLxJUJy6H2Cku8Or6FfQKjziwk581CsmIWkhWzkKyYhWTFAkbWVYziqaXFuempxcZ5
	qeV6xYm5xaV56XrJ+bmbGIFJ8/S/4193MK549VHvECMTB+MhRgkOZiURXqGM5DQh3pTEyqrU
	ovz4otKc1OJDjNIcLErivKop8qlCAumJJanZqakFqUUwWSYOTqkGJuanrBIu60tSbM+KyHT6
	hDuc2xhctUEnjO3ervrrf49GiXbf//tf03nzk7msH+z32E/xuyV400P2b9Sqxm8nXf0tn+5R
	vNYpZ+g/edFHVUG3b1xfr5S+yGhQrmxfHMd26MK2ZZMW/mmNYlP6z1uSFcXzoktLwXOGrPK9
	x+umVm9ub1yaJTE7gmtK53m/7EVphpLf+y1lVgWndL5epXSiUbi4b/1Cg9VrDJfZvn37efKq
	OH2vZf+v6Zw7GeKjlJ/XKy7heEM3/fwZ+2pnxpJfJdl2UhL5u7byM0/8e1J715MFS5d97fh/
	6sBDPqvkDdtzJu6xlexdubdEbf2UtLzwz1avHutKls59Ias0/+uj20osxRmJhlrMRcWJANKE
	EXkJBAAA
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPKsWRmVeSWpSXmKPExsVy+t/xe7rpwulpBjPWi1p8vitkMWf9GjaL
	/3uPMVo0PXjEZPF1/S9mi6ef+lgsFv02tri8aw6bxb01/1ktenZPZbRYcGIxo0Xj5/uMFr9/
	ACVOzprMYjH76D12B36PNfPWMHrsnHWX3WPBplKPliNvWT02r9DyWLznJZPHplWdbB6bPk1i
	9zgx4zeLx86Hlh69ze/YPN7vu8rm8XmTXABvlJ5NUX5pSapCRn5xia1StKGFkZ6hpYWekYml
	nqGxeayVkamSvp1NSmpOZllqkb5dgl5G98GFrAUbOSumXpFtYFzA3sXIySEhYCLx9MEBIJuL
	Q0hgKaNEz5NdUAkZiY1frrJC2MISf651sUEUfWSUuPS8F6xISOAMo8SNve4QiZWMEm1/XoEl
	2AQ0Jfad3ARkc3CICOhL9M71BalhFjjEKtF49hwjSI2wQLLE/0kzwTaICKRIbO46wQ5hG0lM
	PjaRDcRmEVCV2P7yHjPIHF4BX4lzfyMhds1ilLj/7ShYLydQb0PPLDCbUUBW4tHKX2BzmAXE
	JW49mc8E8YGAxJI955khbFGJl4//QX2mI3H2+hNGCNtAYuvSfSwQtqJEx7GbbBBzdCQW7P4E
	ZVtKbNm5kgXC1pZYtvA12ExeAUGJkzOfsExglJmFZPUsJO2zkLTPQtI+C0n7AkbWVYwiqaXF
	uem5xUZ6xYm5xaV56XrJ+bmbGIEpcduxn1t2MK589VHvECMTB+MhRgkOZiURXqGM5DQh3pTE
	yqrUovz4otKc1OJDjKbAsJvILCWanA9Mynkl8YZmBqaGJmaWBqaWZsZK4ryeBR2JQgLpiSWp
	2ampBalFMH1MHJxSDUzbp/qVvln0IqZl1dQtG4rnvlz2xC+Hp6vMN+jexcrWLO5zip9YWCoa
	DbTy7zYsbNKT4ZoQwH+BX0hv/vVJjmHcCju+HZJVdrGYItDcUJgn8VDI8Gak8ey/3B/qP2js
	fTYrpNdlvuvhY81Ldxfv03x/uaBYu0bloFKbN9MFz63FXlfLD8eGdJ552NS77MP9S3E9RmHS
	NXpbxf4Ybqx+Gl7zZLPm3Kv/Sud47FcOLbNj3/CiUc1NuzgyJz2gWM8s0nhVBPdCntLtZ60V
	HP38JzFGK++WdHp1LtFU8UV+aLhLwFLJs6/ai5dm8Qe9qtl0snZO4hN/5ZBbM1901LWwZsu1
	/2GquVR1aeFflmAPJZbijERDLeai4kQAgaTV1RIEAAA=
X-CMS-MailID: 20240610145327eucas1p1bb32a985f8eaddf8cdda0b5415c1868c
X-Msg-Generator: CA
X-RootMTR: 20240610145327eucas1p1bb32a985f8eaddf8cdda0b5415c1868c
X-EPHeader: CA
CMS-TYPE: 201P
X-CMS-RootMailID: 20240610145327eucas1p1bb32a985f8eaddf8cdda0b5415c1868c
References: <cover.1717673614.git.baolin.wang@linux.alibaba.com>
	<358924679107339e6b17a5d8b1b2e10ae6306227.1717673614.git.baolin.wang@linux.alibaba.com>
	<CGME20240610145327eucas1p1bb32a985f8eaddf8cdda0b5415c1868c@eucas1p1.samsung.com>

Hi Baolin,
On Thu, Jun 06, 2024 at 07:58:54PM +0800, Baolin Wang wrote:
> To support shmem large folio swapout in the following patches, using
> xa_get_order() to get the order of the swap entry to calculate the swap
> usage of shmem.
>=20
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
>  mm/shmem.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>=20
> diff --git a/mm/shmem.c b/mm/shmem.c
> index eefdf5c61c04..0ac71580decb 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -865,13 +865,16 @@ unsigned long shmem_partial_swap_usage(struct addre=
ss_space *mapping,
>  	struct page *page;
>  	unsigned long swapped =3D 0;
>  	unsigned long max =3D end - 1;
> +	int order;
> =20
>  	rcu_read_lock();
>  	xas_for_each(&xas, page, max) {
>  		if (xas_retry(&xas, page))
>  			continue;
> -		if (xa_is_value(page))
> -			swapped++;
> +		if (xa_is_value(page)) {
> +			order =3D xa_get_order(xas.xa, xas.xa_index);
> +			swapped +=3D 1 << order;

I'd get rid of order and simply do:

	swapped +=3D 1UL << xa_get_order()


> +		}
>  		if (xas.xa_index =3D=3D max)
>  			break;
>  		if (need_resched()) {
> --=20
> 2.39.3
> =