Received-SPF: pass (google.com: domain of linux-kernel+bounces-208406-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <e730c786-86b9-4362-986d-cfe37ef33753@quicinc.com>
Date: Mon, 10 Jun 2024 07:51:39 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] pwm: add missing MODULE_DESCRIPTION() macros
Content-Language: en-US
To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@baylibre.com>,
        AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
CC: Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam
	<festevam@gmail.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Alim Akhtar
	<alim.akhtar@samsung.com>,
        Nobuhiro Iwamatsu
	<nobuhiro1.iwamatsu@toshiba.co.jp>,
        Matthias Brugger
	<matthias.bgg@gmail.com>,
        <linux-pwm@vger.kernel.org>, <imx@lists.linux.dev>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <linux-samsung-soc@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>,
        <kernel-janitors@vger.kernel.org>
References: <20240607-md-drivers-pwm-v1-1-27237a2bec6a@quicinc.com>
 <ca6b4ce2-4ebf-409d-b87d-2024445b9392@collabora.com>
 <g5u7xk2l625vu6dxleonlmshnwqoge5fiaigbqlcedayu2rate@o4vgz7g27vlv>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <g5u7xk2l625vu6dxleonlmshnwqoge5fiaigbqlcedayu2rate@o4vgz7g27vlv>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

On 6/10/2024 2:05 AM, Uwe Kleine-König wrote:
> Hello,
> 
> On Mon, Jun 10, 2024 at 10:06:49AM +0200, AngeloGioacchino Del Regno wrote:
>> Il 07/06/24 18:02, Jeff Johnson ha scritto:
>>> [...]
>>> diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
>>> index 19a87873ad60..0b5d68a90e83 100644
>>> --- a/drivers/pwm/pwm-mediatek.c
>>> +++ b/drivers/pwm/pwm-mediatek.c
>>> @@ -395,4 +395,5 @@ static struct platform_driver pwm_mediatek_driver = {
>>>   module_platform_driver(pwm_mediatek_driver);
>>>   MODULE_AUTHOR("John Crispin <blogic@openwrt.org>");
>>> +MODULE_DESCRIPTION("MediaTek Pulse Width Modulator driver");
>>
>> MediaTek SoCs have got two different PWM IPs, one of which is used exclusively
>> for the Display PWM, and it is located in the DDP block.
>>
>> So, there are two PWM IPs in one SoC:
>>  - A general purpose PWM IP
>>  - A DDP PWM IP
>>
>> This driver is for the general purpose PWM IP.. so, please, can we change this
>> to "MediaTek general purpose Pulse Width Modulator driver"?
>>
>> After which,
>>
>> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> 
> Looks like a reasonable request.
> 
> @Jeff: Can you please resend with the suggested change, I dropped the
> patch from for-next now.

No problem, v2 sent.

/jeff