Received: by 2002:ab2:784b:0:b0:1fd:adc2:8405 with SMTP id m11csp428414lqp; Mon, 10 Jun 2024 08:16:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW97Mwlv8b/60X40eVt9TAkA/ZSgLWIo4JVIy7WQ8oeunx+fIqWq2R/TkzBTfdjkPGa7j8bMW8P+6XxtZQPrteZ9xBEKkgUnhBTHfKrvA== X-Google-Smtp-Source: AGHT+IGFG9WQUI74GliwuO3dyPXNmFhziaoImPXwD9nZBDhL5TjVGAPpD71V9dpBZuhmGCUXxjeq X-Received: by 2002:a50:9509:0:b0:578:649e:e63e with SMTP id 4fb4d7f45d1cf-57c508b42fbmr6100317a12.16.1718032593712; Mon, 10 Jun 2024 08:16:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718032593; cv=pass; d=google.com; s=arc-20160816; b=n1oMANg2N9C7e6qKV/NqhNw/mRp+rJ8XpTWmNrD8StHRMq+mbVp1PvllZSdDjttbzF O7H7Y97AYRZRt3hOzvw8CPUwSU0TCCjZXRA8Nyxe+xkd89PWn1mLkDdtBNtjRzLVSzV5 lQ1squly1BHE5130a1mn/zEjcKv5HYTvOJkIgSc2cDCRBQbFQwp7l4F51tHy4wRTk0kk 2BFv2xU1GAcesneWEIGCfZgQS3j1gv1o23RmuZ0I91yyp1bK6LoW6Xm/D9FjaEc3rhWx BTvwUJCqykqC2pEKlZpQ5QOJNQcucoz32zjHsYgRluV3ihou3+TXAWg2Dx6yJaJRg/Pq DjEQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=NwWtA3U6C0/T6wcaxv2G2tDF8AG/aMja6H41Ja4PR/E=; fh=NBWFQeoQJCxKalVKeIRTZaO55uIqw1uKTUtRX+uowOE=; b=YZ5TjwInkip7TNDoKsx1LGj7yOkKWpTWTKBe0FJLwqZf7f8dk8l1nXXenmcuuM+YaM 8r6/MiX0eY34xPFGms+1SnPNZ2PmKibj6/xdPx3tZLJXhuxvncOKdU8CdfQfLgrqLALL ROSP1TrrQudl1ibrry4blKm6klp92shZjj7ni+wVBarFPDrwnT/nk2lfLvmozG8HAeeW rCouFFhr/WDOxWZdgvWAiMg6RI1nREFKw4styxqAA0NZ0Cydt6ufr1XVCR+pnXc7YIZU WZY8oD/j4HKAQDXZTPiAAPnTre/hM5MO1vZRh53jz/Us10qItUC5VtBOQUZHHWYM776S 3ekA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dfZV4kER; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-208442-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-208442-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57c749a005dsi1930494a12.423.2024.06.10.08.16.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 08:16:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-208442-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=dfZV4kER; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-208442-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-208442-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6CA181F24C96 for ; Mon, 10 Jun 2024 15:16:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D366D142E88; Mon, 10 Jun 2024 15:15:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="dfZV4kER" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7808C13D63E; Mon, 10 Jun 2024 15:15:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718032537; cv=none; b=SJfS8SLL3W+82kUdq1LiLqcj0N/hegywklIU32HV/ONNj7cvW09YfGZiEYEpJFhBkYrfr7E2bItFx+B14jnfjlGY3jib7BYSzWu737r8wYviehqk20nWW/90IVX5Q3ywWex2AId/wc2IRdP0ekEID/Pc+NiSsfqRR+KPEQL5K8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718032537; c=relaxed/simple; bh=txOdnyzOZSlUtJWZAp7znb1Tmc2oa6fkNXyfq6rUxzM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=b9nbcWfEHxnICyZyixvWaA/7pJrPUqg2I+DoMYrVPmQKljSyNhgIjDsZ6Skk/OBoKFj6Z+vP0XkVBGKJMZlNiRtkKw0pdZi0IxAujmYxA3z+1JfGCtQCxzO6X4b+mQ0skNXS+bxvkSPDgQJWR1lO1dMGJnEA1SAzru7dJ5xR2pg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=dfZV4kER; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718032535; x=1749568535; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=txOdnyzOZSlUtJWZAp7znb1Tmc2oa6fkNXyfq6rUxzM=; b=dfZV4kERZq2GvxGuCCN81X8hKmXkDJp3AQfXZy4s5VZWS6+234BT3w09 7oBOCjl1ykgq4OD1SyQY1xbp1cViKcUEUwhPwc2EE+FVahw4HIKfNKgj5 kObGrpezo0vuDq4idl+yNgxS0Hi2+Y3PSdsXidZ0upUl+QYHgqXTVS0cJ JWhGYAPvqNJwYxpdigpS2V0uFDE+SRkWx+RvBeApdwHx5VLITmpgRCTwn jHPqPwGfx+wxc0INHauf/9OscgwZ61krDZJfpRpmax5IEIj+eOep+48zP bwdkxudDzqP/8jdbIa4cJwi2LC1cdjBdaASnj78SA5cOdhXU8lhI4P0Rl A==; X-CSE-ConnectionGUID: 4S6hxvVORmC7WRwpkf51bQ== X-CSE-MsgGUID: sivjGbmYTB2vAhNqoiqf8w== X-IronPort-AV: E=McAfee;i="6600,9927,11099"; a="18530775" X-IronPort-AV: E=Sophos;i="6.08,227,1712646000"; d="scan'208";a="18530775" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2024 08:15:35 -0700 X-CSE-ConnectionGUID: U7+C+GMgQEWFZgghv240MA== X-CSE-MsgGUID: kUSsJ7ggSvylhh3XsxYO3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,227,1712646000"; d="scan'208";a="39650649" Received: from ijarvine-desk1.ger.corp.intel.com (HELO localhost) ([10.245.247.194]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2024 08:15:31 -0700 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= To: linux-kselftest@vger.kernel.org, Shuah Khan , Reinette Chatre , Babu Moger , =?UTF-8?q?Maciej=20Wiecz=C3=B3r-Retman?= Cc: Fenghua Yu , linux-kernel@vger.kernel.org, Shuah Khan , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Subject: [PATCH v7 03/16] selftests/resctrl: Make "bandwidth" consistent in comments & prints Date: Mon, 10 Jun 2024 18:14:44 +0300 Message-Id: <20240610151457.7305-4-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240610151457.7305-1-ilpo.jarvinen@linux.intel.com> References: <20240610151457.7305-1-ilpo.jarvinen@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Resctrl selftests refer to "bandwidth" currently in two other forms in the code ("B/W" and "band width"). Use "bandwidth" consistently everywhere. While at it, fix also one "over flow" -> "overflow" on a line that is touched by the change. Suggested-by: Reinette Chatre Signed-off-by: Ilpo Järvinen Tested-by: Babu Moger Reviewed-by: Reinette Chatre --- v3: - New patch --- tools/testing/selftests/resctrl/resctrl_val.c | 14 +++++++------- tools/testing/selftests/resctrl/resctrlfs.c | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/resctrl/resctrl_val.c b/tools/testing/selftests/resctrl/resctrl_val.c index 3c7f6793c261..5fad7e757af3 100644 --- a/tools/testing/selftests/resctrl/resctrl_val.c +++ b/tools/testing/selftests/resctrl/resctrl_val.c @@ -361,11 +361,11 @@ static void do_imc_mem_bw_test(void) } /* - * get_mem_bw_imc - Memory band width as reported by iMC counters + * get_mem_bw_imc - Memory bandwidth as reported by iMC counters * @bw_report: Bandwidth report type (reads, writes) * - * Memory B/W utilized by a process on a socket can be calculated using - * iMC counters. Perf events are used to read these counters. + * Memory bandwidth utilized by a process on a socket can be calculated + * using iMC counters. Perf events are used to read these counters. * * Return: = 0 on success. < 0 on failure. */ @@ -379,7 +379,7 @@ static int get_mem_bw_imc(char *bw_report, float *bw_imc) /* * Get results which are stored in struct type imc_counter_config - * Take over flow into consideration before calculating total b/w + * Take overflow into consideration before calculating total bandwidth. */ for (imc = 0; imc < imcs; imc++) { struct imc_counter_config *r = @@ -389,13 +389,13 @@ static int get_mem_bw_imc(char *bw_report, float *bw_imc) if (read(r->fd, &r->return_value, sizeof(struct membw_read_format)) == -1) { - ksft_perror("Couldn't get read b/w through iMC"); + ksft_perror("Couldn't get read bandwidth through iMC"); return -1; } if (read(w->fd, &w->return_value, sizeof(struct membw_read_format)) == -1) { - ksft_perror("Couldn't get write bw through iMC"); + ksft_perror("Couldn't get write bandwidth through iMC"); return -1; } @@ -492,7 +492,7 @@ static FILE *open_mem_bw_resctrl(const char *mbm_bw_file) fp = fopen(mbm_bw_file, "r"); if (!fp) - ksft_perror("Failed to open total bw file"); + ksft_perror("Failed to open total memory bandwidth file"); return fp; } diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/selftests/resctrl/resctrlfs.c index 1cade75176eb..9b86f826a40c 100644 --- a/tools/testing/selftests/resctrl/resctrlfs.c +++ b/tools/testing/selftests/resctrl/resctrlfs.c @@ -850,7 +850,7 @@ int validate_bw_report_request(char *bw_report) if (strcmp(bw_report, "total") == 0) return 0; - fprintf(stderr, "Requested iMC B/W report type unavailable\n"); + fprintf(stderr, "Requested iMC bandwidth report type unavailable\n"); return -1; } -- 2.39.2