Received-SPF: pass (google.com: domain of linux-kernel+bounces-208390-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <ea5c6e03-3821-4808-9681-ea5576c65391@quicinc.com>
Date: Mon, 10 Jun 2024 07:44:16 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] pwm: add missing MODULE_DESCRIPTION() macros
Content-Language: en-US
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,
        =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <ukleinek@kernel.org>,
        Shawn Guo
	<shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix
 Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
        Matthias Brugger
	<matthias.bgg@gmail.com>
CC: <linux-pwm@vger.kernel.org>, <imx@lists.linux.dev>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <linux-samsung-soc@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>,
        <kernel-janitors@vger.kernel.org>
References: <20240607-md-drivers-pwm-v1-1-27237a2bec6a@quicinc.com>
 <ca6b4ce2-4ebf-409d-b87d-2024445b9392@collabora.com>
From: Jeff Johnson <quic_jjohnson@quicinc.com>
In-Reply-To: <ca6b4ce2-4ebf-409d-b87d-2024445b9392@collabora.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 6/10/2024 1:06 AM, AngeloGioacchino Del Regno wrote:
> Il 07/06/24 18:02, Jeff Johnson ha scritto:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-imx1.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-imx27.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-intel-lgm.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-mediatek.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-pxa.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-samsung.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-spear.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-visconti.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>> This addresses all of the issues in driver/pwm
>>
>> Let me know if you want any of the individual module changes
>> segregated into separate patches.
>> ---
>>   drivers/pwm/pwm-imx1.c      | 1 +
>>   drivers/pwm/pwm-imx27.c     | 1 +
>>   drivers/pwm/pwm-intel-lgm.c | 1 +
>>   drivers/pwm/pwm-mediatek.c  | 1 +
>>   drivers/pwm/pwm-pxa.c       | 1 +
>>   drivers/pwm/pwm-samsung.c   | 1 +
>>   drivers/pwm/pwm-spear.c     | 1 +
>>   drivers/pwm/pwm-visconti.c  | 1 +
>>   8 files changed, 8 insertions(+)
>>
> 
> ..snip..
> 
>> diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
>> index 19a87873ad60..0b5d68a90e83 100644
>> --- a/drivers/pwm/pwm-mediatek.c
>> +++ b/drivers/pwm/pwm-mediatek.c
>> @@ -395,4 +395,5 @@ static struct platform_driver pwm_mediatek_driver = {
>>   module_platform_driver(pwm_mediatek_driver);
>>   
>>   MODULE_AUTHOR("John Crispin <blogic@openwrt.org>");
>> +MODULE_DESCRIPTION("MediaTek Pulse Width Modulator driver");
> 
> MediaTek SoCs have got two different PWM IPs, one of which is used exclusively
> for the Display PWM, and it is located in the DDP block.
> 
> So, there are two PWM IPs in one SoC:
>   - A general purpose PWM IP
>   - A DDP PWM IP
> 
> This driver is for the general purpose PWM IP.. so, please, can we change this
> to "MediaTek general purpose Pulse Width Modulator driver"?
> 
> After which,
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> 
>>   MODULE_LICENSE("GPL v2");
> 
Sure, I'll update these in v2