Received-SPF: pass (google.com: domain of linux-kernel+bounces-208472-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 10 Jun 2024 17:18:54 +0200
From: Nicolas Schier <nicolas@fjasle.eu>
To: Dragan Simic <dsimic@manjaro.org>
Cc: linux-kbuild@vger.kernel.org, masahiroy@kernel.org, nathan@kernel.org,
 linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
 Diederik de Haas <didi.debian@cknow.org>, stable@vger.kernel.org
Subject: Re: [PATCH v2] kbuild: Install dtb files as 0644 in Makefile.dtbinst
Message-ID: <ZmcZXuETxg_C7KI8@fjasle.eu>
References: <e1fd1b659711f59c61ec48dc43912dddccbb4d92.1717996742.git.dsimic@manjaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="1ZrVfO6RKau8OEqg"
Content-Disposition: inline
In-Reply-To: <e1fd1b659711f59c61ec48dc43912dddccbb4d92.1717996742.git.dsimic@manjaro.org>
Feedback-ID: 1174286m:1174286a9YXZ7r:1174286swy0Xjnx8o


--1ZrVfO6RKau8OEqg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 10, 2024 at 07:21:12AM +0200 Dragan Simic wrote:
> The compiled dtb files aren't executable, so install them with 0644 as th=
eir
> permission mode, instead of defaulting to 0755 for the permission mode and
> installing them with the executable bits set.
>=20
> Some Linux distributions, including Debian, [1][2][3] already include fix=
es
> in their kernel package build recipes to change the dtb file permissions =
to
> 0644 in their kernel packages.  These changes, when additionally propagat=
ed
> into the long-term kernel versions, will allow such distributions to remo=
ve
> their downstream fixes.
>=20
> [1] https://salsa.debian.org/kernel-team/linux/-/merge_requests/642
> [2] https://salsa.debian.org/kernel-team/linux/-/merge_requests/749
> [3] https://salsa.debian.org/kernel-team/linux/-/blob/master/debian/rules=
=2Ereal?ref_type=3Dheads#L193
>=20
> Cc: Diederik de Haas <didi.debian@cknow.org>
> Cc: stable@vger.kernel.org
> Fixes: aefd80307a05 ("kbuild: refactor Makefile.dtbinst more")
> Signed-off-by: Dragan Simic <dsimic@manjaro.org>
> ---
>=20
> Notes:
>     Changes in v2:
>       - Improved the patch description, to include additional details and
>         to address the patch submission issues pointed out by Greg K-H [4]
>       - No changes were made to the patch itself
>    =20
>     Link to v1: https://lore.kernel.org/linux-kbuild/ae087ef1715142f606ba=
6477ace3e4111972cf8b.1717961381.git.dsimic@manjaro.org/T/#u
>    =20
>     [4] https://lore.kernel.org/linux-kbuild/2024061006-ladylike-paving-a=
36b@gregkh/
>=20
>  scripts/Makefile.dtbinst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/scripts/Makefile.dtbinst b/scripts/Makefile.dtbinst
> index 67956f6496a5..9d920419a62c 100644
> --- a/scripts/Makefile.dtbinst
> +++ b/scripts/Makefile.dtbinst
> @@ -17,7 +17,7 @@ include $(srctree)/scripts/Kbuild.include
>  dst :=3D $(INSTALL_DTBS_PATH)
> =20
>  quiet_cmd_dtb_install =3D INSTALL $@
> -      cmd_dtb_install =3D install -D $< $@
> +      cmd_dtb_install =3D install -D -m 0644 $< $@
> =20
>  $(dst)/%: $(obj)/%
>  	$(call cmd,dtb_install)

Thanks for the patch.

Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>

--1ZrVfO6RKau8OEqg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEh0E3p4c3JKeBvsLGB1IKcBYmEmkFAmZnGVcACgkQB1IKcBYm
EmnNrRAAnKc299Uv4LXbaLkPY/Bi3m3PR2SVFR1zYfcuvOU2PYgYKlKv4Yx9o+Y4
52yJrRJ9em1QyAeYqL4F37dTsGZm1IzxZON7vaqKUzdBjq8LbH+cKAhvzyuhO4lB
28pVDwVhVD38ylQe6soSv2t190TpBX6diDlAnAe/8c63Ao6RJ8qA9MEDeLQxTY4T
+FTo3cRHDSAhgcmv/sYO44gd+/TPrELa5aBOsY4ohGQRKhqfa4G3gceRuz6GaJt3
QK3GmrEOk6GH6zxo9RxB8CDyv7Bu0Q5XTjK+HLvzS6IJ53y288KU2BIDtD81T01T
OzR1f3HfjKX0komAk2Iqw8M35kOLqMVlv+39pttbT3cLEslma0vs8LGyuc1FabHd
D+3HR2+3VeWmwHbfEHzQjz73XMPSeqhSvhxfRStXwyiz0BeVpkDiz3tLEchIv2hD
XQdXCQldYlh2AKNXzZomBES30lU42BKs1lyDFCusJM+E1TIkQjWcv5xIrkyQNzES
5gPS24+8HQ9EvRXATZRNNoe7NDt1BTTKtzAZn723UnrSIbi4gfLfVl4zrxf2rQYC
uSJaoQsGqTx7SwETNHSyULk3RNvjyG2JSAv/n3+pszYhw/Qa3tcj7Jd7LWHIT4Nd
gsyro6LCplLpxICG7SLmTl8ZErRUlXBxwndXuiYkklJHLFGlcxE=
=ckY9
-----END PGP SIGNATURE-----

--1ZrVfO6RKau8OEqg--