Received-SPF: pass (google.com: domain of linux-kernel+bounces-208493-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 10 Jun 2024 18:34:39 +0300
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Stanislav Jakubek <stano.jakubek@gmail.com>
Cc: brgl@bgdev.pl, conor+dt@kernel.org, devicetree@vger.kernel.org,
	krzk+dt@kernel.org, lee@kernel.org, linus.walleij@linaro.org,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pwm@vger.kernel.org, robh@kernel.org, ukleinek@kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: mfd: Add Analog Devices ADP5585
Message-ID: <20240610153439.GX18479@pendragon.ideasonboard.com>
References: <20240608141633.2562-2-laurent.pinchart@ideasonboard.com>
 <ZmabVXaztPbp1ENV@standask-GA-A55M-S2HP>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ZmabVXaztPbp1ENV@standask-GA-A55M-S2HP>

Hi Stanislav,

On Mon, Jun 10, 2024 at 08:21:09AM +0200, Stanislav Jakubek wrote:
> Hi Laurent,
> 
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> > index 0a419453d183..91e62df4b296 100644
> > --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> > @@ -39,10 +39,6 @@ properties:
> >              # AD5110 - Nonvolatile Digital Potentiometer
> >            - adi,ad5110
> >              # Analog Devices ADP5585 Keypad Decoder and I/O Expansion
> > -          - adi,adp5585
> > -            # Analog Devices ADP5585 Keypad Decoder and I/O Expansion with support for Row5
> > -          - adi,adp5585-02
> > -            # Analog Devices ADP5589 Keypad Decoder and I/O Expansion
> >            - adi,adp5589
> >              # Analog Devices LT7182S Dual Channel 6A, 20V PolyPhase Step-Down Silent Switcher
> >            - adi,lt7182s
> 
> seems like you removed the wrong comment here? With this, ADP5589 would have
> a comment describing ADP5585.

Oops, my bad. You're absolutely right, thank you for catching this. I
will fix and send a new version.

-- 
Regards,

Laurent Pinchart