Received-SPF: pass (google.com: domain of linux-kernel+bounces-208529-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 10 Jun 2024 17:08:39 +0100
From: Mark Brown <broonie@kernel.org>
To: Witold Sadowski <wsadowski@marvell.com>
Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	devicetree@vger.kernel.org, robh@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	pthombar@cadence.com, Piyush Malgujar <pmalgujar@marvell.com>
Subject: Re: [PATCH v8 3/4] spi: cadence: Allow to read basic xSPI
 configuration from ACPI
Message-ID: <ZmclB2CMhhkasiBw@finisterre.sirena.org.uk>
References: <20240607151831.3858304-1-wsadowski@marvell.com>
 <20240607151831.3858304-4-wsadowski@marvell.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="tFL2/mw4Qy+8zVf8"
Content-Disposition: inline
In-Reply-To: <20240607151831.3858304-4-wsadowski@marvell.com>


--tFL2/mw4Qy+8zVf8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 07, 2024 at 08:18:30AM -0700, Witold Sadowski wrote:

> These changes enable reading the configurations from ACPI tables as
> required for successful probing in an ACPI UEFI environment. In the
> case of an ACPI-disabled or DTS-based environment, it will continue
> to read configurations from DTS as before.

This doesn't describe what the ACPI tables are supposed to look like or
anything, it's hard to review this...

> +#ifdef CONFIG_ACPI
> +static bool cdns_xspi_supports_op(struct spi_mem *mem,
> +				  const struct spi_mem_op *op)
> +{

> +	if (!acpi_dev_get_property(adev, "spi-tx-bus-width", ACPI_TYPE_INTEGER,
> +				   &obj)) {

> +	if (!acpi_dev_get_property(adev, "spi-rx-bus-width", ACPI_TYPE_INTEGER,
> +				   &obj)) {

Why is this Cadence specific?

>  static int cdns_xspi_of_get_plat_data(struct platform_device *pdev)
>  {
> -	struct device_node *node_prop =3D pdev->dev.of_node;
> +	struct fwnode_handle *fwnode_child;
>  	unsigned int cs;
> =20
> -	for_each_available_child_of_node_scoped(node_prop, node_child) {
> -		if (of_property_read_u32(node_child, "reg", &cs)) {
> +	device_for_each_child_node(&pdev->dev, fwnode_child) {
> +		if (!fwnode_device_is_available(fwnode_child))
> +			continue;
> +
> +		if (fwnode_property_read_u32(fwnode_child, "reg", &cs)) {
>  			dev_err(&pdev->dev, "Couldn't get memory chip select\n");
> +			fwnode_handle_put(fwnode_child);
>  			return -ENXIO;
>  		} else if (cs >=3D CDNS_XSPI_MAX_BANKS) {
>  			dev_err(&pdev->dev, "reg (cs) parameter value too large\n");
> +			fwnode_handle_put(fwnode_child);
>  			return -ENXIO;
>  		}
>  	}

This is just a general refactoring to fwnode and could be split out.

> @@ -814,19 +890,19 @@ static int cdns_xspi_probe(struct platform_device *=
pdev)
>  	if (ret)
>  		return -ENODEV;
> =20
> -	cdns_xspi->iobase =3D devm_platform_ioremap_resource_byname(pdev, "io");
> +	cdns_xspi->iobase =3D devm_platform_ioremap_resource(pdev, 0);

> -	res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "sdma");
> +	res =3D platform_get_resource(pdev, IORESOURCE_MEM, 1);

> -	cdns_xspi->auxbase =3D devm_platform_ioremap_resource_byname(pdev, "aux=
");
> +	cdns_xspi->auxbase =3D devm_platform_ioremap_resource(pdev, 2);

This causes us to ignore naming on resources, that's an ABI break for
other systems.

--tFL2/mw4Qy+8zVf8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZnJQcACgkQJNaLcl1U
h9DONwf+IthK+A65Y0/uzrZy5nJ94Lemxxb+gLFAc5sm2+gPX9IXqpbTvHkEfomj
ebbt3h2pLrKbQrl7fpIGuCTftEkfprhJ+Y50YRlrGmCH9Z2lT2vlBukGS9aopyJY
EvOJZoX1XTqKstDW0Al5zaHSHFOAg25iGn+EIaBP/HQdDMAsZ8laV9sLGwazjNML
fYmixa+7n64ePtb8GvJfPxB+ROqQifAnZWNuHw7FO/HeFOu3029Q06rHPE7ujL4e
1ylGqMFQ7Fcbc2idtGsdh4aEKsri0rLu3ulSuZ5Tbv9E/SkUIccre0OnEXUGpnYW
K4hLScVjGgCOlvsS8yG3TLD7InoEeA==
=6p+r
-----END PGP SIGNATURE-----

--tFL2/mw4Qy+8zVf8--