Received-SPF: pass (google.com: domain of linux-kernel+bounces-208554-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 10 Jun 2024 18:29:23 +0200
From: Borislav Petkov <bp@alien8.de>
To: Nikolay Borisov <nik.borisov@suse.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kees@kernel.org
Subject: Re: [PATCH] x86/boot: Remove unused function __fortify_panic()
Message-ID: <20240610162923.GGZmcp4zRfJcTghSeg@fat_crate.local>
References: <20240610115722.107780-1-nik.borisov@suse.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240610115722.107780-1-nik.borisov@suse.com>

On Mon, Jun 10, 2024 at 02:57:22PM +0300, Nikolay Borisov wrote:
> That functino is only used when the kernel is compiled with
       ^^^^^^^^^

Please introduce a spellchecker into your patch creation workflow.

Like, run the thing through the spellchecker on the system or you can
even use my python script which checks patches and can do that for you:

https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=vp

> FORTIFY_SOURCE and when the kernel proper string.h header is used. The
> decompressor code doesn't use the kernel proper header but has local
> copy which doesn't contain any fortified implementations of the various
> string functions. As such __fortify_panic can never be called from the
> decompressor so let's remove it.

Yap, might as well whack it.

We can always resurrect it if it is really needed as it is trivial.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette