Received: by 2002:ab2:784b:0:b0:1fd:adc2:8405 with SMTP id m11csp502256lqp; Mon, 10 Jun 2024 10:15:31 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWkHY1qvJspBqB0/rveFwjGIl2WPgx/AEIIRWfPgfKRTOYW8DDAmdhJIpLihTFK60XQqfzutZCK+Nh8kJn3WcBpFvM1Lv11ZjPigfeDsw== X-Google-Smtp-Source: AGHT+IEz4S9d/iBm+UxOR6Mq8gPkUTOBtQG5SDB6lLXxO7YJugvk0KXmIpex45t8Gk5pijV0cQcs X-Received: by 2002:a05:6122:458d:b0:4ea:feca:6c67 with SMTP id 71dfb90a1353d-4eb562d9a6dmr10033439e0c.16.1718039731532; Mon, 10 Jun 2024 10:15:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718039731; cv=pass; d=google.com; s=arc-20160816; b=JpyfZzMwWuV6RKoSusU0LalEd4ASllwRBZCmR+zW2iLyBmaK7Y3AAG377ZRqa99g7Z wlFsyvX+R4A8gGl3/DLzcjpz2JlXO2lnTgsHOWLDq3x6HyRcYXsR/0e2ZWpJjWqWLdJ6 b2W6pqHJqlNNb+02fNQY+68okrgAWVKxVoYVWXcJbOT8LydG+T0O60+vNtXpuNSS9Tn+ 1wfOv7Re1uJ/mFdieTwTuIfVQfc44xGcXY9aFMwPgf8dASmIZQQk+PUNe+5/nqE6vhIB 7tBdLUdN9zsnjoVcpT6kExwJY62A779p47S858Vi+2COEu6NDXdgV5V5BGUA6f1Aw7yX CScQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=tZhK0yK9PUCBDyPTcAJrUy48YWTdR49HUbCN3uazuz0=; fh=BszITJWY0GkKimOhNHOXBDJSNvEWvZRZgjRbN+RvcQQ=; b=ImU4yncwYgoddAE7cmkS8K6zxvJxnGtbpK01xSAZd4yB7UdN7TwBPsJdon2eYkTHSF rXN4R43rEYjuodIE3ASuTZ4A1Cd0ja8rbK6/tf716nN/A2LSn9/3AviT9iJoAGz/bV0c Y72HFCoPo5dkKuZVgW4ZvC+dZzb5Q0x5JC/noC0sE2roD6/jpMZvqSnSp9WOrRucRtho BcxgXaNOxiQGXWeY/7DzCWJHYxkb7xvfARAZUQh/TN6jFG1DLbaZFMt8xGtsCY/mFMMT dVHI3wEF09VLlr1lD3ai5eWvq7+TpyKsCwwA54MFv55jDRqLeanZqPtsi65fFvwTTxlW jJVA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@codeweavers.com header.s=s1 header.b=DnX772Ec; arc=pass (i=1 spf=pass spfdomain=codeweavers.com dkim=pass dkdomain=codeweavers.com dmarc=pass fromdomain=codeweavers.com); spf=pass (google.com: domain of linux-kernel+bounces-208640-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-208640-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codeweavers.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 71dfb90a1353d-4eb4ac8f306si2366590e0c.101.2024.06.10.10.15.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 10:15:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-208640-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@codeweavers.com header.s=s1 header.b=DnX772Ec; arc=pass (i=1 spf=pass spfdomain=codeweavers.com dkim=pass dkdomain=codeweavers.com dmarc=pass fromdomain=codeweavers.com); spf=pass (google.com: domain of linux-kernel+bounces-208640-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-208640-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codeweavers.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3FD521C21258 for ; Mon, 10 Jun 2024 17:15:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 11F5C145354; Mon, 10 Jun 2024 17:15:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codeweavers.com header.i=@codeweavers.com header.b="DnX772Ec" Received: from mail.codeweavers.com (mail.codeweavers.com [4.36.192.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2BC477F2F; Mon, 10 Jun 2024 17:15:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=4.36.192.163 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718039723; cv=none; b=YsXSXwMCxLfx2Y8zpyk36QUC6XDWx6WXY+dd2KnbeNV0vGvVNjzlEQOhinfgOTJpbas9V5u0I6HH2YJXXJi9ME9QNr4MXgVZIG3JYpQoFImWOgiiMzTe1T1t8ors7drKkGIEd+wDaIoHLV0hmejXtpq46j6ezHNfvATgyZo34Ak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718039723; c=relaxed/simple; bh=tZhK0yK9PUCBDyPTcAJrUy48YWTdR49HUbCN3uazuz0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TKMkTotGI9/l59H10SOz1UZ94xrFdxIR3wSgDF4Pu+b2nELB1vyKdgKyy8KKdEZhkFjTu9KJNLae0gXQ5PeK7VImHpmeNF/M4OqVdk+ug0bPLXnfyPXnAV1E0sTwfiE18nHTCCvT6Ni+/5ENB44TKZ4Kcuyy4u3iF5QDdd2iG8w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeweavers.com; spf=pass smtp.mailfrom=codeweavers.com; dkim=pass (2048-bit key) header.d=codeweavers.com header.i=@codeweavers.com header.b=DnX772Ec; arc=none smtp.client-ip=4.36.192.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=codeweavers.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codeweavers.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codeweavers.com; s=s1; h=Message-ID:Date:Subject:Cc:To:From:Sender; bh=tZhK0yK9PUCBDyPTcAJrUy48YWTdR49HUbCN3uazuz0=; b=DnX772Ecy7Sytu4dDSC25WhQIM p5J1nPDMk23g5W9HIGqwfixQXSHf83CTiGTFcbIG2EtOfYpF1nbnMN4YIecI9884NVGDBMKen38lx H5A17OKO6ibWhAVY6DtoBGmmJe3P2sjGNsycECNyftwTeT74mFPKtsqkRDQ5H7m6GxIOHmcNDK8xB f/ZPLptOxLwz897jhfiz716tUV14MPVge41NhrFJYrM3savy+WZ+fBG1fn2KHLi2FDuyp7Ht2MrjI faduXUalJ6gir2AtcAqDE1HZu5VMSRtquUGHVqLX2x+lr7mZNrNiWJLrOzYvHJvZDHBgKyJ8MSvz5 6BNpqxqA==; Received: from [10.69.139.13] (helo=uriel.localnet) by mail.codeweavers.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sGiM6-00H4i2-0f; Mon, 10 Jun 2024 11:58:50 -0500 From: Elizabeth Figura To: Peter Zijlstra Cc: Arnd Bergmann , Greg Kroah-Hartman , Jonathan Corbet , Shuah Khan , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, wine-devel@winehq.org, =?ISO-8859-1?Q?Andr=E9?= Almeida , Wolfram Sang , Arkadiusz Hiler , Andy Lutomirski , linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Randy Dunlap , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng Subject: Re: [PATCH v5 00/28] NT synchronization primitive driver Date: Mon, 10 Jun 2024 11:58:48 -0500 Message-ID: <2325658.ElGaqSPkdT@uriel> In-Reply-To: <20240519202454.1192826-1-zfigura@codeweavers.com> References: <20240519202454.1192826-1-zfigura@codeweavers.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Sunday, May 19, 2024 3:24:26=E2=80=AFPM CDT Elizabeth Figura wrote: > This patch series implements a new char misc driver, /dev/ntsync, which is > used to implement Windows NT synchronization primitives. >=20 > NT synchronization primitives are unique in that the wait functions both = are > vectored, operate on multiple types of object with different behaviour > (mutex, semaphore, event), and affect the state of the objects they wait > on. This model is not compatible with existing kernel synchronization > objects or interfaces, and therefore the ntsync driver implements its own > wait queues and locking. >=20 > This patch series is rebased against the "char-misc-next" branch of > gregkh/char-misc.git. Hi Peter, Sorry to bother, but now that the Linux merge window is closed could I request a review of this revision of the ntsync patch set, please (or a review from another locking maintainer)? I believe I've addressed all of the comments from the last review, except those which would have changed the existing userspace API (although since the driver isn't really functional yet, maybe this would have been fine to do anyway?) Thanks, Zeb