Received-SPF: pass (google.com: domain of linux-kernel+bounces-208647-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <c4e6c55e3683d72e1688751ac07a242a7e008ab7.camel@perches.com>
Subject: Re: [PATCH v2] checkpatch: really skip LONG_LINE_* when LONG_LINE
 is ignored
From: Joe Perches <joe@perches.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>, 
	linux-renesas-soc@vger.kernel.org
Cc: Andy Whitcroft <apw@canonical.com>, Dwaipayan Ray
 <dwaipayanray1@gmail.com>,  Lukas Bulwahn <lukas.bulwahn@gmail.com>, Andrew
 Morton <akpm@linux-foundation.org>,  linux-kernel@vger.kernel.org
Date: Mon, 10 Jun 2024 10:25:29 -0700
In-Reply-To: <20240610150420.2279-2-wsa+renesas@sang-engineering.com>
References: <20240610150420.2279-2-wsa+renesas@sang-engineering.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-06-10 at 17:02 +0200, Wolfram Sang wrote:
> For a printout to happen, all types must be set to "show". So, AND is nee=
ded
> for the flags, not OR, if we want to ignore something.

Right.  One day I'll learn...

As the comment above the block shows:

47e0c88b37a5c3 (Joe Perches        2015-06-25 15:02:57 -0700 3821) # if LON=
G_LINE is ignored, the other 2 types are also ignored

Acked-by: Joe Perches <joe@perches.com>

>=20
> Fixes: 47e0c88b37a5 ("checkpatch: categorize some long line length checks=
")
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>=20
> Change since v1:
> * removed now unneeded pair of braces (Thanks, Geert!)
> * reworded commit message
>=20
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2b812210b412..375749e0a174 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3858,7 +3858,7 @@ sub process {
>  			}
> =20
>  			if ($msg_type ne "" &&
> -			    (show_type("LONG_LINE") || show_type($msg_type))) {
> +			    show_type("LONG_LINE") && show_type($msg_type)) {
>  				my $msg_level =3D \&WARN;
>  				$msg_level =3D \&CHK if ($file);
>  				&{$msg_level}($msg_type,