Received-SPF: pass (google.com: domain of linux-kernel+bounces-208670-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 10 Jun 2024 10:44:42 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, <nvdimm@lists.linux.dev>
CC: <linux-kernel@vger.kernel.org>, Greg Kroah-Hartman
	<gregkh@linuxfoundation.org>, Dan Williams <dan.j.williams@intel.com>,
	"Vishal Verma" <vishal.l.verma@intel.com>, Dave Jiang <dave.jiang@intel.com>,
	"Ira Weiny" <ira.weiny@intel.com>
Subject: Re: [PATCH] nvdimm: make nd_class constant
Message-ID: <66673b8a1ec86_12552029457@dwillia2-xfh.jf.intel.com.notmuch>
References: <2024061041-grandkid-coherence-19b0@gregkh>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <2024061041-grandkid-coherence-19b0@gregkh>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7ZxeuX1pxM7mKD0PnUGhlA4srxY78mfmy/WjV8Deb3qbPjMu+lVNciqiApLX?=
 =?us-ascii?Q?qkfcG57c//6n6DkApn0VHDlM6D2MM//yJ55R63p8EsND6ihv2ZVlIex7q7oG?=
 =?us-ascii?Q?D+MWiFzIbKcEFbZ/8rgEywDzqs/6o7DUjDSo+z3uLBsFafeaWk5J+NseiuZM?=
 =?us-ascii?Q?BmWiQ3eMQia4Nm86e/dbDuKvu35KypJzcV1XQ3a7lgW4405Bz61KlLtIbG/o?=
 =?us-ascii?Q?nRYNDVLqvWFeP4i8lU+JSqI9DY4uVc9HvG/Cc98VVQRVC6s3fR0Pnm/XMrwd?=
 =?us-ascii?Q?/C2yBKlZvVaf8fH9E5fkF9FUObdOUL/EFxpcPIW7oZZSM+IkSyCG3o0/h+nO?=
 =?us-ascii?Q?QlmfWrNt9Fu/p+d2gpJmX9hhPlprM/hIbkayBDplXZm2vl6DqiYMEUietZt3?=
 =?us-ascii?Q?S9TQL4oS+Mt/3lUwVlMeQue/ERkvXLasDjJYLkGkA9xLvmxemxsyH9DdNdZb?=
 =?us-ascii?Q?yxIeK9ZO1JTwRhXI5AntpnIocemyn66SAhbHC4b3km9+MtthnQQ9tlGezJ2W?=
 =?us-ascii?Q?frPaOFAF3bA9Dxc/M8jaW6SaRoM4OhtOQj1LV/yFjoWmxqWyMMhE5ebE7Dx/?=
 =?us-ascii?Q?PbYRLUyXG3qbLnajJmMUxNvjncgUB7JV0G4bZ5t8N6+58q0lui1Iw00kSIHG?=
 =?us-ascii?Q?sURdaalGh0yxAIDa/zVeEk4VwMyU1YQq+e2FLXDtF/fNb20Lrrss4bxrqMjf?=
 =?us-ascii?Q?DlEBRVt/FypXswgQ54DFgndil8qZtjz43eoVzMg2QUCOR6ZUYrsZuBB/i80e?=
 =?us-ascii?Q?ZAMtqFPRC+VyeJpqAM48lQ+OmuwtF3DXQUGwBnnOoORj2YYBKBU34bfXqrdb?=
 =?us-ascii?Q?EMix6UMbOhBarQ7fq/SXJof08uvBPF2W+pWUNlblPVVThwBhq0b3CC0IQFX5?=
 =?us-ascii?Q?xF8HjfjaBdTBgurRVHFofLplB62a99vvw0vD4WcU3sCid2doIQMATz5zSFqY?=
 =?us-ascii?Q?m3zJYSI+WKNj+/kUwOCSIEHHP9hX8iD1YWoB2FnYX5WJf404XQ+K+Ua9zgs5?=
 =?us-ascii?Q?W79vwFKPFXBZDm5p4RGPeGTlp2IaD7kVBYVDQUFLW4PrF1bYtC/DKfvU2aNZ?=
 =?us-ascii?Q?yYfiDozqdBELg7o34241nPoFTEBeIxLx+4LZN+YNKr/0clvsygtgyloTNGJD?=
 =?us-ascii?Q?8b88Bu76kzTLKsNKER2lrr4XZ+zw/hECx6G6nkymNwZztpf8RSfiul8LH06L?=
 =?us-ascii?Q?pM19lzoqgteQVm5TTdCATR61Q1tiH534HND4maRd3kpw2V98pvGFUnplM4nX?=
 =?us-ascii?Q?PQIGHwpl9uXjTt36BwBzibaZh30TAg56hE4uaFstuNkgjBVyHN6zhTc8ovVH?=
 =?us-ascii?Q?Bz9okOJwYm1Ryj5vUh7qjqAeaN5BDlrT+M7s/X99otAD+yJV9oFrzG6VcYAC?=
 =?us-ascii?Q?9bqOSH2lajlaGOeqNUXZPRKw2+oABtebJ8Mx5JAsifgAgrUL6RQNCyXdcqtr?=
 =?us-ascii?Q?flhb2/ngFA1xFBI5A0cQJSeGoLUDW6idGPTw6MMC+XQ3UnTkZ0twYUAw92hV?=
 =?us-ascii?Q?jG0Hr2JcRw+7N7UVfmZs2Z6yotQtoynT39uzWb9FWmBe1fBT9ZpMGQHVMqQx?=
 =?us-ascii?Q?Nl2FwMXk400nlOrgWDouLDRjjUzt9e9oIrOBN+uq6x1bnp+DiVLrusxZ86Lh?=
 =?us-ascii?Q?TQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 40d99d1a-0b8b-4f35-12eb-08dc8975038f
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2024 17:44:44.5042
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x2vxUPZrOLYi/6TqKmiFLUg5q3sZNj3Mk960susWbbNphTWdsTUbhCXrw////k/rdw2NqPwmAU+CZdHe8LbOJtL8MVAOGQOG1k+cKesO4Tk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6296
X-OriginatorOrg: intel.com

Greg Kroah-Hartman wrote:
> Now that the driver core allows for struct class to be in read-only
> memory, we should make all 'class' structures declared at build time
> placing them into read-only memory, instead of having to be dynamically
> allocated at runtime.

Change looks good to me,

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

...changelog grammar tripped me up though, how about:

"Now that the driver core allows for struct class to be in read-only
memory, it is possible to make all 'class' structures be declared at
build time. Move the class to a 'static const' declaration and register
it rather than dynamically create it."