Received-SPF: pass (google.com: domain of linux-kernel+bounces-208687-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 10 Jun 2024 19:57:56 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Sam Sun <samsun1006219@gmail.com>, x86@kernel.org,
	syzkaller-bugs@googlegroups.com, xrivendell7@gmail.com
Subject: Re: [patch 2/4] jump_label: Fix concurrency issues in
 static_key_slow_dec()
Message-ID: <20240610175756.GU8774@noisy.programming.kicks-ass.net>
References: <87bk49xf15.ffs@tglx>
 <20240610124258.109097511@linutronix.de>
 <20240610124406.422897838@linutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240610124406.422897838@linutronix.de>

On Mon, Jun 10, 2024 at 02:46:36PM +0200, Thomas Gleixner wrote:

> @@ -247,20 +247,25 @@ EXPORT_SYMBOL_GPL(static_key_disable);
>  
>  static bool static_key_slow_try_dec(struct static_key *key)
>  {
> +	int v;
>  
>  	/*
> +	 * Go into the slow path if key::enabled is less than or equal than
> +	 * one. One is valid to shut down the key, anything less than one
> +	 * is an imbalance, which is handled at the call site.
> +	 *
> +	 * That includes the special case of '-1' which is set in
> +	 * static_key_slow_inc_cpuslocked(), but that's harmless as it is
> +	 * fully serialized in the slow path below. By the time this task
> +	 * acquires the jump label lock the value is back to one and the
> +	 * retry under the lock must succeed.

Harmless yes, but it really should not happen to begin with. If this
happens it means someone wants to disable a key that is in the middle of
getting enabled for the first time.

I'm tempted to want a WARN here instead. Hmm?

>  	 */
> +	v = atomic_read(&key->enabled);
> +	do {
> +		if (v <= 1)
> +			return false;
> +	} while (!likely(atomic_try_cmpxchg(&key->enabled, &v, v - 1)));
> +
>  	return true;
>  }