Received-SPF: pass (google.com: domain of linux-kernel+bounces-208728-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-515-g87b2bad5a-fm-20240604.001-g87b2bad5
Precedence: bulk
MIME-Version: 1.0
Message-Id: <8d93cdd6-379b-48e7-8a10-9df190b12623@app.fastmail.com>
In-Reply-To: <Zmcwlt6Kfpt09tKi@fedora>
References: <20240529094816.1859073-1-arnd@kernel.org>
 <ZmSi5_-4mD4AaIJW@fedora>
 <54c19328-35e2-4506-aa3a-a0b08813d873@app.fastmail.com>
 <Zmcwlt6Kfpt09tKi@fedora>
Date: Mon, 10 Jun 2024 20:25:15 +0200
From: "Arnd Bergmann" <arnd@arndb.de>
To: =?UTF-8?Q?Jos=C3=A9_Exp=C3=B3sito?= <jose.exposito89@gmail.com>
Cc: "Arnd Bergmann" <arnd@kernel.org>, "Jiri Kosina" <jikos@kernel.org>,
 "Benjamin Tissoires" <bentiss@kernel.org>,
 "Rahul Rameshbabu" <rrameshbabu@nvidia.com>,
 "Fabio Baltieri" <fabiobaltieri@chromium.org>,
 "Ivan Gorinov" <linux-kernel@altimeter.info>,
 "Johannes Roith" <johannes@gnu-linux.rocks>, linux-input@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: uclogic: avoid linking common code into multiple modules
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 10, 2024, at 18:57, Jos=C3=A9 Exp=C3=B3sito wrote:
> On Mon, Jun 10, 2024 at 08:24:51AM +0200, Arnd Bergmann wrote:
>> On Sat, Jun 8, 2024, at 20:28, Jos=C3=A9 Exp=C3=B3sito wrote:
>
> Turns out that, since the last time I checked the KUnit docs,
> we have "EXPORT_SYMBOL_IF_KUNIT" available now.
>
> I think we can use it and your final patch, without the MODULE_*
> changes, could look like:

Looks good to me, can you send that with

Reported-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Arnd Bergmann <arnd@arndb.de>

?

Feel free to take my original changelog text if that helps

     Arnd

> diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile
> index ce71b53ea6c5..e40f1ddebbb7 100644
> --- a/drivers/hid/Makefile
> +++ b/drivers/hid/Makefile
> @@ -154,10 +154,8 @@ obj-$(CONFIG_HID_WINWING)  +=3D hid-winwing.o
>  obj-$(CONFIG_HID_SENSOR_HUB)   +=3D hid-sensor-hub.o
>  obj-$(CONFIG_HID_SENSOR_CUSTOM_SENSOR) +=3D hid-sensor-custom.o
>=20
> -hid-uclogic-test-objs          :=3D hid-uclogic-rdesc.o \
> -                                  hid-uclogic-params.o \
> -                                  hid-uclogic-rdesc-test.o
> -obj-$(CONFIG_HID_KUNIT_TEST)   +=3D hid-uclogic-test.o
> +hid-uclogic-test-objs          :=3D hid-uclogic-rdesc-test.o
> +obj-$(CONFIG_HID_KUNIT_TEST)   +=3D hid-uclogic.o hid-uclogic-test.o
>=20
>  obj-$(CONFIG_USB_HID)          +=3D usbhid/
>  obj-$(CONFIG_USB_MOUSE)                +=3D usbhid/
> diff --git a/drivers/hid/hid-uclogic-rdesc.c b/drivers/hid/hid-uclogic=
-rdesc.c
> index b6dfdf6356a6..6c7a90417569 100644
> --- a/drivers/hid/hid-uclogic-rdesc.c
> +++ b/drivers/hid/hid-uclogic-rdesc.c
> @@ -17,6 +17,7 @@
>  #include "hid-uclogic-rdesc.h"
>  #include <linux/slab.h>
>  #include <asm/unaligned.h>
> +#include <kunit/visibility.h>
>=20
>  /* Fixed WP4030U report descriptor */
>  __u8 uclogic_rdesc_wp4030u_fixed_arr[] =3D {
> @@ -1242,3 +1243,4 @@ __u8 *uclogic_rdesc_template_apply(const __u8=20
> *template_ptr,
>=20
>         return rdesc_ptr;
>  }
> +EXPORT_SYMBOL_IF_KUNIT(uclogic_rdesc_template_apply);
>
> I hope that helps,
> Jose