Received: by 2002:ab2:715a:0:b0:1fd:c064:50c with SMTP id l26csp47745lqm; Mon, 10 Jun 2024 12:13:54 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVrmStsdxOUaPbM6HrO3qzSOkx+AS152j/SxezQClnDDUoDsuFW6LgmckfZPPTLsc05B0BFgPXtv4rHzNXWr1TuWqadUUfm3uH0UHfD0A== X-Google-Smtp-Source: AGHT+IGJRoCftPPc7edMjRocx4AEsG1jxAFcAo83Ketd55gMXs2z4doSuRL9D/K6VhLtJKFfW7mr X-Received: by 2002:a9d:65c8:0:b0:6f9:5dbf:d3b5 with SMTP id 46e09a7af769-6f95dbfeb28mr9553028a34.12.1718046834152; Mon, 10 Jun 2024 12:13:54 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718046834; cv=pass; d=google.com; s=arc-20160816; b=yqBwb67KZcRrs/BVQ3NimQVxSFm4+hYCoOe5YegylijnIdHFXas051faq1BM2FhnzJ 59TssnN0Im4t8fxNncPGHYOLjD2DWNXIKwWd/PWTquSIifyu6t6DfLKrTEKB6fVmBfBA ndjjrh1MMsPllKi/8/rUqJiSTa4C9V4w/4ThhK5jCAtBYpyWF1kmAP7Un3iokN0FCjRk RSQqw2E7+87rKRHNdTZsQDigkOsUeRWCIt5HqhM+ZF/8HNhi/nH4RI39vW+ZB+6o3wR/ CR8SqOV+dCVTA6TOh7XQ0FHDuawQ4eeZx9SL1kTQndoMIlAQBi1aqmToz+TYTOH2YYtk waKA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=AYNYny02sf2EkWpNfBeMRhNn7kSp/uaRJn+SOxkY1hY=; fh=7cxaWySUnOx6q8j19BfLsCOyq9wYEogFxXgMj9lJPQo=; b=MME7HBnwKmpQtwf4rGKccVUcBNaeCyfcnnW5mhSYFBQuESHTdpQMT6wmU61MwlsIeP 63f1gXEDI04mHF1CqleT3vQ2kZHBfcT3wnOoAY/UTuJr31PERj48YZChGAf0/ttP7chd nYsBwlr55l8ylosIMy75U96m29zk4Gh4r0LYCwY2pnBYehYmPI2mLdI0tmomoW94wLXz AAKzPGh0aZAL+cUrNf71vFRv0Ws/KGU+5O0SYefaNQDro8kU3njN8wmtUeI1VTgBGpWF vjQ8O2ex8QajLbKNjW7Cq0rNEM1O+9GfZptyOd2IhL7VlM4Hacrnhs17rRYplLTakGkn Wnmg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=5aP73+kw; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-208776-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-208776-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 6a1803df08f44-6b06cb32f51si60904646d6.278.2024.06.10.12.13.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 12:13:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-208776-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=5aP73+kw; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-208776-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-208776-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id DCBF51C21EB0 for ; Mon, 10 Jun 2024 19:13:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E8E9614D6E4; Mon, 10 Jun 2024 19:13:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="5aP73+kw" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FBF81B5A4; Mon, 10 Jun 2024 19:13:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718046822; cv=none; b=MHFZ29rl9l9/HbIFxRMDePiOlm0mXb5srnzAaxO6pL0kr3i5T5j6lFpRyiLzdtSxHw5Vsu/Re+0hRYEMffF+GOJBL24np/praDWpAF6bBlcMftlXAdLXxo3lZPE29BzEOTryfZUKK2RySup4yQWCN+KnloDPqd3fp+o4+kIIKRI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718046822; c=relaxed/simple; bh=AIikY8Zt4bR3WdbmPQmzJMiu+nURhz3vU1h42i2It0I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KvbgFSUUqfiEMXvMzzJUYUYZcZBFoZYcaNUaL85EdCLrtiy3oxuqYR5PTbLvVQPUFZ3UGIV3BJMI9rS6X35AX9jT0NELgjA9a3eqjJbPOfLk9QqQaYMnGkrj4X4zzwCbShB0jnEIOdQ9xxyrxoSRxDeGl5WG3qzZbqDwfQrF4cM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=5aP73+kw; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=AYNYny02sf2EkWpNfBeMRhNn7kSp/uaRJn+SOxkY1hY=; b=5a P73+kwPC10IrXJyX47Q3y2/DDRLl3LzwAvE1iPPwgvRDwSlXSa0qbWvy8BvHwQTJx3hF5w5Ih49LF +EpWVFu+27YFXsiJhwxwfGh6U5MDW4I+wO0TQNc6zul41IFLBwsmKlRuAgLhmmDza2in5raQCWmUC 6074SkGHwoJWRIE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sGkSV-00HK3I-QV; Mon, 10 Jun 2024 21:13:35 +0200 Date: Mon, 10 Jun 2024 21:13:35 +0200 From: Andrew Lunn To: =?iso-8859-1?B?Q3Pza+FzLA==?= Bence Cc: imx@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Wei Fang , Shenwei Wang , Clark Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH v2] net: fec: Add ECR bit macros, fix FEC_ECR_EN1588 being cleared on link-down Message-ID: <46892275-619c-4dfb-9214-3bbb14b78093@lunn.ch> References: <20240607081855.132741-1-csokas.bence@prolan.hu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240607081855.132741-1-csokas.bence@prolan.hu> On Fri, Jun 07, 2024 at 10:18:55AM +0200, Cs?k?s, Bence wrote: > FEC_ECR_EN1588 bit gets cleared after MAC reset in `fec_stop()`, which > makes all 1588 functionality shut down on link-down. However, some > functionality needs to be retained (e.g. PPS) even without link. I don't know much about PPS. Could you point to some documentation, list email etc, which indicated PPS without link is expected to work. Please also Cc: Richard Cochran for changes like this. Thanks Andrew