Received-SPF: pass (google.com: domain of linux-kernel+bounces-208775-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 10 Jun 2024 12:11:11 -0700
From: Kees Cook <kees@kernel.org>
To: Ivan Orlov <ivan.orlov0322@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Vitor Massaru Iha <vitor@massaru.org>,
	Brendan Higgins <brendan.higgins@linux.dev>,
	David Gow <davidgow@google.com>, Rae Moar <rmoar@google.com>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	kunit-dev@googlegroups.com, linux-hardening@vger.kernel.org
Subject: Re: [PATCH 2/2] usercopy: Convert test_user_copy to KUnit test
Message-ID: <202406101209.1B76564DC@keescook>
References: <20240519190422.work.715-kees@kernel.org>
 <20240519191254.651865-2-keescook@chromium.org>
 <e384af13-ca63-4847-a84d-5957abd5d903@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e384af13-ca63-4847-a84d-5957abd5d903@gmail.com>

On Wed, May 29, 2024 at 01:17:35PM +0100, Ivan Orlov wrote:
> On 5/19/24 20:12, Kees Cook wrote:
> >   #define test(condition, msg, ...)					\
> >   ({									\
> >   	int cond = (condition);						\
> >   	if (cond)							\
> > -		pr_warn("[%d] " msg "\n", __LINE__, ##__VA_ARGS__);	\
> > +		KUNIT_EXPECT_FALSE_MSG(test, cond, msg, ##__VA_ARGS__);	\
> >   	cond;								\
> >   })
> It looks like the 'test' macro is not used anymore, so probably it should be
> removed.

Oops, yes. Thanks!

> > +static int usercopy_test_init(struct kunit *test)
> > +{
> > +	struct usercopy_test_priv *priv;
> > +	unsigned long user_addr;
> > -	if (ret == 0) {
> > -		pr_info("tests passed.\n");
> > -		return 0;
> > -	}
> > +	priv = kunit_kzalloc(test, sizeof(*priv), GFP_KERNEL);
> > +	if (!priv)
> > +		return -ENOMEM;
> 
> Should the check be done with KUNIT_ASSERT_NOT_ERR_OR_NULL here as well, as
> it is done with priv->kmem?

Yes, that's much more idiomatic. I'll adjust this too.

> Other than that,
> 
> Tested-by: Ivan Orlov <ivan.orlov0322@gmail.com>

Thanks!

-- 
Kees Cook