Received: by 2002:ab2:715a:0:b0:1fd:c064:50c with SMTP id l26csp52377lqm; Mon, 10 Jun 2024 12:22:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXUai92Y+DT4jYBzNenH0mdDwGV/+pu2klRVEfPUOKnkbg3IGsZf1zi+Hv5Jnqli9pi+0GArcWO5neGpxsLv8g47NftQT64k9u1t1dSpA== X-Google-Smtp-Source: AGHT+IHWDmqVWAhPkErYYZYVzutCpQcHtKP30BiVgzEhiuwo/S9K6UB07itkNxtWnm3S9X03AYCy X-Received: by 2002:a05:622a:1483:b0:440:25d4:805e with SMTP id d75a77b69052e-44041cd4a57mr129784831cf.65.1718047359514; Mon, 10 Jun 2024 12:22:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718047359; cv=pass; d=google.com; s=arc-20160816; b=qD/z7aKbKlknlYUbeDo732r6vqPoPGL/Qr9mGrLXuWznxmxlF9zJZa9gesyGxbDfPg +jmC1k73s2o04xEXDP74ZTq2v+k8SJ6H6/pvLn1f51+Ze5zsVJGGWabDTwoHRWfzIh8M uvU+5vJQ4HBt5xVZ6HbjjSAsp2Bn8VjjeSculpg4r4RE2IRLfuneOtTlXVwZ/c4aqQ0k cs81ZluEDoSrOWQ2BkWkxX2xqV5VGX1ifwLmGw4DGIDw28dTjk9b8b27YFYhFQzOHeVv m4q0qUfdYpZFNk6hAWuJmyNauzb3hdnu+Fb09sklCLve7rVcQFrfBlPntNYmskNwQm2h 2LbQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=qBntJYSpEKXr0eXUi25C7jSWwKZG1Ap3DYhbE+QGCrQ=; fh=N+k8Z8XGoZ6btXkf8DpZwTgPel378+a2Ixe6Qp4lIHA=; b=jH172nBFLRx3EKsnijtI6WmlQp4XkExNTMFuKwvephzp3N/81NI9eX1NcwcnzxlqHF G1Qe/E/OPYuAJzT8Guu+Vt3Jp02gLt9u0ZZGpd7JBIFXh0/zEl1M6M7zh/nNfHmoLzfr MHrVv32xKmSYzFKdjVQhckvS4ZObWeAjt90j2tziQnVYx3GFYSe2+ulmBCc8yq8P249V uE7PVmVn4k7ZFAFeHfmP7X8fOsB35B45x7Ymv+c9Tb1H6h8brJcc+3fNAhHRNC9MoNuA DlgLfSsjX2C9GwcnHqOMA3wp9HGcAfAN/I7QGAzqKucDR6nXYl7+oV6Ltwo6AJ37jslR /9Tw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@layalina-io.20230601.gappssmtp.com header.s=20230601 header.b=yu4AdpGP; arc=pass (i=1 spf=pass spfdomain=layalina.io dkim=pass dkdomain=layalina-io.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-208790-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-208790-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d75a77b69052e-4405c235e8bsi61658821cf.137.2024.06.10.12.22.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 12:22:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-208790-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@layalina-io.20230601.gappssmtp.com header.s=20230601 header.b=yu4AdpGP; arc=pass (i=1 spf=pass spfdomain=layalina.io dkim=pass dkdomain=layalina-io.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-208790-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-208790-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2E7451C216C4 for ; Mon, 10 Jun 2024 19:22:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0334714F9C8; Mon, 10 Jun 2024 19:21:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=layalina-io.20230601.gappssmtp.com header.i=@layalina-io.20230601.gappssmtp.com header.b="yu4AdpGP" Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7B1B1DDD1 for ; Mon, 10 Jun 2024 19:21:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718047306; cv=none; b=E/j0wvWltLEhux40pufwiUCM6CkU5uGMTQ2e+yXPkvq6WLL1Uvd9+kqFPO35PMa42JhoK1pN/E0mf4FF/K4GjIPEHKUKUIOkNbyPInMgNpVk4mi0FzsmOYsy1NEinOHkfxqUf2mYK25PBTPHMuxwJdCMvPpQXc3JDnZgwe0qsi8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718047306; c=relaxed/simple; bh=sRPSbauIiYaJtGBZEqHyUjPGKFPTk5/HdK22FraU4hI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SyvPxH6mEjCWc3fkDjXrAMrOEiFjvCc9DDtwgvNsA0TTvlInpbUiYKiuAANxxLGvM2V9h4mO/vd/fkGawqcBCCLwvWCqJaOy47ivLvaRazyRYZmfB6RmrV7VBM/KsTibpsU0KVzI+eEsX0w+mXhKpjvS+DtWO8vVscdtnn8Fjws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=layalina.io; spf=pass smtp.mailfrom=layalina.io; dkim=pass (2048-bit key) header.d=layalina-io.20230601.gappssmtp.com header.i=@layalina-io.20230601.gappssmtp.com header.b=yu4AdpGP; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=layalina.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=layalina.io Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4217990f8baso22835655e9.2 for ; Mon, 10 Jun 2024 12:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=layalina-io.20230601.gappssmtp.com; s=20230601; t=1718047303; x=1718652103; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qBntJYSpEKXr0eXUi25C7jSWwKZG1Ap3DYhbE+QGCrQ=; b=yu4AdpGPnGacd6cwDL/DtvxZdGK7JNjq6XhqddfsUOrB9ei6PFiw9i+1x+XCuAeY0p 23+RU+W+zLREQV9HwK8KBYtOrpYNJy5UavMnUMZ/lIFargodujaMzg5YBo4gNcRouLS/ dCAlI/AXRrRr0hte6iC79QKf3wcx3kr2qhDRxVpen/FvdMBkVLz9OHmV2PskG7TBXJSd G2hrJubxJ6oaXs0SFJHQh2ixFBQoB45sPXW/GLH70gWUT6UrH++tnKjk8dJd/vVVHQqY NbIZTKoJ8TGVZeQq4JCT6ZFSPDc1yGd6MVliszLBXrJ56JwkDHsOrv3Kvkr4jv+eSVF0 pgkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718047303; x=1718652103; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qBntJYSpEKXr0eXUi25C7jSWwKZG1Ap3DYhbE+QGCrQ=; b=ZXgnXXmUcWIGQZzYeXlnsh5PsRHKeNUNNCgjYOBd6bTNr6FPt+kyzHoQkPEYM75Phk KGjM3MV2CnMM6OhePcryHIB6J2CM/7OzQ6DRb/NzNtIs70wFR5uESBSjqB5kAj2KI/n6 gbnfhgwYGQsaqucTaWFqI/DiV/axZ1apANj+3lKBiIpz5nHViALuiMsSIaf5eJYtH2PE 900OyYcfCn45qT1Y27u9rV336pCW21tUz+KufDHU77z2qlNhqpAkEitOcSDJOFWB3FO/ XyIKWz5LISygoImyH3UhvaesF7ih4ay8o8n21KHHS//GeIf4D2g3yhYlrco0nbIbZsR/ SIZA== X-Forwarded-Encrypted: i=1; AJvYcCWokY/v2RxcduiQmgCXLalWKcVbdWchmML0u4NlnLv0RPwezcRF3bNppC6gq05GsnUHqMxAj1PaRbWJ0O5iQAPkNJqpgRMzBzIq773Z X-Gm-Message-State: AOJu0YwwqZR8LnXIqcrtI+mFOvaLbyltD6Lon1OQggXbQ/0XZOGyXdDj 9Ml0FQIwTwUeU9IzeLE3TfZ/vsUUZv43M7CTocAkYx1gd6FdmGlHZWwylHOfzFs= X-Received: by 2002:a05:600c:138e:b0:421:2df2:2850 with SMTP id 5b1f17b1804b1-42164a21d60mr105810015e9.31.1718047303182; Mon, 10 Jun 2024 12:21:43 -0700 (PDT) Received: from airbuntu (host81-157-90-255.range81-157.btcentralplus.com. [81.157.90.255]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4218193b0c0sm65469985e9.31.2024.06.10.12.21.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 12:21:42 -0700 (PDT) Date: Mon, 10 Jun 2024 20:21:41 +0100 From: Qais Yousef To: Daniel Bristot de Oliveira Cc: Sebastian Andrzej Siewior , Ingo Molnar , Peter Zijlstra , Juri Lelli , Steven Rostedt , Vincent Guittot , Thomas Gleixner , Alexander Viro , Christian Brauner , Andrew Morton , Jens Axboe , Metin Kaya , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, Phil Auld Subject: Re: [PATCH v5 1/2] sched/rt: Clean up usage of rt_task() Message-ID: <20240610192141.dibvhzrvx7hacvd7@airbuntu> References: <20240604144228.1356121-1-qyousef@layalina.io> <20240604144228.1356121-2-qyousef@layalina.io> <20240605093246.4h0kCR67@linutronix.de> <20240605132454.cjo4sjtybaeyeuze@airbuntu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On 06/05/24 16:07, Daniel Bristot de Oliveira wrote: > On 6/5/24 15:24, Qais Yousef wrote: > >>> But rt is a shortened version of realtime, and so it is making *it less* > >>> clear that we also have DL here. > >> Can SCHED_DL be considered a real-time scheduling class as in opposite > >> to SCHED_BATCH for instance? Due to its requirements it fits for a real > >> time scheduling class, right? > >> And RT (as in real time) already includes SCHED_RR and SCHED_FIFO. > > Yeah I think the usage of realtime to cover both makes sense. I followed your > > precedence with task_is_realtime(). > > > > Anyway. If people really find this confusing, what would make sense is to split > > them and ask users to call rt_task() and dl_task() explicitly without this > > wrapper. I personally like it better with the wrapper. But happy to follow the > > crowd. > > For me, doing dl_ things it is better to keep them separate, so I can > easily search for dl_ specific checks. > > rt_or_dl_task(p); I posted a new version with this suggestion as the top patch so that it can be shredded more :-) Thanks for having a look. Cheers -- Qais Yousef