Received-SPF: pass (google.com: domain of linux-kernel+bounces-208801-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <6959494a-98ba-4ccf-973c-14d079b76f27@kernel.org>
Date: Mon, 10 Jun 2024 22:31:07 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 1/7] arm64: dts: ti: am62p: Rename am62p-{}.dtsi to
 am62p-j722s-common-{}.dtsi
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: nm@ti.com, vigneshr@ti.com, afd@ti.com, kristo@kernel.org,
 robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, u-kumar1@ti.com, danishanwar@ti.com,
 srk@ti.com
References: <20240604085252.3686037-1-s-vadapalli@ti.com>
 <20240604085252.3686037-2-s-vadapalli@ti.com>
 <92af5f36-0c21-4b6e-adde-fcf21b540291@kernel.org>
 <902f024a-b0a1-4a0a-94e2-7cec064a91c6@ti.com>
Content-Language: en-US
From: Roger Quadros <rogerq@kernel.org>
In-Reply-To: <902f024a-b0a1-4a0a-94e2-7cec064a91c6@ti.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Siddharth,

On 07/06/2024 14:28, Siddharth Vadapalli wrote:
> On Thu, Jun 06, 2024 at 10:51:27AM +0300, Roger Quadros wrote:
> 
> [...]
> 
>>>  5 files changed, 10 insertions(+), 7 deletions(-)
>>>  rename arch/arm64/boot/dts/ti/{k3-am62p-main.dtsi => k3-am62p-j722s-common-main.dtsi} (99%)
>>>  rename arch/arm64/boot/dts/ti/{k3-am62p-mcu.dtsi => k3-am62p-j722s-common-mcu.dtsi} (98%)
>>>  rename arch/arm64/boot/dts/ti/{k3-am62p-wakeup.dtsi => k3-am62p-j722s-common-wakeup.dtsi} (97%)
>>>  rename arch/arm64/boot/dts/ti/{k3-am62p.dtsi => k3-am62p-j722s-common.dtsi} (97%)
>>
>> This is not correct.
>> If J722 has different CBASS components than AM62p then we should leave k3-am62p.dtsi
>> as it is and introduce a new k3-j722.dtsi with relevant CBASS components.
> 
> Roger,
> 
> The existing hierarchy prior to this series is as follows:
> k3-am62p.dtsi = k3-am62p-main.dtsi + k3-am62p-mcu.dtsi +
> 		k3-am62p-wakeup.dtsi + k3-am62p-thermal.dtsi + <delta-1>
> k3-am62p5.dtsi = k3-am62p.dtsi + <delta-2>
> k3-j722s.dtsi = k3-am62p5.dtsi + <delta-3>
> k3-j722s-evm.dts = k3-j722s.dtsi + <detla-4>
> 
> Based on your suggestion, you seem to propose the following hierarchy:
> k3-am62p-{main,mcu,thermal,wakeup}.dtsi = AM62P specific data
> k3-am62p.dtsi = k3-am62p-j722s-common-main.dtsi +
> 		k3-am62p-j722s-common-mcu.dtsi +
> 		k3-am62p-j722s-common-wakeup.dtsi +
> 		k3-am62p-j722s-common-thermal.dtsi +
> 		k3-am62p-{main,mcu,thermal,wakeup}.dtsi +
> 		<delta-5>
> k3-am62p5.dtsi = k3-am62p.dtsi + <delta-2>
> k3-j722s-{main,mcu,thermal,wakeup}.dtsi = J722S specific data
> k3-j722s.dtsi = k3-am62p-j722s-common-main.dtsi +
> 		k3-am62p-j722s-common-mcu.dtsi +
> 		k3-am62p-j722s-common-wakeup.dtsi +
> 		k3-am62p-j722s-common-thermal.dtsi +
> 		k3-j722s-{main,mcu,thermal,wakeup}.dtsi +
> 		<delta-6>

What is the equivalent of k3-am62p5.dtsi here?
That should contain k3-j722s.dtsi + CPU and OPP stuff.

I suppose it should be named specific to the SoC variant part number?

> k3-j722s-evm.dts = k3-j722s.dtsi + <delta-4>
> 
> Please let me know whether the above organization of files matches what you
> expect it to look like. I will post the v6 series based on your feedback.
> 
> Regards,
> Siddharth.

-- 
cheers,
-roger