Received-SPF: pass (google.com: domain of linux-kernel+bounces-208800-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Subject: Re: [PATCH net-next 2/5] sfc: use
 flow_rule_is_supp_enc_control_flags()
To: =?UTF-8?Q?Asbj=c3=b8rn_Sloth_T=c3=b8nnesen?= <ast@fiberby.net>,
 netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 Paolo Abeni <pabeni@redhat.com>, Martin Habets <habetsm.xilinx@gmail.com>,
 linux-net-drivers@amd.com, Saeed Mahameed <saeedm@nvidia.com>,
 Leon Romanovsky <leon@kernel.org>, Tariq Toukan <tariqt@nvidia.com>,
 linux-rdma@vger.kernel.org, Jesse Brandeburg <jesse.brandeburg@intel.com>,
 Tony Nguyen <anthony.l.nguyen@intel.com>, intel-wired-lan@lists.osuosl.org,
 Louis Peens <louis.peens@corigine.com>, oss-drivers@corigine.com,
 linux-kernel@vger.kernel.org, Davide Caratti <dcaratti@redhat.com>,
 i.maximets@ovn.org
References: <20240609173358.193178-1-ast@fiberby.net>
 <20240609173358.193178-3-ast@fiberby.net>
From: Edward Cree <ecree.xilinx@gmail.com>
Message-ID: <07b7f432-bb9a-1285-2431-0f5d2232b0eb@gmail.com>
Date: Mon, 10 Jun 2024 20:31:08 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240609173358.193178-3-ast@fiberby.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit

On 09/06/2024 18:33, Asbjørn Sloth Tønnesen wrote:
> Change the existing check for unsupported encapsulation control flags,
> to use the new helper flow_rule_is_supp_enc_control_flags().
> 
> No functional change, only compile tested.
> 
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>

Acked-by: Edward Cree <ecree.xilinx@gmail.com>

> ---
>  drivers/net/ethernet/sfc/tc.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sfc/tc.c b/drivers/net/ethernet/sfc/tc.c
> index 9d140203e273a..0d93164988fc6 100644
> --- a/drivers/net/ethernet/sfc/tc.c
> +++ b/drivers/net/ethernet/sfc/tc.c
> @@ -387,11 +387,8 @@ static int efx_tc_flower_parse_match(struct efx_nic *efx,
>  		struct flow_match_control fm;
>  
>  		flow_rule_match_enc_control(rule, &fm);
> -		if (fm.mask->flags) {
> -			NL_SET_ERR_MSG_FMT_MOD(extack, "Unsupported match on enc_control.flags %#x",
> -					       fm.mask->flags);
> +		if (flow_rule_has_enc_control_flags(fm.mask->flags, extack))
>  			return -EOPNOTSUPP;
> -		}
>  		if (!IS_ALL_ONES(fm.mask->addr_type)) {
>  			NL_SET_ERR_MSG_FMT_MOD(extack, "Unsupported enc addr_type mask %u (key %u)",
>  					       fm.mask->addr_type,
>