Received-SPF: pass (google.com: domain of linux-kernel+bounces-208827-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <e4b83900-2012-4cd4-8461-aad11b714745@amd.com>
Date: Mon, 10 Jun 2024 15:04:07 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V2 2/9] PCI: Add TPH related register definition
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-doc@vger.kernel.org, netdev@vger.kernel.org, bhelgaas@google.com,
 corbet@lwn.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
 pabeni@redhat.com, alex.williamson@redhat.com, gospo@broadcom.com,
 michael.chan@broadcom.com, ajit.khaparde@broadcom.com,
 somnath.kotur@broadcom.com, andrew.gospodarek@broadcom.com,
 manoj.panicker2@amd.com, Eric.VanTassell@amd.com, vadim.fedorenko@linux.dev,
 horms@kernel.org, bagasdotme@gmail.com
References: <20240607164212.GA850739@bhelgaas>
Content-Language: en-US
From: Wei Huang <wei.huang2@amd.com>
In-Reply-To: <20240607164212.GA850739@bhelgaas>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RHpCaGdvSE56b05xRUY0SVJ6Zk54bUZRN1JXR2RtZW9tdm5qbkdPWDZRWTcv?=
 =?utf-8?B?Zis4bi8wTzA1ZHZJcFBqV3RKR01TVXN6TFVlSGE3cldvYUxvNENZaER4Q1RM?=
 =?utf-8?B?Sk9jcVNGWkZsc0NNNUFIMWhvd0dHK1VsSU5YaE0xN21ZcFRNa1o3TG5TcVdL?=
 =?utf-8?B?aWNQMm1MVjFYNjdmWW5vSzF3cUJIUXp1dEFuTVJxRnlpYnk4YTYrZkdWVDF6?=
 =?utf-8?B?ejRWMzNnRS85MjNsNGZGVzdYenBXR2JGL0h0d3R6clc0YlRock5nS0l0OHoy?=
 =?utf-8?B?N2FGQlliRGx5Tk0xSlJwMEpxLy9nTjBJSERrcS9rOXR1bFJQaG5uV3MvczN2?=
 =?utf-8?B?YlVjWkZIbXpCMDhOVS9kTXhJR3dyOFZ6SXRTdmtKeXNZb0g4dklSTXpZU2M2?=
 =?utf-8?B?eWVqa0MvYldNa2YxZkEyRHlpeXRjZkVjTStKN1c0MDZxbHNTTkM1VG5tOVlW?=
 =?utf-8?B?dk14YWVtSnc3VjlkY3lBWmQ5YThsU01LVlZLcHNOaE9XOUg4SUZaN1R4ZytO?=
 =?utf-8?B?YkxreUdmMTVVczBZd3ZUQ09BZnR1MlN5THEvTEFIZ1dURnBSckQ5R0VpNHk4?=
 =?utf-8?B?eFRFeFNOQUhuNFNVTGRLQ0dwdEJNcGwvOXUxSTdlQmF1ejR4N2VKaStTWVlo?=
 =?utf-8?B?UnB5M3M4YnZNL0RrcE9uWEE5d1B5WFhpSnNlbS9rYjBqWFpNcEZtQW5SUlk2?=
 =?utf-8?B?MDczSFkvdWp4dHMxMGR5SURzUTlDeDd0ZG53ZE53dThQOTRZaHlyd2tKL3hl?=
 =?utf-8?B?V0s3TW81ZEkwMTh4L2RRSnJUMkJnWkVwSVJsVVp1WlpSRk5yV29IME5Dc21k?=
 =?utf-8?B?dGQ2VDkwdWFJT2MzNzU0NjlFeXBMRXB5QTVxcGlZNWt5OFc1aC9KYlBHeGNE?=
 =?utf-8?B?bG5WZUZsbXNGMjh6RHhxbVcxS1NGbURrV3BubXBYSnMvQ1ErVkVRZXpnUDE3?=
 =?utf-8?B?aE1TN1RLYmhmV0hyblNJMGkrai8rN3VyWVJvRGxwa1lKZUZDNXQwYm9lN3dZ?=
 =?utf-8?B?b3NaTFJsOG1RbjNPUm16NGNKenY2TXFzUDNXVG02eThRdVZmYVdTQ2F4dE1K?=
 =?utf-8?B?WldzMUp3eG0zSG5tMUh4MS9FVDFoTFFHNEtMWHpQWTVnczVoTEhtOXFiRnhZ?=
 =?utf-8?B?TklObGplK00xZG9PNzhsSXFBTXNQVWZxQTVFOTlaVlV1QWtvU0J3SDRNVVN1?=
 =?utf-8?B?MlN4eThwbE9RaS9od2tvQ1k0UlRneFlpanE2d0hrRExoVlNWT2tJQUJOTGVj?=
 =?utf-8?B?Sy9lRFRmQlhXcnJlYXlZYzR5Q0M4UFcxMktKT045aTh3UXZZQzgxdWYrQ2Nl?=
 =?utf-8?B?bUFTcXZrMEEyYXpRNGJyMk52Z2JSSm1MU21iMTdLQk1FalVxb29EWHBmRkMr?=
 =?utf-8?B?Nk9vaHdaZ0FxS3FTWEZPSlVvcHRPeDJvVW0vajZHblJKMThHV2szTkh5Rzda?=
 =?utf-8?B?T2NFbE5EQ3AxallRUWZUbHpudmRJWjV4VDVxbnhSTWE2YklFb25zM2NtNmc4?=
 =?utf-8?B?ZWtEclExS2RsdUg2TEo2NDlwVHNtOEM5L2V3U2xVbVpvT0VMbmNPcno1cG9T?=
 =?utf-8?B?em13cWJBQ25FRkVVR3dKYjBPaER3QUd2dGk2Yk5wOW9pOFlGYUJyOHAwa20x?=
 =?utf-8?B?ZXhDU3AwcUhUQ3dMSGZJdkJqT1VlYnVyNEh5L3NyYlQrckZaTDl4UXplSGZ2?=
 =?utf-8?B?bmtCdWVVWmxyQWpuZ3duTjlpenNmMTJ6Y0NVWDZIN0YwaW5iSHFJSzZMZ1Zm?=
 =?utf-8?B?Y3BnSUZTRDhPV0d6T3NzOExYQkJqWU5BNkFQa0Z6Ri9FSnhRV1lyZE9mR0ha?=
 =?utf-8?B?QVlkaGY5bWlWTHhjdzhiUUxnYktiYWtVR0FLbmt2cXNLSGcvM2JubHR4akkr?=
 =?utf-8?B?S0czQ3lUdW8rQVZrQ1M0RGpMU0JQTU1CYVRUNzd3TERMYktyaXJvWC94dUpM?=
 =?utf-8?B?MTFmcktrRWRSU2lIZ2J2U0VKY3FWRlYrR1drbm5uUFdWWDFnUXJLei82NjNF?=
 =?utf-8?B?c0FSTXFvaitRT3F0K1JyQTJaSDQwVXlIU2t6WFlyMEhLRUdpSnA1QW5pUHQy?=
 =?utf-8?B?cllUV29LSENSa3JkMFQySXdFa3JOaFhFaFVxNU1xaVp0OGw2R3JBSVhLSFh2?=
 =?utf-8?Q?c+hUZBk3OzMT6Tov33jXSgr7w?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 76dfee72-75a7-4748-1a86-08dc89887dbb
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4877.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2024 20:04:09.9048
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nxgbcsTuqqOpj1/u32veHvAOrhGWLldUnJICX7yqWJppHJKfjbdaiZBJ8Aybqs1U
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5811


On 6/7/24 11:42, Bjorn Helgaas wrote:
> On Fri, May 31, 2024 at 04:38:34PM -0500, Wei Huang wrote:
>> Linux has some basic, but incomplete, definition for the TPH Requester
>> capability registers. Also the control registers of TPH Requester and
>> the TPH Completer are missing. This patch adds all required definitions
>> to support TPH enablement.
> 
> s/This patch adds/Add/
> 
>> +#define PCI_EXP_DEVCAP2_TPH_COMP_SHIFT		12
>> +#define PCI_EXP_DEVCAP2_TPH_COMP_NONE		0x0 /* None */
>> +#define PCI_EXP_DEVCAP2_TPH_COMP_TPH_ONLY	0x1 /* TPH only */
>> +#define PCI_EXP_DEVCAP2_TPH_COMP_TPH_AND_EXT	0x3 /* TPH and Extended TPH */
> 
> Drop the _SHIFT definitions and use FIELD_GET() and FIELD_PREP()
> instead.
> 
>>  /* TPH Requester */
>>  #define PCI_TPH_CAP		4	/* capability register */
>> +#define  PCI_TPH_CAP_NO_ST	0x1	/* no ST mode supported */
>> +#define  PCI_TPH_CAP_NO_ST_SHIFT	0x0	/* no ST mode supported shift */
> 
> Drop _SHIFT and show full register width for PCI_TPH_CAP_NO_ST, e.g.,
> 
>   #define  PCI_TPH_CAP_NO_ST 0x00000001
> 
> The existing PCI_TPH_CAP_* definitions don't follow that convention,
> but the rest of the file does, and this should match.

Will fix all of the above in V3.