Received-SPF: pass (google.com: domain of linux-kernel+bounces-208843-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <364fbb96-006f-4582-a0f8-a0f9edd50f6f@gmail.com>
Date: Mon, 10 Jun 2024 22:16:28 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 00/15] tty: serial: switch from circ_buf to kfifo
From: Ferry Toth <fntoth@gmail.com>
To: Jiri Slaby <jirislaby@kernel.org>, neil.armstrong@linaro.org,
 gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
 Al Cooper <alcooperx@gmail.com>, Alexander Shiyan <shc_work@mail.ru>,
 Alexandre Belloni <alexandre.belloni@bootlin.com>,
 Alexandre Torgue <alexandre.torgue@foss.st.com>,
 Alim Akhtar <alim.akhtar@samsung.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 "Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,
 Baolin Wang <baolin.wang@linux.alibaba.com>, Baruch Siach
 <baruch@tkos.co.il>, Bjorn Andersson <andersson@kernel.org>,
 Claudiu Beznea <claudiu.beznea@tuxon.dev>,
 "David S. Miller" <davem@davemloft.net>, Fabio Estevam <festevam@gmail.com>,
 Hammer Hsieh <hammerh0314@gmail.com>,
 =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
 Christophe Leroy <christophe.leroy@csgroup.eu>,
 Chunyan Zhang <zhang.lyra@gmail.com>, Jerome Brunet <jbrunet@baylibre.com>,
 Jonathan Hunter <jonathanh@nvidia.com>, Kevin Hilman <khilman@baylibre.com>,
 Konrad Dybcio <konrad.dybcio@linaro.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>,
 Laxman Dewangan <ldewangan@nvidia.com>,
 linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org,
 "Maciej W. Rozycki" <macro@orcam.me.uk>,
 Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
 Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
 Matthias Brugger <matthias.bgg@gmail.com>,
 Maxime Coquelin <mcoquelin.stm32@gmail.com>,
 Michael Ellerman <mpe@ellerman.id.au>, Michal Simek <michal.simek@amd.com>,
 "Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
 Nicolas Ferre <nicolas.ferre@microchip.com>,
 Nicholas Piggin <npiggin@gmail.com>, Orson Zhai <orsonzhai@gmail.com>,
 =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>,
 Patrice Chotard <patrice.chotard@foss.st.com>,
 Peter Korsgaard <jacmet@sunsite.dk>,
 Richard Genoud <richard.genoud@gmail.com>,
 Russell King <linux@armlinux.org.uk>, Sascha Hauer <s.hauer@pengutronix.de>,
 Shawn Guo <shawnguo@kernel.org>, Stefani Seibold <stefani@seibold.net>,
 Sumit Semwal <sumit.semwal@linaro.org>,
 Taichi Sugaya <sugaya.taichi@socionext.com>,
 Takao Orito <orito.takao@socionext.com>,
 Tharun Kumar P <tharunkumar.pasumarthi@microchip.com>,
 Thierry Reding <thierry.reding@gmail.com>, Timur Tabi <timur@kernel.org>,
 Vineet Gupta <vgupta@kernel.org>, Marek Szyprowski <m.szyprowski@samsung.com>
References: <20240405060826.2521-1-jirislaby@kernel.org>
 <daf06969-15fd-470e-88b8-a717066fe312@linaro.org>
 <cebad7f8-3f47-4e6a-93b7-32fcf2367874@kernel.org>
 <f42ef4a3-4bfe-4354-9220-ed742e093c86@gmail.com>
Content-Language: en-US
In-Reply-To: <f42ef4a3-4bfe-4354-9220-ed742e093c86@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi

Op 07-06-2024 om 22:32 schreef Ferry Toth:
> Hi,
> 
> Op 22-04-2024 om 07:51 schreef Jiri Slaby:
>> Hi,
>>
>> On 19. 04. 24, 17:12, Neil Armstrong wrote:
>>> On 05/04/2024 08:08, Jiri Slaby (SUSE) wrote:
>>>> This series switches tty serial layer to use kfifo instead of circ_buf.
>>>>
>>>> The reasoning can be found in the switching patch in this series:
>>>> """
>>>> Switch from struct circ_buf to proper kfifo. kfifo provides much better
>>>> API, esp. when wrap-around of the buffer needs to be taken into 
>>>> account.
>>>> Look at pl011_dma_tx_refill() or cpm_uart_tx_pump() changes for 
>>>> example.
>>>>
>>>> Kfifo API can also fill in scatter-gather DMA structures, so it easier
>>>> for that use case too. Look at lpuart_dma_tx() for example. Note that
>>>> not all drivers can be converted to that (like atmel_serial), they
>>>> handle DMA specially.
>>>>
>>>> Note that usb-serial uses kfifo for TX for ages.
>>>> """
>> ...
>>> This patchset has at least broken all Amlogic and Qualcomm boards so 
>>> far, only part of them were fixed in next-
>>
>> So are there still not fixed problems yet?
>>
>>> but this serie has been merged in v1
>>
>> Ugh, are you saying that v1 patches are not worth taking? That doesn't 
>> fit with my experience.
>>
>>> with no serious testing
>>
>> Sadly, everyone had a chance to test the series:
>>    
>> https://lore.kernel.org/all/20240319095315.27624-1-jirislaby@kernel.org/
>> for more than two weeks before I sent this version for inclusion. And 
>> then it took another 5 days till this series appeared in -next. But 
>> noone with this HW apparently cared enough back then. I'd wish they 
>> (you) didn't. Maybe next time, people will listen more carefully:
>> ===
>> This is Request for Testing as I cannot test all the changes
>> (obviously). So please test your HW's serial properly.
>> ===
>>
>>> and should've been dropped immediately when the first regressions 
>>> were reported.
>>
>> Provided the RFT was mostly ignored (anyone who tested that here, or I 
>> only wasted my time?), how exactly would dropping help me finding 
>> potential issues in the series? In the end, noone is running -next in 
>> production, so glitches are sort of expected, right? And I believe I 
>> smashed them quickly enough (despite I was sidetracked to handle the 
>> n_gsm issue). But I might be wrong, as usual.
> 
> I arrived at this party a bit late, sorry about that. No good excuses.
> 
>> So no, dropping is not helping moving forward, actions taken by e.g. 
>> Marek Szyprowski <m.szyprowski@samsung.com> do, IMNSHO.
> 
> Good news is I tested on Merrifield (Intel Edison) which is slow 
> (500MHz) and has a HSU that can transmit up to 3.5Mb/s. It really 
> normally needs DMA and just a single interrupt at the end of transmit 
> and receive for which I my own patches locally. The bounce buffer I was 
> using on transmit broke due to this patch, so I dropped that. Still, 
> with the extra interrupts caused by the circ buffer wrapping around it 
> seems to work well. Too late to add my Tested-by.
> 
> One question though: in 8250_dma.c serial8250_tx_dma() you mention "/* 
> kfifo can do more than one sg, we don't (quite yet) */".
> 
> I see the opportunity to use 2 sg entries to get all the data out in one 
> dma transfer, but there doesn't seem to be much documentation or 
> examples on how to do that. It seems just increasing nents to 2 would do 
> the trick?

Nevertheless I got this to work. Very nice. Thanks for this series.
I am seeing only 2 interrupts (x2 as each interrupt happens twice), one 
for dma complete. The 2nd, not sure but likely, uart tx done.
In any case the whole buffer is transferred without interchar gaps.

> So, what was the reason to "don't (quite yet)"?

Before considering to send out a patch for this, are there any caveats 
that I'm overlooking?

>> thanks,
>