Received-SPF: pass (google.com: domain of linux-kernel+bounces-208918-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <6a78de4e-8d36-400c-9eb5-d3d6aa9e1e23@intel.com>
Date: Mon, 10 Jun 2024 14:32:03 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] selftests/resctrl: Fix noncont_cat_run_test for AMD
To: Babu Moger <babu.moger@amd.com>, <fenghua.yu@intel.com>,
	<shuah@kernel.org>
CC: <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>, <maciej.wieczor-retman@intel.com>,
	<peternewman@google.com>, <eranian@google.com>
References: <3a6c9dd9dc6bda6e2582db049bfe853cd836139f.1717622080.git.babu.moger@amd.com>
 <7679d70a0ea939db13ae9dac20de56644460d6df.1718035091.git.babu.moger@amd.com>
From: Reinette Chatre <reinette.chatre@intel.com>
Content-Language: en-US
In-Reply-To: <7679d70a0ea939db13ae9dac20de56644460d6df.1718035091.git.babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTM3Z3hEbDVNZWtxOExQaDJGdHQ4dzd5SUY1UGVTYVdRVTVuTXJNeE5lZ3Ux?=
 =?utf-8?B?WnAySllBdVdYRHNFeGM4TmlJd0FXSzVFZ1FJRXBLd2VrcTZsY2l6SFZ6Rkl0?=
 =?utf-8?B?YkdDMUtCOFhDWFlMdHZEdHp6aE9jc2V0NmtMT1dQR0lkMUxMbXAyZDZ5VTBG?=
 =?utf-8?B?U01vUTd3WmpCeVJmUFJtbkN3VkxnQmd3VjkydDFsR21yYVp6elh0UUt3RDdM?=
 =?utf-8?B?YUFneUdoNlV2NnBIOWFWeXBIU2xwRklVUWhoTTJFR2pFbjNvMjcrcHFxblBD?=
 =?utf-8?B?S1dRMllreURnZ2tMN1hrMFJVdXhQTzZSL2ZtajJRN2YzZW5SelNQM3lWV1RK?=
 =?utf-8?B?eGsrZythSnRDaVlNbThSQ3NZb2xORHVJYlhuQ09rY0Y4UEJHb29qUjVVNmNC?=
 =?utf-8?B?N2VrWHVKeWNEK3RiMGRCZ3paR2toMG1HamhRV0N3T2pDek9PcDFtRlY3NXpm?=
 =?utf-8?B?R0Z6dlVqZ1RNRERlNDRKOXRoM2QwakJBLzd2RVBwa0g2Q2xkNVRsanlVdjR5?=
 =?utf-8?B?RXl5Vlo3TC82aEg4TlBjcmxxTDhpTXBKUXp4OWNPOUEya050ZkgvSlRFd1NN?=
 =?utf-8?B?QnFZS2VQbzBFczV3ald3TGF6MURMQmtOaGhkVEdCUWliN1lGcHZicDF3L3BY?=
 =?utf-8?B?Q1JsanFUYnV1MW5xKzNQZy96VjN2eG9XdGhTUy80aGc2WXY4dUxzRmJnS0Zl?=
 =?utf-8?B?bkc1eVRxQTdIUlN5NndoV2MvNzhBNUhobkQwZURWMWxtOUFlSlFjSHRJSXFj?=
 =?utf-8?B?NmxGNm5qOGZteUlyZ1pFK1ZiUjVZbDdGZ2llUmRZQVlBWmF3c2FhdXpnbzVY?=
 =?utf-8?B?aFExL2xHdm1DRVhYSlJQMUlXU204VFJpNVA0OVBFZEViWDJjdmZrV3Y1SkpJ?=
 =?utf-8?B?QjY0QW54Z004Mk0rSlE4WXpYb29vb01tUkVlNSsvZ2NBeUh5NFhZc2k5alB5?=
 =?utf-8?B?MTcxMDk1MTdPZmxhMHkreDYzM1VTeHJWRm44aHB4eTYrRlhWejhJZXQ1MFRM?=
 =?utf-8?B?OG9wUzNBK24rTVlLWGJER2lqNGNTZVVKcEpleUJ6YUxpQXkzNXJRSWtxZFh2?=
 =?utf-8?B?T1NPRjNYRHJJN3lQeXVUbzF1Slk5dVBrWEMrb3RLUSsyd0lFU3Y1YUFLamJ1?=
 =?utf-8?B?Y2FabDYvazhLRTBUMzNxdmN4S0xVS0VtbVdJc3c5MG53V0xiMFkrNGswUURo?=
 =?utf-8?B?S2lzLzc1dG1teTBoVWlPU29WS0ZNeEJvZ0VkalhjT0pjUFprS1dtWndNSms2?=
 =?utf-8?B?cXdKQklLTFNRK21xVS9MMHdEeEovcUJOU1MyQ0Jwb3lYcUFGZGszaE5SR3Na?=
 =?utf-8?B?QW5KNCtVaEwxN3B1VHpCVGVhL1ZBcmxWN29EZnlXSWFkVU9YWXIxTjgzdXVa?=
 =?utf-8?B?dk5UQUxsUWFaOGpLcWFLVFV4dmJCQk1xczBQQnVIK05DTUMzeTBTWjRTazNm?=
 =?utf-8?B?UEkrQXJxQ0laQk1CeHl4bHA3ZGphUmRWYjduaFlrcjlETVN5QXdsM2pISTBq?=
 =?utf-8?B?TlEyS1A3c0ZqM2wrWE1Ha2tTdC8zdVZNcE9NVFBsVTdqNDFWbVM1NWdHOE51?=
 =?utf-8?B?aEJ0bm4zR2MwR21ha09NOVQ4a09uWHQ3ZHkyWWkxSkZtUXJiZ04yVzd5dUIw?=
 =?utf-8?B?MzVQblI3OHVGQkZ5c1Z0Mkx0UU85Sm1wTTRjd2QyZkg5UEY2RFZSVUUwaWR1?=
 =?utf-8?B?YWJnZkU4N00wUThNYlFYNWhJbFk3Ky9qRWwrTEt5R0xyMG5ERlhEVFpzK2tT?=
 =?utf-8?B?eXovN3lpMlc3ZFBuVXpJa3F6Q3hmMExiei9hK1VEdjdxNmUwclVPTFlPZmg1?=
 =?utf-8?B?d0REV1NFcEd3d3FuYTAzcjQ4ZXFKUGp5VmFhcEZ6a2h3ZkxIeHowSDgwRCt3?=
 =?utf-8?B?cUMxaWMwbzh3S1g1eXN3TURQWnZjekxXSkd6OXJzclVvL0NJQ2hXTCt3RzVk?=
 =?utf-8?B?anlWY29LTE1nejZxbU5DeTdqZXhSU1I0RTJjTzZOdXUrRktka3ZnUU1Md3Zl?=
 =?utf-8?B?Znd4ak9zelBBcUR6VmlCMzBVWmt4NFhERkFLTkFXL21kSFJYSUF1ZnhGU05q?=
 =?utf-8?B?aHN1MjdVM0Q2YzJ6NThnaXlqelpOeERnRXBwek5XUksydlg0dDV3KzFwMXNy?=
 =?utf-8?B?OUJ6WVphdEF1ZmlJR3c0VVFnV3hmdVoxelZCZ1cranlXeWhrWTlUM2ZUNTVW?=
 =?utf-8?B?NGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2215d49b-35f4-40b1-d814-08dc8994c668
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2024 21:32:05.8852
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hn+YuQsoaxg8pUUvsTposBTIXtZT3ftPfb+pPaawAR6Pz7ulRN1/b4TwcP5ie5nscECfS2bWdixFq3PPHRhvXuMEOBrct7QrwM2IbyOCluc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7593
X-OriginatorOrg: intel.com

Hi Babu,

(please do not send new version of patch in response to previous version)

On 6/10/24 9:00 AM, Babu Moger wrote:
> The selftest noncont_cat_run_test fails on AMD with the warnings. Reason
> is, AMD supports non contiguous CBM masks but does not report it via CPUID.
> 
> Update noncont_cat_run_test to check for the vendor when verifying CPUID.
> 
> Fixes: ae638551ab64 ("selftests/resctrl: Add non-contiguous CBMs CAT test")
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---

The changelog needs to be reworked based on discussion in other thread.
With that complete, for this patch you can add:
| Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette