Received-SPF: pass (google.com: domain of linux-kernel+bounces-208961-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 10 Jun 2024 22:55:55 +0100
From: Mark Brown <broonie@kernel.org>
To: George Stark <gnstark@salutedevices.com>
Cc: lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@salutedevices.com
Subject: Re: [PATCH 0/1] pwm-regulator with voltage table problem
Message-ID: <Zmd2a0Etz3elXFID@finisterre.sirena.org.uk>
References: <20240610120025.405062-1-gnstark@salutedevices.com>
 <Zmcdvm7XbtU1JlQr@finisterre.sirena.org.uk>
 <62c9b99d-f0a4-4207-84b9-2176823b9724@salutedevices.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="QZBuJqS1t1o6h8AA"
Content-Disposition: inline
In-Reply-To: <62c9b99d-f0a4-4207-84b9-2176823b9724@salutedevices.com>


--QZBuJqS1t1o6h8AA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jun 11, 2024 at 12:33:42AM +0300, George Stark wrote:

> Actually we did a similar thing - we modified voltage table adding
> duty-cycle that was set by bootloader with fractional voltage value that is
> not used in opp table - just to make pwm-regulator happy.
> But this issue was very hard to find. Due to deviations of hardware
> component's characteristics some devices managed to keep working with
> minimal voltage till cpu opp driver got probed and appropriate voltage is
> restored. Other devices got stuck at different places with random errors.

I think the diagnostics you are looking for here are in the PWM
regulator driver.  The core does announce that it's bringing the voltage
into range when it does it so there's a hint that the voltage got
changed there.

> Of course such a behavior should be configurable. At the other hand it may
> be too much changes for a corner case that's why I proposed only a
> warning patch just to simplify detecting the problem.

> Actually we already have a hint that says voltage is reset:
> rdev_info(rdev, "Setting %d-%duV\n",
> 				  rdev->constraints->min_uV,
> 				  rdev->constraints->max_uV);
> but there's no indication this is due to regulator device  error.

The issue is that it may not be an error, it may be normal operation -
there are some regulators (those for some of the Qualcomm firmware
controlled devices for example) which are purely write only so we've got
no way to tell what the current configuration is and always need to
write out what we want during startup.

> Should I consider adding my warning only for "system-critical-regulator"
> regulators (cpu power regulator is critical indeed)? Although this property
> is never used in mainline bindings.

To the extent that it's an issue it's going to depend on the specific
regulator, the driver for a given regulator is best placed to know if
being able to read back from the hardware is expected and if it should
complain about not being able to.

--QZBuJqS1t1o6h8AA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZndmoACgkQJNaLcl1U
h9CKGgf/QI5Kdu1s/26vxdH6WSQvo2/mzgmPQpyFgmucgUPTfbkhPiQkEOTmTLYM
6Zz8LV5sfIk+HSGlanwbgvdeAowZH8Arb0sb15jmTiAn76G6lHd8eNvZbIL11Ytk
sze7nsOfE3bUmMC6/WUzuCTcnEXNv1AaQDurkNEdtRdieCPQBDyA5BhHaTmvZU9i
0yoIdMZUDZPPOoiqJJTRhTTBwgSSg87AdrTQADo5aJXVSxwPe5G07mzXZfJddeU7
jSvtzMS8GEnpoTQ3fQUoi4WbWOxopZxW3qcrNSF1kEQ3ixcnmf6/dDZzcz00RLLS
bncFH71acPXmO+41X8+qK5QzTNDtkQ==
=ZabS
-----END PGP SIGNATURE-----

--QZBuJqS1t1o6h8AA--