Received-SPF: pass (google.com: domain of linux-kernel+bounces-208982-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240524082800.333991-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20240524082800.333991-5-prabhakar.mahadev-lad.rj@bp.renesas.com> <CAMuHMdXk+u0J9GQrGHa_yMgBtkrhCNtGXdWmfsmVt3UskNMMug@mail.gmail.com>
In-Reply-To: <CAMuHMdXk+u0J9GQrGHa_yMgBtkrhCNtGXdWmfsmVt3UskNMMug@mail.gmail.com>
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date: Mon, 10 Jun 2024 23:05:59 +0100
Message-ID: <CA+V-a8st5i+P4MyAifvXu2QmH089faAe+r0GaHpWaJ38Xzeciw@mail.gmail.com>
Subject: Re: [PATCH 4/4] clk: renesas: Add RZ/V2H(P) CPG helper driver
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, 
	Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, 
	Philipp Zabel <p.zabel@pengutronix.de>, Magnus Damm <magnus.damm@gmail.com>, 
	linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Fabrizio Castro <fabrizio.castro.jz@renesas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Geert,

Thank you for the review.

On Wed, Jun 5, 2024 at 8:06=E2=80=AFAM Geert Uytterhoeven <geert@linux-m68k=
.org> wrote:
>
> Hii Prabhakar,
>
> Thanks for your patch!
>
> On Fri, May 24, 2024 at 10:29=E2=80=AFAM Prabhakar <prabhakar.csengg@gmai=
l.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Add RZ/V2H(P) CPG helper driver.
>
> Drop "helper"?
>
OK.

> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> > --- /dev/null
> > +++ b/drivers/clk/renesas/r9a09g057-cpg.c
> > @@ -0,0 +1,112 @@
>
> > +static int pll_clk1_offset[] =3D { -EINVAL, -EINVAL, -EINVAL, 0x64, -E=
INVAL,
> > +                              -EINVAL, 0xC4, -EINVAL, -EINVAL, 0x124, =
0x144 };
> > +static int pll_clk2_offset[] =3D { -EINVAL, -EINVAL, -EINVAL, 0x68, -E=
INVAL,
> > +                              -EINVAL, 0xC8, -EINVAL, -EINVAL, 0x128, =
0x148 };
>
> const (both)
>
> Both arrays are very similar: all valid values differ by an offset of 4.
> If that is universal, perhaps the second one can be dropped, and
> the offset can be handled by the user?
>
Agreed.

> > +static struct rzv2h_mod_clk r9a09g057_mod_clks[] =3D {
>
> const
>
Ok (and below)

> > +       DEF_MOD("scif_0_clk_pck",               R9A09G057_SCIF_0_CLK_PC=
K, CLK_PLLCM33_DIV16,
> > +                                               0x620, 15, 0x810, 15),
> > +};
> > +
> > +static struct rzv2h_reset r9a09g057_resets[] =3D {
>
> const
>
> > +       DEF_RST(R9A09G057_SCIF_0_RST_SYSTEM_N,          0x924,  5, 0xA1=
0, 6),
> > +};
>
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m6=
8k.org
>
> In personal conversations with technical people, I call myself a hacker. =
But
> when I'm talking to journalists I just say "programmer" or something like=
 that.
>                                 -- Linus Torvalds