Received-SPF: pass (google.com: domain of linux-kernel+bounces-208984-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <01433df1-aa19-4abb-9d87-c54e4c0dff17@ti.com>
Date: Mon, 10 Jun 2024 17:13:59 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 1/8] dt-bindings: counter: Add new ti,am62-eqep
 compatible
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, Rob
 Herring <robh@kernel.org>
CC: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Vignesh Raghavendra <vigneshr@ti.com>,
        Tero
 Kristo <kristo@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        David
 Lechner <david@lechnology.com>, Nishanth Menon <nm@ti.com>,
        William Breathitt
 Gray <wbg@kernel.org>
References: <20240610144637.477954-1-jm@ti.com>
 <20240610144637.477954-2-jm@ti.com>
 <5ad5cf7a-c5c6-449e-9ed9-3d9f74959a19@linaro.org>
Content-Language: en-US
From: Judith Mendez <jm@ti.com>
In-Reply-To: <5ad5cf7a-c5c6-449e-9ed9-3d9f74959a19@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


Hi Krzysztof,

On 6/10/24 9:58 AM, Krzysztof Kozlowski wrote:
> On 10/06/2024 16:46, Judith Mendez wrote:
>> Add new compatible ti,am62-eqep for TI K3 devices. If a device
>> uses this compatible, require power-domains property.
>>
>> Since there is only one functional and interface clock for eqep,
>> clock-names is not really required, so removed from required
>> section, make it optional for ti,am3352-eqep compatible, and
>> update the example.
>>
> 
> ...
> 
> 
>>           interrupts = <79>;
>>       };
>>   
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +    #include <dt-bindings/soc/ti,sci_pm_domain.h>
>> +
>> +    bus {
>> +        #address-cells = <2>;
>> +        #size-cells = <2>;
>> +        eqep1: counter@23210000 {
> 
> No need for label
> 
>> +          compatible = "ti,am62-eqep";
>> +          reg = <0x00 0x23210000 0x00 0x100>;
>> +          power-domains = <&k3_pds 60 TI_SCI_PD_EXCLUSIVE>;
>> +          clocks = <&k3_clks 60 0>;
>> +          interrupts = <GIC_SPI 117 IRQ_TYPE_EDGE_RISING>;
>> +          status = "disabled";
> 
> Drop... which also points to another comment - since this was no-op and
> example is basically the same, then just don't add it. No point.

Ok, then I will drop the new example, thanks.

BTW..
In the existing example for ti,am3352-eqep compatible,
do you know if it is appropriate to drop clock-names
from the example if it is no longer required?

~ Judith

> 
>> +        };
>> +    };
>>   ...
> 
> Best regards,
> Krzysztof
>