Received-SPF: pass (google.com: domain of linux-kernel+bounces-209006-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <e1fd1b659711f59c61ec48dc43912dddccbb4d92.1717996742.git.dsimic@manjaro.org>
In-Reply-To: <e1fd1b659711f59c61ec48dc43912dddccbb4d92.1717996742.git.dsimic@manjaro.org>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Tue, 11 Jun 2024 07:29:19 +0900
Message-ID: <CAK7LNAQ7cKbuU9uv67DT4CQagvXdJCWXBP9LjkC_Hvd5QWnYRQ@mail.gmail.com>
Subject: Re: [PATCH v2] kbuild: Install dtb files as 0644 in Makefile.dtbinst
To: Dragan Simic <dsimic@manjaro.org>
Cc: linux-kbuild@vger.kernel.org, nathan@kernel.org, nicolas@fjasle.eu, 
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, 
	Diederik de Haas <didi.debian@cknow.org>, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 10, 2024 at 2:21=E2=80=AFPM Dragan Simic <dsimic@manjaro.org> w=
rote:
>
> The compiled dtb files aren't executable, so install them with 0644 as th=
eir
> permission mode, instead of defaulting to 0755 for the permission mode an=
d
> installing them with the executable bits set.
>
> Some Linux distributions, including Debian, [1][2][3] already include fix=
es
> in their kernel package build recipes to change the dtb file permissions =
to
> 0644 in their kernel packages.  These changes, when additionally propagat=
ed
> into the long-term kernel versions, will allow such distributions to remo=
ve
> their downstream fixes.
>
> [1] https://salsa.debian.org/kernel-team/linux/-/merge_requests/642
> [2] https://salsa.debian.org/kernel-team/linux/-/merge_requests/749
> [3] https://salsa.debian.org/kernel-team/linux/-/blob/master/debian/rules=
.real?ref_type=3Dheads#L193


The 'master' is a moving target.

The line 193 in the future may not point to the correct position


I changed it to this.

[3] https://salsa.debian.org/kernel-team/linux/-/blob/debian/6.8.12-1/debia=
n/rules.real#L193


This references the line 193 from the 'debian/6.8.12-1' tag.


Applied to linux-kbuild.
Thanks!


> Cc: Diederik de Haas <didi.debian@cknow.org>
> Cc: stable@vger.kernel.org
> Fixes: aefd80307a05 ("kbuild: refactor Makefile.dtbinst more")
> Signed-off-by: Dragan Simic <dsimic@manjaro.org>
> ---
>
> Notes:
>     Changes in v2:
>       - Improved the patch description, to include additional details and
>         to address the patch submission issues pointed out by Greg K-H [4=
]
>       - No changes were made to the patch itself
>
>     Link to v1: https://lore.kernel.org/linux-kbuild/ae087ef1715142f606ba=
6477ace3e4111972cf8b.1717961381.git.dsimic@manjaro.org/T/#u
>
>     [4] https://lore.kernel.org/linux-kbuild/2024061006-ladylike-paving-a=
36b@gregkh/
>
>  scripts/Makefile.dtbinst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.dtbinst b/scripts/Makefile.dtbinst
> index 67956f6496a5..9d920419a62c 100644
> --- a/scripts/Makefile.dtbinst
> +++ b/scripts/Makefile.dtbinst
> @@ -17,7 +17,7 @@ include $(srctree)/scripts/Kbuild.include
>  dst :=3D $(INSTALL_DTBS_PATH)
>
>  quiet_cmd_dtb_install =3D INSTALL $@
> -      cmd_dtb_install =3D install -D $< $@
> +      cmd_dtb_install =3D install -D -m 0644 $< $@
>
>  $(dst)/%: $(obj)/%
>         $(call cmd,dtb_install)


--=20
Best Regards
Masahiro Yamada