Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp12843lqp; Mon, 10 Jun 2024 16:13:02 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXzbKzwp2HQvd6xDxVWrpmG5wvoBbaSscR9iaD9e6UUL713Q3C44j+6Gb4bLqvo6ey1Wa2kRV6tF2LCW1AwN9ndGlNGkNkzQMOZtd13GQ== X-Google-Smtp-Source: AGHT+IFlcNB0mqM8ONoimpwwA956JJuRLTROYmjVjHbYv23uJ+2ba+gQ2Am3x7Zu02JqnQDcNA0I X-Received: by 2002:a2e:b0d6:0:b0:2ea:e204:afc2 with SMTP id 38308e7fff4ca-2eae204b720mr51897651fa.12.1718061182654; Mon, 10 Jun 2024 16:13:02 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718061182; cv=pass; d=google.com; s=arc-20160816; b=ZSk2ypp1cmdMLpwBDph/IJMKMvqL2KOnwkD0El0Rdd9RQWeIpTOkUWKMbOnBxbqxvP v5VsEuN4PbdEAS5SiToVMHPzO0GduF4GipFYgPuSo14QpCmHpW0xWUmtZuuotK3MFc+v uZaic+pNq/RQO+m2gw60Dkq7Kwb5PCeJAhI9N+icV0PXoBKvXO1B1knIpTn23qrRZ6Sz QP2IpGS/MOkiSDYSvhKj+xQT3u/Ws9WJH5DEVH/1Bjc5uA4AduArM2fI2umeKgoQU8nT ks7mDVuMwj8YGq/Wy9W6+8ViyQouz90JMKF2f+8T6oYSlHBPSjbbTo/+OaogA4UdD2wb DSKA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=ozX+svhUE8NPpq8SydPNqxb9OzxvgvSnMKkEEb3sTx8=; fh=jrU4vZmEFHceitD8I7xdlE5Lwuy1nA15SaxY0r4gSC4=; b=xcFu1toz+LHYMjL5ijDjdIM+dbWYVG+/LGR5vKDUPEIERPCdecWBCmJzDWUrer8P0f Vz4ov/SC/nSs/SMlXG1mThxl9CTpyTvkMR8V0bdCT4EvQxgfntY5K0Dm55fgOVJGnX0I J0/SsoVdChQQ+hTRLMPe1aizoVHgYazwLPNvqSuDbG4453Avr1Ebd2adpzZgku7jmu3d XQAwUBOcJjgKFGeogV4cWa8FDjeC6tMobU8oX2LdTOuvJ8VJ6QHI4CCOqzG7JzADa5MA UF7yEazklI5Rk5TH691aumacVHrulEibdISVi9lI66uvspek94njNSOB/1+ZjjY39GCW K7xA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=nXpAGqjZ; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-209048-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-209048-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57aae22af4bsi5183395a12.413.2024.06.10.16.13.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 16:13:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-209048-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=nXpAGqjZ; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-209048-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-209048-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 478831F22223 for ; Mon, 10 Jun 2024 23:13:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0A01E155C9B; Mon, 10 Jun 2024 23:10:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="nXpAGqjZ" Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B57231527A2 for ; Mon, 10 Jun 2024 23:10:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718061037; cv=none; b=HLOciLZXInIRdMGQ34hZHzifVPfBm+wubXbDtWXCoSboi+NlypKW23gQADMaXuX9BpHoXh9/PNq6EMwVLsPh0oql3KpWz7YiSL3pOZwNOs87Xylj0gXo72iaXjJ9k6cP7RyVUetKLwbZHCIRM9uc5Aj1al0Xn3pofYwXOVxvItU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718061037; c=relaxed/simple; bh=JkQhTwDhyHbtRJkcZLwjJAEbRwRVP8gcYsDg6MMuIjI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=V+Y3DsP6vnRW1/sRlcyvFT4kDeublj7lkI0xaKRZgWtOq3mgICpuDODOs+N2KeKse6MlVPEymr6acuZ1wEp8eL5J5/ddMpat7ibSiJDZ0LZqs/A2862DPZO9fA8wNzJTF/HqLo6n46TCKzFNBlA85lXryII9vC60IU9FWmyFHeE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=nXpAGqjZ; arc=none smtp.client-ip=91.218.175.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Envelope-To: radhey.shyam.pandey@amd.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1718061033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ozX+svhUE8NPpq8SydPNqxb9OzxvgvSnMKkEEb3sTx8=; b=nXpAGqjZepTTsLw+prupAAZ9cSkDJxM8H01JKIp2PzXBa/GACG5rHmu7FHRy58hlWZq7qR cGieKAly55vODxYYvni1QL+aXTuNSU1qAfphUpMRoIQs/vfml8e0Ui//T3xim08I8wwJfZ 2yDHVbl9kxwtS89gvpnD7cLDhhfjK0M= X-Envelope-To: netdev@vger.kernel.org X-Envelope-To: linux-arm-kernel@lists.infradead.org X-Envelope-To: michal.simek@amd.com X-Envelope-To: kuba@kernel.org X-Envelope-To: linux@armlinux.org.uk X-Envelope-To: pabeni@redhat.com X-Envelope-To: edumazet@google.com X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: davem@davemloft.net X-Envelope-To: sean.anderson@linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson To: Radhey Shyam Pandey , netdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Michal Simek , Jakub Kicinski , Russell King , Paolo Abeni , Eric Dumazet , linux-kernel@vger.kernel.org, "David S . Miller" , Sean Anderson Subject: [PATCH net-next 2/3] net: xilinx: axienet: Report RxRject as rx_dropped Date: Mon, 10 Jun 2024 19:10:21 -0400 Message-Id: <20240610231022.2460953-3-sean.anderson@linux.dev> In-Reply-To: <20240610231022.2460953-1-sean.anderson@linux.dev> References: <20240610231022.2460953-1-sean.anderson@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT The Receive Frame Rejected interrupt is asserted whenever there was a receive error (bad FCS, bad length, etc.) or whenever the frame was dropped due to a mismatched address. So this is really a combination of rx_otherhost_dropped, rx_length_errors, rx_frame_errors, and rx_crc_errors. Mismatched addresses are common and aren't really errors at all (much like how fragments are normal on half-duplex links). To avoid confusion, report these events as rx_dropped. This better reflects what's going on: the packet was received by the MAC but dropped before being processed. Signed-off-by: Sean Anderson --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 5f98daa5b341..cf8908794409 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1296,7 +1296,7 @@ static irqreturn_t axienet_eth_irq(int irq, void *_ndev) ndev->stats.rx_missed_errors++; if (pending & XAE_INT_RXRJECT_MASK) - ndev->stats.rx_frame_errors++; + ndev->stats.rx_dropped++; axienet_iow(lp, XAE_IS_OFFSET, pending); return IRQ_HANDLED; -- 2.35.1.1320.gc452695387.dirty