Received-SPF: pass (google.com: domain of linux-kernel+bounces-209050-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <3078aee7-acbe-f912-9a99-941154dc4b13@amd.com>
Date: Mon, 10 Jun 2024 18:11:31 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v2] selftests/resctrl: Fix noncont_cat_run_test for AMD
Content-Language: en-US
To: Reinette Chatre <reinette.chatre@intel.com>,
 Babu Moger <babu.moger@amd.com>, fenghua.yu@intel.com, shuah@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
 ilpo.jarvinen@linux.intel.com, maciej.wieczor-retman@intel.com,
 peternewman@google.com, eranian@google.com
References: <3a6c9dd9dc6bda6e2582db049bfe853cd836139f.1717622080.git.babu.moger@amd.com>
 <7679d70a0ea939db13ae9dac20de56644460d6df.1718035091.git.babu.moger@amd.com>
 <6a78de4e-8d36-400c-9eb5-d3d6aa9e1e23@intel.com>
From: "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <6a78de4e-8d36-400c-9eb5-d3d6aa9e1e23@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YVF0SFpWZzVEWjhjVEcvdmlkSkswMkx6VERWLy9IcDQ2VTQ3Wk4yYUhSYnFB?=
 =?utf-8?B?ZU9XLzBxM0NGaHAxdlVlUHA1Z1JpeS9rZjlQQ3RGQWE1OWpteVlYNmhnVVFT?=
 =?utf-8?B?TXViRzd1K1BzNVdwS04wcUx4QmtUeVdQeGt0N25teVFtS1NJR3BlQnZvd3Zt?=
 =?utf-8?B?QmdtbXFTYmZFa0NsNFdPMlQ4OVRPZElLcmVKeFFWU1NLd21sWjg3MmlmcW4y?=
 =?utf-8?B?b2tva0JGNitpNVJyVzE2SUhNUHRYZjFXamk0SEh6NkNYcmVucWFnT2I1VCtJ?=
 =?utf-8?B?M0FzQU1qQWRHZUFtN2wxR0hmQ1JVQjN6amlLNlBvZ3R4WHBmZVcwQklPMGk2?=
 =?utf-8?B?L3RCLzFDSEt5THdWWEJqMjNFZHduanY3UFkzUCtNa2pXcDMvQXh0azFHQ0Rj?=
 =?utf-8?B?V1RqQjA2WmVVOWxQNGNwbks5QnF5d0M1SGRoYTV5VmRFcGliWW5LS3RqTnM4?=
 =?utf-8?B?UUdGc2ZGQlFUNzJqZ3BUWVVscklpNEJVd1hROWNJTDlTRzZiYmpSeHpwb0tI?=
 =?utf-8?B?KzVQcDdVanRFNlAyZ1pxa25UVUFIcHlSVXZURkdZMm5XTXFKdGFpSExRVDVX?=
 =?utf-8?B?N2E4K0lBaFF6N09ETzBja2lTUFRYYklNZktCaHVyOUt5OXMveGFKbXJnZFNL?=
 =?utf-8?B?eEJWS2NCQUluMkxBdkZFa2dIMVFidXVFL3dqNGw5REtQbE1mY3ZhSlAwVU1B?=
 =?utf-8?B?M3VVR1dnQUhpYXovZkhDU3lzbmQrWXBrRlQrOXhwSHNvMVY4OHBGY3dqV1N5?=
 =?utf-8?B?RVpzT1MxaDNPS3pZVTBwaCtkVzBtU2k3Z1BqSllEVlFkUmpuTE5haEJmNFVS?=
 =?utf-8?B?Tytad0xLcm5rV09mWWRaemQzc3ZCSTBPdlNLNGNzTUQybXZmQWx4ZHZpUFlB?=
 =?utf-8?B?akpsSFMvbHl5UWg3SmlwczhTZVRTUXNSRWhJUEFSUHhEL0hCaUtyUnF0Qjhy?=
 =?utf-8?B?U2U5WU5KNDY2QmswaVhGQnBZTElXMmF3NGg0eVdlRHN0aTdPNkdYSFVGZ3lZ?=
 =?utf-8?B?dkFrTmo5UFdhTityek1WT1QxNG9Zb1VKNldNVmpQUGZMT3dQdDFWeXpDeURV?=
 =?utf-8?B?TjVlM0xSbG80bzQyWGFFMzREcVZIY0k4eVYyUkhzZU05V2piWmlTVFovK25v?=
 =?utf-8?B?dytva290K2ZoRU15aFlhMFR2SkxHb05sWnA5SW1kWWE4V3NucFBOOHhZWk41?=
 =?utf-8?B?WHNRQVpSbi9LbE5uRVdSNzFFYnpEazRYdDUxb1JyTU5NcnhQbERGUFpZMDdB?=
 =?utf-8?B?cmlVU3QzS05SVWZEWklpZmxrQ3pUQUpBaWI5cmZob3BYMlZpSHpkamVuc1pB?=
 =?utf-8?B?WjFnWDNEOXhGTE1QQnQzVVFmVEpUdVhKSTdFT0l6RVVhTlBkUEFRRUJJVThO?=
 =?utf-8?B?ajJjK0YwQWhRc3pHTm1aMHJzYlpUb3JiRUx0ckxCR3VKelMwMnNSSWtkdnBq?=
 =?utf-8?B?ZmVISGRXQ0NUWktQdFBpd2JVcnBZZ1lmbk5JdzQwaXdpOGxNQlhaSmNJNmla?=
 =?utf-8?B?cUJVNGJ5VEtVb0Mxc1lQMTBSakh3elVWZjFZQUlTQXU5RGpicEc1b0xTSG0x?=
 =?utf-8?B?NkV0SjJDNkxxb3piMUJCWFFzRHhQZUYxanBnK1BCZlUvb3JFeFdlb0plUnVT?=
 =?utf-8?B?cjR5eGRSUDRETjRReUgrUElobjhSL2k1enFpUVpyM1cvcloyNEYycWd1eE8z?=
 =?utf-8?B?cUhOZzBjQkI1WERZVXVEcTdrdWhWMWhhQUpwaG0zWE9hSUdjNkVLRHZFak1O?=
 =?utf-8?B?aU1Cc1pjbkdpNjYwWGcxeitXQW9WSmRSMFZwNEVua01KSzVQbmh0WUV0eVRj?=
 =?utf-8?B?aFRvZVNQS0xPMUhmTlUzSFFMK3p1eVljVncrUnZXZE5GWU8zbGZiVW9TQ2J3?=
 =?utf-8?B?c2YwSkpjTGRhT3pVQzRDYlYwcFh5RGkySXRKWWZnUytUUHJINERHejNwMUdt?=
 =?utf-8?B?ZWRKL01sVEpDaEYwS3pGVFdXajl3Zlk2bnFyRjVmNkZkQWUzYWRWT1p2V1lL?=
 =?utf-8?B?YXNLQjhxV1ZEQXMzOWpuNXdZN0NIaDQ5V2tNV295Y2puU1RoNzhaYUhJN2NL?=
 =?utf-8?B?cTJaQ2hkTitxMUh1WTViVGxDa1J1S3hEY0xMNVFXUGVwT1VyQk95KzhEdmw2?=
 =?utf-8?Q?/KaFHyStwlVHMiyFML0G9DPqP?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 55b4ba2b-3806-4e99-e73f-08dc89a2ac2b
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2024 23:11:34.7392
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3PyNq/GHiMyYIZ0rgfxoyjY60puaV0tNjzskn7V3qdyh97OWiZdoouVvrzwaX5zz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5854

Hi Reinette,

On 6/10/2024 4:32 PM, Reinette Chatre wrote:
> Hi Babu,
> 
> (please do not send new version of patch in response to previous version)

Yes. I saw your comments on other thread. I will take care of it.

> 
> On 6/10/24 9:00 AM, Babu Moger wrote:
>> The selftest noncont_cat_run_test fails on AMD with the warnings. Reason
>> is, AMD supports non contiguous CBM masks but does not report it via 
>> CPUID.
>>
>> Update noncont_cat_run_test to check for the vendor when verifying CPUID.
>>
>> Fixes: ae638551ab64 ("selftests/resctrl: Add non-contiguous CBMs CAT 
>> test")
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> ---
> 
> The changelog needs to be reworked based on discussion in other thread.

Sure.

> With that complete, for this patch you can add:
> | Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Thanks

-- 
- Babu Moger