Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp14247lqp; Mon, 10 Jun 2024 16:16:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXauN1+KL9XfBU9cFSUFyq4mNmqk/q1XrgqBrPS5WfFhqwC3ysGeozd1dYPyHwUL6nf0aggKeyWb83DazHQqNjFT8QimFIY9OCB5MRWNQ== X-Google-Smtp-Source: AGHT+IFbRHF5O7QjE9L7RwXpwAjEXRmwc4m8SbXrM089l7WA0wi2SA1aPo85ezBIOhibKyxlKEZc X-Received: by 2002:a05:6a20:918b:b0:1b4:53e3:5903 with SMTP id adf61e73a8af0-1b453e35a80mr9286799637.27.1718061402021; Mon, 10 Jun 2024 16:16:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718061402; cv=pass; d=google.com; s=arc-20160816; b=m87+tA4wOKCXZE/KW0/4m573OVCtQXSzE9uKk+50fkI/qPGnpMkqiWv2KF7KUJk5Ef 86Nkj/bIzDprdaaTNT7Oh2tiNl6O3CxDULVAYTARfUXLxUm2VEav9IypY2REcE1QZ0ta bj+0yULtTPBdRZVSKtzbevnvUILvvuvkOWhAlMJwTJnnDGW64NcGrrkAqYnkte+8xoeT Y0uc2+fqBc0LAut3HpEWvF+lThsjJjRZD1vT0zsf3oT7WDM7E0plv0xnw7l5yWyAu4du oCp2jErJggZXfHPhXriQhBR5gDupi3ezK1NE9V1F7lVRla+uUZHYCmL2nX4gZoklqL9m rcjQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=sIDawGWKnyBrcoVqu6SX/m8fgf8mjjwXZDoaerxtp0I=; fh=jrU4vZmEFHceitD8I7xdlE5Lwuy1nA15SaxY0r4gSC4=; b=tQ3yYjWM0ehIu2JNewf67XoF2CK8NQLLILFp1IpdrV2AqKegNiYYHi3YenQiCnCVjx UlZ2cY/CQ2jQ0Q2j5AZx+57zz0HGSJiT0a4MbeC9uRv8l3QXwHmoMyfv6TdT0mjrpbji /pRQRYunR9VniY10HbE4ai/GDyrZS3MIYx7KNndNaAENzF88WTm1bCvyUS6s1as7oB5R kfDr5WlAInHjpwZzmQ5geGLGXMBBNGb15LKSIRsfSL3HejzdFzdxMwfqyN8qTSTXAZQK KgQP2ewr7PYawHxnDNzpMoPiiCISgtdmADRWmkzeVs4aGJtR7PqW4hyT0AfTO4t8HePs qKDA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=aWPsxiAZ; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-209047-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-209047-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-6e7a12a219csi4825886a12.477.2024.06.10.16.16.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 16:16:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-209047-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=aWPsxiAZ; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-209047-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-209047-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id AA2B1B236C0 for ; Mon, 10 Jun 2024 23:12:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1056B152DF5; Mon, 10 Jun 2024 23:10:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="aWPsxiAZ" Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81C8D15219E for ; Mon, 10 Jun 2024 23:10:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718061035; cv=none; b=K33xDSLLLPO5D49YeY0f83rQkF4bD5IJU+e/fHrQDv70cAt52gi+Gi5pijvsP+M8ZRrx9VTsIq3Um9br++ub6hNroLrzImJDpNbA3mrgjRxCFNmcc9QpWws8bXhje9NqCH7UQUcThHxO2nPJv9TwvwCbtwj632gqOk+gdMUiq+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718061035; c=relaxed/simple; bh=GFaYaJtsfE/rjCCrgvMKC46RB3LB0XYd4/10z+G9YBM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WJK+lkmP+v4JF/JmmeZ0Tg+DMYB5VRyoYec6RRtEPOMrFH/4R3XNIHBwhV9FYcV04IwzyG4U+pBWLfDgBIQf9D4XR2cjR9nGyvrmZezhNzMucAxmlkKRzjy0nTpxSL2L5kXLzymZjthoHsJI/+ZNmGzgN0nZ6AByJP2TemZAqJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=aWPsxiAZ; arc=none smtp.client-ip=91.218.175.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Envelope-To: radhey.shyam.pandey@amd.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1718061031; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sIDawGWKnyBrcoVqu6SX/m8fgf8mjjwXZDoaerxtp0I=; b=aWPsxiAZ15vIqd70WUR9Qmw0LCIk6kOncWlKNdnMpa/c1XxyAD+2xD7Yes+lV1Q2hXcl+V 0Q6JHYWOk44Q2MlyNIkmiG4E58qd253f9n2Aao+FvLYCrd1O1JUnMRmgjBb5UgOIEB4zgM p9mwIKJPtAoaqKGEexY9FGJeyU2+X4c= X-Envelope-To: netdev@vger.kernel.org X-Envelope-To: linux-arm-kernel@lists.infradead.org X-Envelope-To: michal.simek@amd.com X-Envelope-To: kuba@kernel.org X-Envelope-To: linux@armlinux.org.uk X-Envelope-To: pabeni@redhat.com X-Envelope-To: edumazet@google.com X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: davem@davemloft.net X-Envelope-To: sean.anderson@linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson To: Radhey Shyam Pandey , netdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Michal Simek , Jakub Kicinski , Russell King , Paolo Abeni , Eric Dumazet , linux-kernel@vger.kernel.org, "David S . Miller" , Sean Anderson Subject: [PATCH net-next 1/3] net: xilinx: axienet: Use NL_SET_ERR_MSG instead of netdev_err Date: Mon, 10 Jun 2024 19:10:20 -0400 Message-Id: <20240610231022.2460953-2-sean.anderson@linux.dev> In-Reply-To: <20240610231022.2460953-1-sean.anderson@linux.dev> References: <20240610231022.2460953-1-sean.anderson@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT This error message can be triggered by userspace. Use NL_SET_ERR_MSG so the message is returned to the user and to avoid polluting the kernel logs. Signed-off-by: Sean Anderson --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index c29809cd9201..5f98daa5b341 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1945,9 +1945,9 @@ axienet_ethtools_set_coalesce(struct net_device *ndev, struct axienet_local *lp = netdev_priv(ndev); if (netif_running(ndev)) { - netdev_err(ndev, - "Please stop netif before applying configuration\n"); - return -EFAULT; + NL_SET_ERR_MSG(extack, + "Please stop netif before applying configuration"); + return -EBUSY; } if (ecoalesce->rx_max_coalesced_frames) -- 2.35.1.1320.gc452695387.dirty