Received-SPF: pass (google.com: domain of linux-kernel+bounces-209054-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 10 Jun 2024 19:18:43 -0400
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Chengen Du <chengen.du@canonical.com>, 
 Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: davem@davemloft.net, 
 edumazet@google.com, 
 kuba@kernel.org, 
 pabeni@redhat.com, 
 kaber@trash.net, 
 netdev@vger.kernel.org, 
 linux-kernel@vger.kernel.org, 
 stable@vger.kernel.org
Message-ID: <666789d3d9d2a_bf52c294e9@willemb.c.googlers.com.notmuch>
In-Reply-To: <CAPza5qfVzV7NFiVY1jcZR-+0ey-uKgUjV6OcjmDFvKG3T-2SXA@mail.gmail.com>
References: <20240608025347.90680-1-chengen.du@canonical.com>
 <66660e3cd5636_8dbbb294c@willemb.c.googlers.com.notmuch>
 <CAPza5qfVzV7NFiVY1jcZR-+0ey-uKgUjV6OcjmDFvKG3T-2SXA@mail.gmail.com>
Subject: Re: [PATCH v6] af_packet: Handle outgoing VLAN packets without
 hardware offloading
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable

Chengen Du wrote:
> Hi Willem,
> =

> I'm sorry, but I would like to confirm the issue further.
> =

> On Mon, Jun 10, 2024 at 4:19=E2=80=AFAM Willem de Bruijn
> <willemdebruijn.kernel@gmail.com> wrote:
> >
> > Chengen Du wrote:
> > > The issue initially stems from libpcap. The ethertype will be overw=
ritten
> > > as the VLAN TPID if the network interface lacks hardware VLAN offlo=
ading.
> > > In the outbound packet path, if hardware VLAN offloading is unavail=
able,
> > > the VLAN tag is inserted into the payload but then cleared from the=
 sk_buff
> > > struct. Consequently, this can lead to a false negative when checki=
ng for
> > > the presence of a VLAN tag, causing the packet sniffing outcome to =
lack
> > > VLAN tag information (i.e., TCI-TPID). As a result, the packet capt=
uring
> > > tool may be unable to parse packets as expected.
> > >
> > > The TCI-TPID is missing because the prb_fill_vlan_info() function d=
oes not
> > > modify the tp_vlan_tci/tp_vlan_tpid values, as the information is i=
n the
> > > payload and not in the sk_buff struct. The skb_vlan_tag_present() f=
unction
> > > only checks vlan_all in the sk_buff struct. In cooked mode, the L2 =
header
> > > is stripped, preventing the packet capturing tool from determining =
the
> > > correct TCI-TPID value. Additionally, the protocol in SLL is incorr=
ect,
> > > which means the packet capturing tool cannot parse the L3 header co=
rrectly.
> > >
> > > Link: https://github.com/the-tcpdump-group/libpcap/issues/1105
> > > Link: https://lore.kernel.org/netdev/20240520070348.26725-1-chengen=
.du@canonical.com/T/#u
> > > Fixes: 393e52e33c6c ("packet: deliver VLAN TCI to userspace")
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Chengen Du <chengen.du@canonical.com>
> >
> > Overall, solid.
> >
> > > ---
> > >  net/packet/af_packet.c | 57 ++++++++++++++++++++++++++++++++++++++=
++--
> > >  1 file changed, 55 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
> > > index ea3ebc160e25..8cffbe1f912d 100644
> > > --- a/net/packet/af_packet.c
> > > +++ b/net/packet/af_packet.c
> > > @@ -538,6 +538,43 @@ static void *packet_current_frame(struct packe=
t_sock *po,
> > >       return packet_lookup_frame(po, rb, rb->head, status);
> > >  }
> > >
> > > +static u16 vlan_get_tci(struct sk_buff *skb)
> > > +{
> > > +     struct vlan_hdr vhdr, *vh;
> > > +     u8 *skb_orig_data =3D skb->data;
> > > +     int skb_orig_len =3D skb->len;
> > > +
> > > +     skb_push(skb, skb->data - skb_mac_header(skb));
> > > +     vh =3D skb_header_pointer(skb, ETH_HLEN, sizeof(vhdr), &vhdr)=
;
> >
> > Don't harcode Ethernet.
> >
> > According to documentation VLANs are used with other link layers.
> >
> > More importantly, in practice PF_PACKET allows inserting this
> > skb->protocol on any device.
> >
> > We don't use link layer specific constants anywhere in the packet
> > socket code for this reason. But instead dev->hard_header_len.
> >
> > One caveat there is variable length link layer headers, where
> > dev->min_header_len !=3D dev->hard_header_len. Will just have to fail=

> > on those.
> =

> Thank you for pointing out this error. I would like to confirm if I
> need to use dev->hard_header_len to get the correct header length and
> return zero if dev->min_header_len !=3D dev->hard_header_len to handle
> variable-length link layer headers. Is there something I
> misunderstand, or are there other aspects I need to consider further?

That's right.

The min_header_len !=3D hard_header_len check is annoying and may seem
pedantic. But it's the only way to trust that the next header starts
at hard_header_len.=