Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp25257lqp; Mon, 10 Jun 2024 16:50:22 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWspXwa8sWYdRcKP3k8Y9/Xae1yazq0DUZEiX1NXScq0AvleO3UrrB+x+6GCy+z8HiY+3x0sr8RxwyklQmrzVVaTZ40qcPwobcm9ACRJg== X-Google-Smtp-Source: AGHT+IEz4xLfb79sdCZBLaverGrppFFIwl5pjUkhrPCSuhCSaDmVdC/9w5vniFu88LTP9XJ69tI8 X-Received: by 2002:a17:90b:11cf:b0:2bd:f708:ff0f with SMTP id 98e67ed59e1d1-2c2bcc0b27bmr10719207a91.21.1718063422329; Mon, 10 Jun 2024 16:50:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718063422; cv=pass; d=google.com; s=arc-20160816; b=mcFzXKGOxU2yde0SmsKnTIr4UEeCq1odJC0MXOvGU8PKsZNW6Q58PikQSr9vVE37/+ x+hqr7vcZz0Mtj4dac2LzNPkIjsS5JN8bB6FsZiUNzpxV2AnbmCZ1bAmrrz0y1JvGeZe FWqBU8qjLOfHdt7xz4/1erobTJzcko4xwdTaZXMLh5K52FZMqPzFhaqAVSzwSY8KhHn2 NX6uEXLBvs4/6U646SNpkuskHav0cMdTxBGomBvkv2ew/AtyWvjuwQR1+2w6co/cg+gD aBj08lithjFctfsjHKvSLZTinhbM7Xy/mOiXyPjVKk/UXv7+3neL5nQm/7nOStlKZnr+ mcGQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Ln+WVy76jUn+P4EBY0LbwmFreIynli6ZJaL1IR10J/w=; fh=XLKlWVQTm4ivMNcOUcqPzc8BJnfWvLlrVoDy4UZJ0Bg=; b=GGvzBzjT72jl0vscK+0xGqAMljORtfZ2tA7JLY7eIiwdVJMcW2r+GiNyG77zIUJpSP PacBa9Cma1hQnJQIowMRIdpl8LdHhc7GAb5/mZ2sgsX0p34rirLBUd5Y4c6FPwvm77EG iFSNMkG9dn+8WJfSRvII9K4Ncxlwjl2aJ2MHDlVe3yKn0CSKT12JH6WXTzy3SnDj7ofU Uh6NU0wf+RMFhX8MACYq4gPNWsetz1NXkHNniJs6UvjkbR6NW6STTUVvkgODB4trm6X/ gFv5edKGcqioWWXcpdx9AMhDag5XR348ARQ5bDmQn/L8xbpsBc9FZWfBV6PB1tRYRkJ9 wy8Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=OXXTyHqd; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-209070-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-209070-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2c2d10024ddsi5019323a91.88.2024.06.10.16.50.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 16:50:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-209070-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=OXXTyHqd; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-209070-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-209070-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id F1518283284 for ; Mon, 10 Jun 2024 23:50:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 80378152780; Mon, 10 Jun 2024 23:50:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="OXXTyHqd" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A04283BB48; Mon, 10 Jun 2024 23:50:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718063412; cv=none; b=ps3e3p2QWJYtFUiuuamAyoxusspS0dpVrrqkJAgysPsbUuSBLnHI0o9UgedNZmdWjJLySY2jUMyWMGqS+E58OemlJL9TxsqrH4eHZZtnJWY8/nxLWECdy//TlkRPYMdPKPVSI0Uf+f0PWCrLIs7pX5KJzhh2XnNMsk3qnhQmeK0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718063412; c=relaxed/simple; bh=GSZ9ox6lIuV8HBDQteAf50c/wbFbZZ5Ws4kYzDKBr+I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M9SFXyyfrlzzw4fKLYbm4fQXT9JXHtKvNYcEXZZNoaZ9hOLHc2RIrwB+SkN4PZlmD/2Sh8vx0egvj3xzbVmxK3q+gQbj+BuawSR4SjcrYKr1DVSTylQlgWDQ01Z8t/Rm9bgdnTZHq6h+88PNms7zZi2DReEcLyagpczDvXWvfIg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=OXXTyHqd; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Ln+WVy76jUn+P4EBY0LbwmFreIynli6ZJaL1IR10J/w=; b=OXXTyHqdGOo4ngCAwmxJv5Op4M v/H3Mg46ok/Mzkj/sH9unq+Hwe5rHCYsbPwwjVQZqb6I4VEwre2KgoMGRkNWzyrDFCyR8r4OhGkmt OwRg0VRVLKjZ8VNkSNe4CaJlZyZdJoGgsz4N9wiez7RklQC7nT4Fe1yiN9AqNLEPgoG8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sGolq-00HL2q-Ui; Tue, 11 Jun 2024 01:49:50 +0200 Date: Tue, 11 Jun 2024 01:49:50 +0200 From: Andrew Lunn To: Sean Anderson Cc: Radhey Shyam Pandey , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michal Simek , Jakub Kicinski , Russell King , Paolo Abeni , Eric Dumazet , linux-kernel@vger.kernel.org, "David S . Miller" Subject: Re: [PATCH net-next 1/3] net: xilinx: axienet: Use NL_SET_ERR_MSG instead of netdev_err Message-ID: <42fff229-ee8c-4738-854b-6093f254408f@lunn.ch> References: <20240610231022.2460953-1-sean.anderson@linux.dev> <20240610231022.2460953-2-sean.anderson@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240610231022.2460953-2-sean.anderson@linux.dev> On Mon, Jun 10, 2024 at 07:10:20PM -0400, Sean Anderson wrote: > This error message can be triggered by userspace. Use NL_SET_ERR_MSG so > the message is returned to the user and to avoid polluting the kernel > logs. This has nothing to do with statistics. So it would be better to post it as a standalone patch. It is the sort of trivial patch that should get merged quickly. I would also comment about the change from EFAULT to EBUSY in the commit message. Andrew --- pw-bot: cr