Received-SPF: pass (google.com: domain of linux-kernel+bounces-209143-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 10 Jun 2024 18:04:14 -0700
In-Reply-To: <20240509075423.156858-1-weijiang.yang@intel.com>
Precedence: bulk
Mime-Version: 1.0
References: <20240509075423.156858-1-weijiang.yang@intel.com>
Message-ID: <ZmeijsBo4UluT-7M@google.com>
Subject: Re: [RFC PATCH 1/2] KVM: x86: Introduce KVM_{G,S}ET_ONE_REG uAPIs support
From: Sean Christopherson <seanjc@google.com>
To: Yang Weijiang <weijiang.yang@intel.com>
Cc: pbonzini@redhat.com, mlevitsk@redhat.com, kvm@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="us-ascii"

On Thu, May 09, 2024, Yang Weijiang wrote:
> @@ -5859,6 +5884,11 @@ static int kvm_vcpu_ioctl_enable_cap(struct kvm_vcpu *vcpu,
>  	}
>  }
>  
> +static int kvm_translate_synthetic_msr(u32 *index)
> +{
> +	return 0;

This needs to be -EINVAL.

> +}
> +
>  long kvm_arch_vcpu_ioctl(struct file *filp,
>  			 unsigned int ioctl, unsigned long arg)
>  {