Received-SPF: pass (google.com: domain of linux-kernel+bounces-209169-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 11 Jun 2024 10:03:21 +0800
From: Yan Zhao <yan.y.zhao@intel.com>
To: Sean Christopherson <seanjc@google.com>
CC: Paolo Bonzini <pbonzini@redhat.com>, <linux-kernel@vger.kernel.org>,
	Xiangfei Ma <xiangfeix.ma@intel.com>
Subject: Re: [PATCH 1/2] nVMX: Ensure host's PAT is loaded at the end of all
 VMX tests
Message-ID: <Zmewac7teXzOs5i2@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20240605224527.2907272-1-seanjc@google.com>
 <20240605224527.2907272-2-seanjc@google.com>
 <ZmerKzEHlIwne5ka@yzhao56-desk.sh.intel.com>
 <ZmesywdpFG3qDIkZ@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZmesywdpFG3qDIkZ@google.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QvVDlUdyp1IG/AqG62QDDrWfoiMyUo/F6INdHDS0pEjDdEWujeebiW+G8AEJ?=
 =?us-ascii?Q?y8qxiMAkvMeJ9u/ae502vAsUHFqvqZrRvo7MDJW+OLZZKJlP1GKW9qJ3Cclp?=
 =?us-ascii?Q?HMhOjVsDiFQFVv2MIXRo1mFPQIUc1ZpDaZLCIrOYB43lWB05nLxLK4xT5zNu?=
 =?us-ascii?Q?LHB8pKDsrXkk5VWZOQfRCVYsRJSfIMv+n//gWNj0/Cmv/PTWeMSmn4UfafyA?=
 =?us-ascii?Q?x4jfnDVGQVwJJBgr7ZJB7AC9HT67EVfVHgxBlUe309UQpX3eryY55VehxuIb?=
 =?us-ascii?Q?AiT6W4y+Y7NtxG/6Y8lDWk0YMC+ALRAKOs/JAntgxoFIiBAawDvg7je89+5w?=
 =?us-ascii?Q?M1kzCjgqiTc12VyltSI5FsascfS3u+jhn6j+37FkeNTB+nSSg1z1wdiUKrCc?=
 =?us-ascii?Q?vcckbczOxaTNr3unTqdXfsUlqJ5buNQNeZWnLk5UKazSNgP2SB0f0g5GbJt4?=
 =?us-ascii?Q?0tQC0AS+6MfhYyDWF/FiNghn8vZ+rSiUm9LgpAntJ2etTUuUZgpHy/piUjPa?=
 =?us-ascii?Q?14WkJ0V09poff+KiresUsv35vOZmv31Aj6btbqC2kgTFrNetMdaXGdUbpRl1?=
 =?us-ascii?Q?0omgppc98+E0gb3tXFB9YJtm7Cjx3ydGloT0wm8V5IyTaLNbXfcq5jipTZ8T?=
 =?us-ascii?Q?h5JQmoTXjdpumzcrvWsC/LqDuhlrjeRNygZu1Cu9UXaTSe4+SWRxU/jNSUD8?=
 =?us-ascii?Q?Iiy/GOvxEXQMJQCUZuyoHVIrLvpHRdnH5XzooIncJLz7aOF5jzIWWsdXDNBO?=
 =?us-ascii?Q?e7BUrWH+ML3XWFGj0EkmrigqnTAxVSwAwZF7Ar7SIdyQUo4ZXHCWulw4LIYU?=
 =?us-ascii?Q?iss2TftJ3ZhrKHjQD/3CchPWFch82AXy5T8e32XjS0y90IbxYV5zLm0aF7pA?=
 =?us-ascii?Q?uixXyqMF8GyIMzmvAe+tvUysJLVszf0yxaa4GqaOKQRRho5Qm3+WzJ7wVL7W?=
 =?us-ascii?Q?lK4rIlP3TvD6zZtxx9lBGjIIqceoOWm9gAdlcIzVPqoV3b9oy8PdjhxtB5aW?=
 =?us-ascii?Q?IUSh5CuGHrOBMDI9Ve0ymqZlxhMRgOhUB7Y35oIkQ2CvHILP5BbFkY0KZl3U?=
 =?us-ascii?Q?+2IT4H2CI3oWQXl5EnaHTrX97dS+1Cs+U4+a0YyUcjlxqAAz1YiCOt9ACMw6?=
 =?us-ascii?Q?TLShugA1m9/fOWR0F53MwmbisFB7BMqhadln/aIQIt5Pjegn3SqOpmT8PvdZ?=
 =?us-ascii?Q?mCzc+ZsRJDrg8ZAstZtwpC1UlF3e4UMOHXSbn6u1vtoZPHZn81ZIY/1wOosm?=
 =?us-ascii?Q?6XvYTb2n47AfZigWlPMjxb6NHpeyVrFqV5yzL+C68gwxXP1aMOWb16rUpFIx?=
 =?us-ascii?Q?awImthlbaLM3MkYgDbgqsE8WB0n+sk9LUydNZWYLpLIKiQdxCtPylu7I5bjK?=
 =?us-ascii?Q?LUntTCj9mEfGci9uv6UJEssubOjWCN/aqcLI/d3fUAD1PWoasCmS3W5f3CrP?=
 =?us-ascii?Q?NaoJMuEqBPl+/PLekvEL6u8CojgkiHWVx2FAMUFfcA5Su5EAxVKbTmC1SPzr?=
 =?us-ascii?Q?yB1wjO6gnZHclAgUpxMG4PGAy9W84riat8mAXQioJrSNbhc82OGEuHnHfPLn?=
 =?us-ascii?Q?zT2Cd78J4zGU2kxofMrw4KIBSWVbxdXGxDzh+a/O?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a07e89e6-20a4-4536-0867-08dc89bacebd
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 02:04:20.6448
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wvuvmObsshy7sQGaYvm8TQgDadYDlnqXXQXE5V+Fd8S0S7Ct8sYDFVyVZMIa0hVCjjVgpL7Z6hmbjJs1mwvgFQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6944
X-OriginatorOrg: intel.com

On Mon, Jun 10, 2024 at 06:47:55PM -0700, Sean Christopherson wrote:
> On Tue, Jun 11, 2024, Yan Zhao wrote:
> > On Wed, Jun 05, 2024 at 03:45:26PM -0700, Sean Christopherson wrote:
> > > @@ -7274,6 +7275,8 @@ static void test_pat(u32 field, const char * field_name, u32 ctrl_field,
> > >  					error = 0;
> > >  
> > >  				test_vmx_vmlaunch(error);
> > > +				wrmsr(MSR_IA32_CR_PAT, pat_msr_saved);
> > > +
> > >  				report_prefix_pop();
> > >  
> > >  			} else {	// GUEST_PAT
> > 
> > Is it possible that ENT_LOAD_PAT of GUEST_PAT is tested when there's no support of
> > EXI_LOAD_PAT of HOST_PAT?
> > Then
> > 	wrmsr(MSR_IA32_CR_PAT, pat_msr_saved);
> > is also required in this case?
> 
> Heh, in theory, yeah, a nested setup could create such a monstrosity.  It's easy
> enough to handle, so I guess why not?  Though I'm tempted to assert instead,
> because practically speaking this code will never be hit, and thus never validated.
> 
> diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
> index 2063ee90..ffe7064c 100644
> --- a/x86/vmx_tests.c
> +++ b/x86/vmx_tests.c
> @@ -7288,6 +7288,9 @@ static void test_pat(u32 field, const char * field_name, u32 ctrl_field,
>                                 error = (i == 0x2 || i == 0x3 || i >= 0x8);
>                                 test_guest_state("ENT_LOAD_PAT enabled", !!error,
>                                                  val, "GUEST_PAT");
> +
> +                               if (!(ctrl_exit_rev.clr & EXI_LOAD_PAT))
> +                                       wrmsr(MSR_IA32_CR_PAT, pat_msr_saved);
>                         }
>  
>                 }
Tested passed with EXI_LOAD_PAT intentionally cleared in ctrl_exit_rev.clr.

Reviewed-by: Yan Zhao <yan.y.zhao@intel.com>