Received-SPF: pass (google.com: domain of linux-kernel+bounces-209179-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\))
Subject: Re: [PATCH] livepatch: introduce klp_func called interface
From: zhang warden <zhangwarden@gmail.com>
In-Reply-To: <CAPhsuW4MZ7-UopzbsqhEGzH8FLTK_rTOd05heGOQXm+H7a4a0A@mail.gmail.com>
Date: Tue, 11 Jun 2024 10:23:19 +0800
Cc: Miroslav Benes <mbenes@suse.cz>,
 Petr Mladek <pmladek@suse.com>,
 Josh Poimboeuf <jpoimboe@kernel.org>,
 Jiri Kosina <jikos@kernel.org>,
 Joe Lawrence <joe.lawrence@redhat.com>,
 live-patching@vger.kernel.org,
 LKML <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <0560A816-843A-4FCD-B4E6-D2B1085298CF@gmail.com>
References: <20240520005826.17281-1-zhangwarden@gmail.com>
 <alpine.LSU.2.21.2405200845130.11413@pobox.suse.cz>
 <BBD2A553-6D44-4CD5-94DD-D8B2D5536F94@gmail.com>
 <alpine.LSU.2.21.2405210823590.4805@pobox.suse.cz>
 <ZkxVlIPj9VZ9NJC4@pathway.suse.cz>
 <CAPhsuW7bjyLvfQ-ysKE+S8x26Zv5b7jbJoyW8UiBaUfaRncKfg@mail.gmail.com>
 <alpine.LSU.2.21.2406071102420.29080@pobox.suse.cz>
 <CAPhsuW4MZ7-UopzbsqhEGzH8FLTK_rTOd05heGOQXm+H7a4a0A@mail.gmail.com>
To: Song Liu <song@kernel.org>


> We don't have very urgent use for this. As we discussed, various =
tracing
> tools are sufficient in most cases. I brought this up in the context =
of the
> "called" entry: if we are really adding a new entry, let's do =
"counter"
> instead of "called".
>=20
> Thanks,
> Song

Hi, Song

I hope to find a way to optimize "called" will be set once in =
klp_ftrace_ops function because as Petr said this function should be as =
fast as possible. But if use "count", this variable will be called every =
time klp_ftrace_ops run.

Regards,
Wardenjohn=