Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp86203lqp; Mon, 10 Jun 2024 19:45:29 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXseVMSF/1Go7Wm7tpsl3K9i4fdtVZEVIxSXezzwZRb5EkFuHpZbKelGqO/CZfEJj+qeSQq/wDg+A09pZSE2TvPBX1vQGdhvQAMhkQU0A== X-Google-Smtp-Source: AGHT+IHUD5bhdaC+pvOWkmATcfmQPbt7bQUlhjId3gOQRCuHvPMnGD1zHHmOxIgfIHN0KnB0w6hC X-Received: by 2002:a05:6808:1818:b0:3d2:1839:a5bc with SMTP id 5614622812f47-3d21839a76cmr10927936b6e.29.1718073929547; Mon, 10 Jun 2024 19:45:29 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718073929; cv=pass; d=google.com; s=arc-20160816; b=nyvQm6adBMnSVynuZwN3NopXhyuSKfq240Ujy0qV2961xmFmchBXPsZm+NeE/94Rxo i6u0yMozhrXuH6NH+LMAQv2ZuGf7cYHrvGwbnc8wk5EivrMIrG15uM4LcQ/0laiy6acD gEgDTWJA0mV7c2l3UxvWiUga+yQ10IUOSBnUnHDfpQ99XpF2gK3iUqYLDTCR90FQLlU/ tyTukD4Vu1gWzL2pUpt2HSjSta4aX6r20/btVAXCWNiaoiGeUvQ2kI+aVJX9MaqCC+wt HboydndV3vVEWyk5JICTmB8cZEqEOg0ohA7yHEYtE9buQNbYGjHQW9r+dMMIcB6dNqIw k4uw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:from:subject:message-id:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:dkim-signature; bh=Gw2fVBeEZMK663ax5icKG8q0wolcMNh0B93tTF9ptJo=; fh=XGnOMfvYp0d8xsqHHl+3I05tppBvZZPpzNkTCVQAV+E=; b=AX7u9deUVFaPVMqfXLU2vpcOIuPhMan66M9moVSeI9Uv0EcG1mfbM1YusH4bRAavYa Rb45s3EeSYWIIgBzk59gLYmE/WNerac/PuGJV2NQdetOGN1Lc/yQHcq1hdY8AYiHm6Sh 4yKbi7H6d3yEw4LPTUWnwlOOlm2LFE+Z3mMdzhERYCzNT2x050DaynZoKyOyPYira86o pKEEGJJR0YaFHBaVbdv95mz4eSELfSB7zGHSJVVXOVdAo9kYjurmUGVhAVce3k6sWLal G8y9u5Ogd1edDuihpJe7M9tOOKd3/OzNfnujYGM4s6EFRPUyX2hb8saTZXBFAweBueKg 9P4w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=zVIzuFRW; arc=pass (i=1 spf=pass spfdomain=flex--yosryahmed.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-209193-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-209193-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d2e1a72fcca58-70436ff802esi3514919b3a.13.2024.06.10.19.45.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 19:45:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-209193-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=zVIzuFRW; arc=pass (i=1 spf=pass spfdomain=flex--yosryahmed.bounces.google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-209193-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-209193-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2643F282537 for ; Tue, 11 Jun 2024 02:45:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EA9D615ADBD; Tue, 11 Jun 2024 02:45:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="zVIzuFRW" Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD2A6A2A for ; Tue, 11 Jun 2024 02:45:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718073922; cv=none; b=VXIeTFMduLomn/TdzMAjoUslupB8+O+B3bOJz9QmFVhf3t11QaUx44eE1Pu58G3kRhs1+lxtkJ8xE1MK2GjBAbLmNOFd1WXHMtMJzZTELbgTsuTngSzRCi+KfhB1/U0aPecX1NI8kalfGWihvBoAm3sPS602uXRVWIWsoNkkD9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718073922; c=relaxed/simple; bh=KlWwNTJbnJtKYJtruw5ba7WJcmLia8cxq0tQbQUqaik=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=u6bXaGEAu/6KDQ+tAppRzRrE4sd2FpUtYREGQfp6DwL5/fqYUqBkRi23/gxfFRqEr87DOYU3wfGKcAWYd7D6SwN6DPR2lLYkGSCqWcYoKO0UIZuJgOIdMNVUtNXkuLmRzMHPt0TgKTu6HFxUj4YjMuarcxHhGhebCnHiSuMFSfM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--yosryahmed.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=zVIzuFRW; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--yosryahmed.bounces.google.com Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dfa56e1a163so9440666276.3 for ; Mon, 10 Jun 2024 19:45:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718073919; x=1718678719; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=Gw2fVBeEZMK663ax5icKG8q0wolcMNh0B93tTF9ptJo=; b=zVIzuFRWJNr+f0pdTX04lxXh4fXGFK/Qi1BdIi8N+/QbJwOo4w1x+7Zn1/SLIglEbN A8WSC63RcC58tMp9zmd+Y49MQNAvst+wwDNrqmY/UzEp1ttBq2ts5+/WXKTeBKiFF1NI W+VwXJAvTRsOudU/ThDpXOjl6R7Ir1KfN6E9QHjUr1ySud7yTG7rQZSfB5Y4zS9/KV68 aa7uag2ZVIgIi6bb6i/MEDSrWtFTTYPmJi7nFMCYZcYGqxe3aBt7++9zA/7f0+j43xoF ztoB1m6m22UVY3NRQqMYIHBp/qzPhugS8yo+g4jAreVk/aN2FWftz0zRQ9PGVMy9IIt3 KqKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718073919; x=1718678719; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Gw2fVBeEZMK663ax5icKG8q0wolcMNh0B93tTF9ptJo=; b=rk3PPrw0GpbRszn8lwORcfulUi7SajstsF/ODfX245dt8sdrXYfjqlAZ/jd1waRQdo HqfeZXfXobDiqjM6QKmRurzzdNPcfQC3w//fZkXMwcIGJ5t1SfssHaghqSd3o7GIdDye IuDKSphwPGEscfcL6XoZuW65TxdiLlCdD+oJLBQcdIk3y59UQxcAIhJfsQ2GRI3P9kPZ VHddEuN6+AkmEBXYqwub0NLZBLxb8JRqc6EeVWWtRGUtTJiMRUSQ0+U4x1WSBRVW1jJC 0nPo/h8NihsNdVGh6yWpFgrzV6p/Oz9RaLJ2TpDV5MbZmF/SO1rX68S7Z/F+bq4jKCOj 7EPQ== X-Forwarded-Encrypted: i=1; AJvYcCVQnCmvCpe3xo0Jt8wL30rtEPYWvwfJuo9LjfJuJ1iprpkHG4rbeftU2sOT4DPE0en+QKmNdQxD/KeG2MbCEoKlfcqZ8apoK7UVITTX X-Gm-Message-State: AOJu0YwQMs2MZTiTqe5mjOBYBMl839z4rjpCKQ2YM+Mqjyaf7th5U7Dk 1P8NKMdLVF7EP7c1+P8yDRAyHol43G4ze/9etdlc/ov0I/nTeLgyvBOz+ME/U6uUcfKRZ5xgVHu jDaioo3pD9hDCfwXfPA== X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a05:6902:188f:b0:df7:8c1b:430a with SMTP id 3f1490d57ef6-dfaf64ea35emr3779077276.3.1718073918970; Mon, 10 Jun 2024 19:45:18 -0700 (PDT) Date: Tue, 11 Jun 2024 02:45:14 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.45.2.505.gda0bf45e8d-goog Message-ID: <20240611024516.1375191-1-yosryahmed@google.com> Subject: [PATCH v3 1/3] mm: zswap: rename is_zswap_enabled() to zswap_is_enabled() From: Yosry Ahmed To: Andrew Morton Cc: Johannes Weiner , Nhat Pham , Chengming Zhou , Barry Song <21cnbao@gmail.com>, Chris Li , David Hildenbrand , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yosry Ahmed Content-Type: text/plain; charset="UTF-8" In preparation of introducing a similar function, rename is_zswap_enabled() to use zswap_* prefix like other zswap functions. Signed-off-by: Yosry Ahmed --- include/linux/zswap.h | 4 ++-- mm/memcontrol.c | 2 +- mm/zswap.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/zswap.h b/include/linux/zswap.h index 2a85b941db975..ce5e7bfe8f1ec 100644 --- a/include/linux/zswap.h +++ b/include/linux/zswap.h @@ -35,7 +35,7 @@ void zswap_swapoff(int type); void zswap_memcg_offline_cleanup(struct mem_cgroup *memcg); void zswap_lruvec_state_init(struct lruvec *lruvec); void zswap_folio_swapin(struct folio *folio); -bool is_zswap_enabled(void); +bool zswap_is_enabled(void); #else struct zswap_lruvec_state {}; @@ -60,7 +60,7 @@ static inline void zswap_memcg_offline_cleanup(struct mem_cgroup *memcg) {} static inline void zswap_lruvec_state_init(struct lruvec *lruvec) {} static inline void zswap_folio_swapin(struct folio *folio) {} -static inline bool is_zswap_enabled(void) +static inline bool zswap_is_enabled(void) { return false; } diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 1303ed01bb5e5..a811dfff10cda 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -8469,7 +8469,7 @@ void obj_cgroup_uncharge_zswap(struct obj_cgroup *objcg, size_t size) bool mem_cgroup_zswap_writeback_enabled(struct mem_cgroup *memcg) { /* if zswap is disabled, do not block pages going to the swapping device */ - return !is_zswap_enabled() || !memcg || READ_ONCE(memcg->zswap_writeback); + return !zswap_is_enabled() || !memcg || READ_ONCE(memcg->zswap_writeback); } static u64 zswap_current_read(struct cgroup_subsys_state *css, diff --git a/mm/zswap.c b/mm/zswap.c index b9b35ef86d9be..a8c8dd8cfe6f5 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -131,7 +131,7 @@ static bool zswap_shrinker_enabled = IS_ENABLED( CONFIG_ZSWAP_SHRINKER_DEFAULT_ON); module_param_named(shrinker_enabled, zswap_shrinker_enabled, bool, 0644); -bool is_zswap_enabled(void) +bool zswap_is_enabled(void) { return zswap_enabled; } -- 2.45.2.505.gda0bf45e8d-goog